[Bug 25056] New: Worms Armageddon's "Fill" and "Random Holes" map editor tools produce interlaced images

http://bugs.winehq.org/show_bug.cgi?id=25056

Summary: Worms Armageddon's "Fill" and "Random Holes" map
                    editor tools produce interlaced images
           Product: Wine
           Version: 1.3.6
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: winex11.drv
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=31767)
 --> (http://bugs.winehq.org/attachment.cgi?id=31767)
winex11: Add X11DRV_PALETTE_GetColor function to resolve any COLORREF to an RGB

Using the "Fill" (paint bucket) and "Random holes" tools in the map editor
(both to erase and fill terrain) will cause the respective areas to be filled
with a vertically-interlaced pattern.

The pattern is actually a monochrome gray brush. Worms Armageddon passes
palette indices for white and black (PALETTEINDEX COLORREF values) to
CreateSolidBrush. BRUSH_SelectSolidBrush's check for monochrome surfaces
incorrectly compares the passed COLORREF to the RGB values of white and black,
and therefore considers the passed COLORREF (0x01000000 or 0x01000001) to be a
non-monochrome color.

Attached patches fix the problem by adding a function to convert any COLORREF
to an RGB COLORREF, and by making BRUSH_SelectSolidBrush use it.

[Bug 25056] Worms Armageddon's "Fill" and "Random Holes" map editor tools produce interlaced images

http://bugs.winehq.org/show_bug.cgi?id=25056

--- Comment #1 from Vladimir Panteleev  2010-11-06 22:53:23 CDT ---
Created an attachment (id=31768)
 --> (http://bugs.winehq.org/attachment.cgi?id=31768)
winex11: correctly handle non-RGB COLORREFs in BRUSH_SelectSolidBrush

[Bug 25056] Worms Armageddon's "Fill" and "Random Holes" map editor tools produce interlaced images

http://bugs.winehq.org/show_bug.cgi?id=25056

Vladimir Panteleev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31767|0                           |1
           is patch|                            |

[Bug 25056] Worms Armageddon's "Fill" and "Random Holes" map editor tools produce interlaced images

http://bugs.winehq.org/show_bug.cgi?id=25056

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #2 from Austin English  2010-11-06 23:09:59 CDT ---
Patches should be sent to [e-mail]

[Bug 25056] Worms Armageddon's "Fill" and "Random Holes" map editor tools produce interlaced images

http://bugs.winehq.org/show_bug.cgi?id=25056

--- Comment #3 from Vladimir Panteleev  2010-11-07 08:28:18 CST ---
I know, I put them here first in case anyone has any comments before I send
them there.

[Bug 25056] Worms Armageddon's "Fill" and "Random Holes" map editor tools produce interlaced images

http://bugs.winehq.org/show_bug.cgi?id=25056

Vladimir Panteleev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Vladimir Panteleev  2010-11-13 09:28:05 CST ---
Patch was accepted, the issue is fixed in 1.3.7.

[Bug 25056] Worms Armageddon's "Fill" and "Random Holes" map editor tools produce interlaced images

http://bugs.winehq.org/show_bug.cgi?id=25056

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  2010-11-26 13:13:38 CST ---
Closing bugs fixed in 1.3.8.

[Bug 25056] Worms Armageddon's "Fill" and "Random Holes" map editor tools produce interlaced images

http://bugs.winehq.org/show_bug.cgi?id=25056

--- Comment #6 from Vladimir Panteleev  2010-11-26 13:15:15 CST ---
Alexandre, this bug was fixed in Wine 1.3.7.