[Bug 25590] New: PhysX: Fails to uninstall

http://bugs.winehq.org/show_bug.cgi?id=25590

Summary: PhysX: Fails to uninstall
           Product: Wine
           Version: 1.3.9
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Steps to reproduce:
1) remove ~/.wine
2) install PhysX_9.10.0513_SystemSoftware.exe 
3) wine uninstaller
4) select NVIDIA PhysX
5) Press Remove...
6) Select Remove and press Next

Behaviour:
NVIDIA PhysX has been successfully installed.

Expected behaviour:
NVIDIA PhysX has been successfully uninstalled.

Terminal output:
fixme:storage:create_storagefile Storage share mode not implemented.
err:msi:call_script Could not find CLSID for Windows Script
err:msi:msi_dialog_create_controls no handler for element type L"Billboard"
fixme:msi:ITERATE_RemoveExistingProducts remove L" "

Additional information:
I'm using wine-1.3.9-245-g32b4c7d

[Bug 25590] PhysX: Fails to uninstall

http://bugs.winehq.org/show_bug.cgi?id=25590

NSLW  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, Installer
                URL|                            |http://us.download.nvidia.c
                   |                            |om/Windows/9.10.0513/PhysX_
                   |                            |9.10.0513_SystemSoftware.ex
                   |                            |e

[Bug 25590] PhysX: Fails to uninstall

http://bugs.winehq.org/show_bug.cgi?id=25590

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]
     Ever Confirmed|0                           |1

--- Comment #1 from Dan Kegel  2010-12-22 11:45:55 CST ---
For me, with wine-1.3.9-210-g8bcc61f, the uninstaller reports success,
but the entry is not removed from the uninstall list.

winetricks wsh57 doesn't help much; the console log loses the line
err:msi:call_script Could not find CLSID for Windows Script
and gains
err:msi:MsiActiveScriptSite_OnScriptError script error: L"Type mismatch:
'Property'"
but the package still shows up in the uninstaller list after uninstall
finishes.

[Bug 25590] PhysX: Fails to uninstall

http://bugs.winehq.org/show_bug.cgi?id=25590

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Hans Leidekker  2010-12-23 03:27:29 CST ---
The UninstallString value of the Uninstall key is wrong. We set it to
"msiexec.exe /I{3F5C371F-8EA2-4F25-9D3D-D0B4526E3AEA}" but on Windows
it's "msiexec.exe /X{3F5C371F-8EA2-4F25-9D3D-D0B4526E3AEA}".

Blindly changing this breaks some tests, so there must be something in
the installer that decides which command is chosen. It's not the version.

[Bug 25590] PhysX: Fails to uninstall

http://bugs.winehq.org/show_bug.cgi?id=25590

--- Comment #3 from Hans Leidekker  2010-12-23 05:16:42 CST ---
Regardless of the incorrect value for UninstallString, native appears
to ignore this value if WindowsInstaller is set to 1.

We should fix uninstaller to do the same.

[Bug 25590] PhysX: Fails to uninstall

http://bugs.winehq.org/show_bug.cgi?id=25590

--- Comment #4 from Hans Leidekker  2010-12-23 12:14:04 CST ---
> We should fix uninstaller to do the same.

Committed as fea5767a025e24d4592eb1e89c6a9a402bc73442.

[Bug 25590] PhysX: Fails to uninstall

http://bugs.winehq.org/show_bug.cgi?id=25590

--- Comment #5 from NSLW  2010-12-24 04:15:33 CST ---
(In reply to comment #4)
> > We should fix uninstaller to do the same.
>
> Committed as fea5767a025e24d4592eb1e89c6a9a402bc73442.

Nothing changed in wine-1.3.9-325-gfea5767.

Terminal output:
fixme:storage:create_storagefile Storage share mode not implemented.
err:msi:call_script Could not find CLSID for Windows Script
err:msi:msi_dialog_create_controls no handler for element type L"Billboard"
fixme:msi:ITERATE_RemoveExistingProducts remove L" "

[Bug 25590] PhysX: Fails to uninstall

http://bugs.winehq.org/show_bug.cgi?id=25590

--- Comment #6 from Hans Leidekker  2010-12-24 05:18:36 CST ---
> Nothing changed in wine-1.3.9-325-gfea5767.

Try this patch:
http://www.winehq.org/pipermail/wine-patches/2010-December/097150.html

The installer will tell you that's installing the app instead of
removing it, which is another bug. It does remove the files but
leaves a number of empty directories behind, which is another bug.

And the entry under the Uninstall key is not removed, nor is the
cached local package deleted, which is yet another bug.

[Bug 25590] PhysX: Fails to uninstall

http://bugs.winehq.org/show_bug.cgi?id=25590

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Hans Leidekker  2010-12-24 05:32:21 CST ---
*** Bug 23721 has been marked as a duplicate of this bug. ***

[Bug 25590] PhysX: Fails to uninstall

http://bugs.winehq.org/show_bug.cgi?id=25590

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Hans Leidekker  2010-12-24 05:36:38 CST ---
*** Bug 13883 has been marked as a duplicate of this bug. ***

[Bug 25590] PhysX: Fails to uninstall

http://bugs.winehq.org/show_bug.cgi?id=25590

--- Comment #9 from NSLW  2010-12-24 10:25:11 CST ---
(In reply to comment #6)
> > Nothing changed in wine-1.3.9-325-gfea5767.
>
> Try this patch:
> http://www.winehq.org/pipermail/wine-patches/2010-December/097150.html
>
> The installer will tell you that's installing the app instead of
> removing it, which is another bug. It does remove the files but
> leaves a number of empty directories behind, which is another bug.
>
> And the entry under the Uninstall key is not removed, nor is the
> cached local package deleted, which is yet another bug.

It is exactly as you say. Should I report these issues as separate bugs?

[Bug 25590] PhysX: Fails to uninstall

http://bugs.winehq.org/show_bug.cgi?id=25590

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |programs

--- Comment #10 from Hans Leidekker  2010-12-24 10:32:29 CST ---
(In reply to comment #9)
> It is exactly as you say. Should I report these issues as separate bugs?

Yes please.

[Bug 25590] PhysX: Uninstaller says that it installs app instead of removing it

http://bugs.winehq.org/show_bug.cgi?id=25590

NSLW  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|PhysX: Fails to uninstall   |PhysX: Uninstaller says
                   |                            |that it installs app
                   |                            |instead of removing it

[Bug 25590] PhysX: Uninstaller says that it installs app instead of removing it

http://bugs.winehq.org/show_bug.cgi?id=25590

--- Comment #11 from Austin English  2013-06-11 23:27:29 CDT ---
The bug in the summary, "PhysX: Uninstaller says that it installs app instead
of removing it" is still present in wine-1.6-rc1-18-gb82a5ab.

When you finish, the directory is gone from Program Files. Grepping for
nvidia/physx shows no files in ~/.wine/drive_c. The entry is also gone from the
uninstaller list.

So this appears to be the only bug left, at least from the comments listed
here.

[Bug 25590] PhysX: Uninstaller says that it installs app instead of removing it

https://bugs.winehq.org/show_bug.cgi?id=25590

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |[e-mail]
         Resolution|---                         |FIXED

--- Comment #12 from Wylda  ---
This could be invalid, because the "Expected behaviour" does not exist under
WinXP. Removing under WinXP also says "Successfully Installed".

As there were objective fixes around the installer, let's mark it FIXED.

[Bug 25590] PhysX: Uninstaller says that it installs app instead of removing it

https://bugs.winehq.org/show_bug.cgi?id=25590

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #13 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.30.