[Bug 18973] New: Duplicate license entries in multiple wine programs

http://bugs.winehq.org/show_bug.cgi?id=18973

Summary: Duplicate license entries in multiple wine programs
           Product: Wine
           Version: 1.1.23
          Platform: PC
               URL: http://winehq.org
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: programs
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Alphabetically from http://wiki.winehq.org/ListofCommands

clock has an "Info" menu with "License", "NO WARRANTY" and "About clock", all
three which have a link to the Wine license.

iexplore doesn't have any menu.

progman has a "Help" menu, with an "Info" submenu containing "License", "NO
WARRANTY" and "About WINE" (sic) items. It also has duplicate entries and a lot
of unimplemented menu items...

winemine has an "Info" menu, with an "About" entry under "Fastest times"

winecfg has no menu, license information is contained in the "About" tab.

control, notepad, regedit, oleview, wordpad and explorer all have that last
entry in the "Help" menu. Multiple of those have duplicate Help
entries/duplicate keybinds but that's another bug...

All of this could really use some cleanup.

[Bug 18973] Duplicate license entries in multiple wine programs

http://bugs.winehq.org/show_bug.cgi?id=18973

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |trivial

[Bug 18973] Duplicate license entries in multiple wine programs

http://bugs.winehq.org/show_bug.cgi?id=18973

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, source
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]
     Ever Confirmed|0                           |1

--- Comment #1 from Austin English   2009-06-17 10:48:54 ---
Really, we should be consistent across our built in programs...

[Bug 18973] Duplicate license entries in multiple wine programs

http://bugs.winehq.org/show_bug.cgi?id=18973

--- Comment #2 from Jerome Leclanche   2009-10-29 18:48:26 ---
No change in wine-1.1.32.

[Bug 18973] Duplicate license entries in multiple wine programs

http://bugs.winehq.org/show_bug.cgi?id=18973

Detlef Riekenberg  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
   Target Milestone|---                         |1.2.0

[Bug 18973] Duplicate license entries in multiple wine programs

http://bugs.winehq.org/show_bug.cgi?id=18973

--- Comment #3 from Alexander Scott-Johns   2010-05-15 08:03:34 ---
Created an attachment (id=27980)
 --> (http://bugs.winehq.org/attachment.cgi?id=27980)
Patch for clock

[Bug 18973] Duplicate license entries in multiple wine programs

http://bugs.winehq.org/show_bug.cgi?id=18973

Alexander Scott-Johns  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexander.scott.johns+wineb
                   |                            |[e-mail]

[Bug 18973] Duplicate license entries in multiple wine programs

http://bugs.winehq.org/show_bug.cgi?id=18973

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from André H.   2010-05-18 11:41:21 ---
patch for progman sent:
http://www.winehq.org/pipermail/wine-patches/2010-May/088586.html

[Bug 18973] Duplicate license entries in multiple wine programs

http://bugs.winehq.org/show_bug.cgi?id=18973

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 18973] Duplicate license entries in multiple wine programs

http://bugs.winehq.org/show_bug.cgi?id=18973

--- Comment #5 from André H.   2010-05-18 13:05:11 ---
(In reply to comment #3)
> Created an attachment (id=27980)

--> (http://bugs.winehq.org/attachment.cgi?id=27980) [details]
> Patch for clock

Alexander, my patch got committed but i didnt removed that warranty stuff.
try sending your patch please

[Bug 18973] Duplicate license entries in multiple wine programs

http://bugs.winehq.org/show_bug.cgi?id=18973

--- Comment #6 from André H.   2010-05-24 16:49:07 ---
(In reply to comment #6)

Thats whats left:
> iexplore doesn't have any menu.

there is a gsoc project about that i think.
> winemine has an "Info" menu, with an "About" entry under "Fastest times"

also in other windows of it, but i think that is not so bad.
> winecfg has no menu, license information is contained in the "About" tab.

i think a menu in winecfg is not very useful

So what about the bug status?

[Bug 18973] Duplicate license entries in multiple wine programs

http://bugs.winehq.org/show_bug.cgi?id=18973

--- Comment #7 from Jerome Leclanche   2010-05-24 19:58:29 ---
(In reply to comment #6)
> (In reply to comment #6)
>
> Thats whats left:
> > iexplore doesn't have any menu.
>
> there is a gsoc project about that i think.
> > winemine has an "Info" menu, with an "About" entry under "Fastest times"
>
> also in other windows of it, but i think that is not so bad.
> > winecfg has no menu, license information is contained in the "About" tab.
>
> i think a menu in winecfg is not very useful
>
> So what about the bug status?

Great job removing all the duplicate stuff. If I'm going to nitpick, I'd say we
also need to be consistent within the name of the menu item ("About", vs "About
Wine", vs "About [program]"). Otherwise this can be resolved as fixed.

[Bug 18973] Duplicate license entries in multiple wine programs

http://bugs.winehq.org/show_bug.cgi?id=18973

--- Comment #8 from Jerome Leclanche   2010-05-24 20:00:05 ---
> Great job removing all the duplicate stuff. If I'm going to nitpick, I'd say we
> also need to be consistent within the name of the menu item ("About", vs "About
> Wine", vs "About [program]"). Otherwise this can be resolved as fixed.

I personally think "About [program]" is the simplest and best way to do it.

[Bug 18973] Duplicate license entries in multiple wine programs

http://bugs.winehq.org/show_bug.cgi?id=18973

Alexander Scott-Johns  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27980|0                           |1
        is obsolete|                            |

--- Comment #9 from Alexander Scott-Johns   2010-06-06 17:17:34 ---
(From update of attachment 27980)
While I remember: this has been committed as
http://source.winehq.org/git/wine.git/?a=commit;h=6d49edef371a47d9e60c6af01a...

[Bug 18973] Duplicate license entries in multiple wine programs

http://bugs.winehq.org/show_bug.cgi?id=18973

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #10 from Jerome Leclanche   2010-06-06 17:42:19 ---
Fixed.

[Bug 18973] Duplicate license entries in multiple wine programs

http://bugs.winehq.org/show_bug.cgi?id=18973

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #11 from Alexandre Julliard   2010-06-11 12:51:36 ---
Closing bugs fixed in 1.2-rc3.

[Bug 18973] Duplicate license entries in multiple wine programs

http://bugs.winehq.org/show_bug.cgi?id=18973

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |6d49edef371a47d9e60c6af01ad
                   |                            |73dc7aa907618