[Bug 38442] New: valgrind shows some uninitialized variables in d3d10core/tests/device.c test_scissor()

https://bugs.winehq.org/show_bug.cgi?id=38442

Bug ID: 38442
           Summary: valgrind shows some uninitialized variables in
                    d3d10core/tests/device.c test_scissor()
           Product: Wine
           Version: 1.7.41
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: download, source, testcase, valgrind
          Severity: normal
          Priority: P2
         Component: directx-d3d
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

../../../tools/runtest -q -P wine -T ../../.. -M d3d10core.dll -p
d3d10core_test.exe.so device && touch device.ok
==6421== Invalid read of size 4
==6421==    at 0x4970039: context_release (context.c:1161)
==6421==    by 0x49814CD: wined3d_device_uninit_3d (device.c:1126)
==6421==    by 0x491A039: dxgi_device_Release (device.c:83)
==6421==    by 0x48DDD40: d3d10_device_Release (device.c:120)
==6421==    by 0x48732D7: ID3D10Device_Release (d3d10.h:5505)
==6421==    by 0x48732D7: test_scissor (???:0)
==6421==    by 0x487E4D6: func_device (device.c:3167)
==6421==    by 0x487F22D: run_test (test.h:584)
==6421==    by 0x487F666: main (test.h:666)
==6421==  Address 0x7f0ff6e4 is 4,060 bytes inside a block of size 4,884 free'd
==6421==    at 0x7BC49E5B: notify_free (heap.c:262)
==6421==    by 0x7BC4E178: RtlFreeHeap (heap.c:1761)
==6421==    by 0x4973195: context_destroy (context.c:1810)
==6421==    by 0x4A2308E: swapchain_cleanup (swapchain.c:65)
==6421==    by 0x4A23332: wined3d_swapchain_decref (swapchain.c:108)
==6421==    by 0x4A285E2: wined3d_texture_decref (texture.c:418)
==6421==    by 0x4A2A289: texture_resource_decref (texture.c:940)
==6421==    by 0x4A3AEB3: wined3d_resource_decref (wined3d_private.h:2138)
==6421==    by 0x4A3B01B: wined3d_rendertarget_view_decref (view.c:47)
==6421==    by 0x498BD8C: wined3d_device_set_rendertarget_view (device.c:3991)
==6421==    by 0x4981484: wined3d_device_uninit_3d (device.c:1118)
==6421==    by 0x491A039: dxgi_device_Release (device.c:83)
==6421==    by 0x48DDD40: d3d10_device_Release (device.c:120)
==6421==    by 0x48732D7: ID3D10Device_Release (d3d10.h:5505)
==6421==    by 0x48732D7: test_scissor (???:0)
==6421==    by 0x487E4D6: func_device (device.c:3167)
==6421==    by 0x487F22D: run_test (test.h:584)
==6421==    by 0x487F666: main (test.h:666)
==6421==

==6421== Invalid write of size 4
==6421==    at 0x4970045: context_release (context.c:1161)
==6421==    by 0x49814CD: wined3d_device_uninit_3d (device.c:1126)
==6421==    by 0x491A039: dxgi_device_Release (device.c:83)
==6421==    by 0x48DDD40: d3d10_device_Release (device.c:120)
==6421==    by 0x48732D7: ID3D10Device_Release (d3d10.h:5505)
==6421==    by 0x48732D7: test_scissor (???:0)
==6421==    by 0x487E4D6: func_device (device.c:3167)
==6421==    by 0x487F22D: run_test (test.h:584)
==6421==    by 0x487F666: main (test.h:666)
==6421==  Address 0x7f0ff6e4 is 4,060 bytes inside a block of size 4,884 free'd
==6421==    at 0x7BC49E5B: notify_free (heap.c:262)
==6421==    by 0x7BC4E178: RtlFreeHeap (heap.c:1761)
==6421==    by 0x4973195: context_destroy (context.c:1810)
==6421==    by 0x4A2308E: swapchain_cleanup (swapchain.c:65)
==6421==    by 0x4A23332: wined3d_swapchain_decref (swapchain.c:108)
==6421==    by 0x4A285E2: wined3d_texture_decref (texture.c:418)
==6421==    by 0x4A2A289: texture_resource_decref (texture.c:940)
==6421==    by 0x4A3AEB3: wined3d_resource_decref (wined3d_private.h:2138)
==6421==    by 0x4A3B01B: wined3d_rendertarget_view_decref (view.c:47)
==6421==    by 0x498BD8C: wined3d_device_set_rendertarget_view (device.c:3991)
==6421==    by 0x4981484: wined3d_device_uninit_3d (device.c:1118)
==6421==    by 0x491A039: dxgi_device_Release (device.c:83)
==6421==    by 0x48DDD40: d3d10_device_Release (device.c:120)
==6421==    by 0x48732D7: ID3D10Device_Release (d3d10.h:5505)
==6421==    by 0x48732D7: test_scissor (???:0)
==6421==    by 0x487E4D6: func_device (device.c:3167)
==6421==    by 0x487F22D: run_test (test.h:584)
==6421==    by 0x487F666: main (test.h:666)
==6421==

==6421== Invalid read of size 4
==6421==    at 0x497004E: context_release (context.c:1161)
==6421==    by 0x49814CD: wined3d_device_uninit_3d (device.c:1126)
==6421==    by 0x491A039: dxgi_device_Release (device.c:83)
==6421==    by 0x48DDD40: d3d10_device_Release (device.c:120)
==6421==    by 0x48732D7: ID3D10Device_Release (d3d10.h:5505)
==6421==    by 0x48732D7: test_scissor (???:0)
==6421==    by 0x487E4D6: func_device (device.c:3167)
==6421==    by 0x487F22D: run_test (test.h:584)
==6421==    by 0x487F666: main (test.h:666)
==6421==  Address 0x7f0ff6e4 is 4,060 bytes inside a block of size 4,884 free'd
==6421==    at 0x7BC49E5B: notify_free (heap.c:262)
==6421==    by 0x7BC4E178: RtlFreeHeap (heap.c:1761)
==6421==    by 0x4973195: context_destroy (context.c:1810)
==6421==    by 0x4A2308E: swapchain_cleanup (swapchain.c:65)
==6421==    by 0x4A23332: wined3d_swapchain_decref (swapchain.c:108)
==6421==    by 0x4A285E2: wined3d_texture_decref (texture.c:418)
==6421==    by 0x4A2A289: texture_resource_decref (texture.c:940)
==6421==    by 0x4A3AEB3: wined3d_resource_decref (wined3d_private.h:2138)
==6421==    by 0x4A3B01B: wined3d_rendertarget_view_decref (view.c:47)
==6421==    by 0x498BD8C: wined3d_device_set_rendertarget_view (device.c:3991)
==6421==    by 0x4981484: wined3d_device_uninit_3d (device.c:1118)
==6421==    by 0x491A039: dxgi_device_Release (device.c:83)
==6421==    by 0x48DDD40: d3d10_device_Release (device.c:120)
==6421==    by 0x48732D7: ID3D10Device_Release (d3d10.h:5505)
==6421==    by 0x48732D7: test_scissor (???:0)
==6421==    by 0x487E4D6: func_device (device.c:3167)
==6421==    by 0x487F22D: run_test (test.h:584)
==6421==    by 0x487F666: main (test.h:666)
==6421==

==6421== Invalid read of size 4
==6421==    at 0x496EAC7: context_restore_pixel_format (context.c:771)
==6421==    by 0x4970066: context_release (context.c:1163)
==6421==    by 0x49814CD: wined3d_device_uninit_3d (device.c:1126)
==6421==    by 0x491A039: dxgi_device_Release (device.c:83)
==6421==    by 0x48DDD40: d3d10_device_Release (device.c:120)
==6421==    by 0x48732D7: ID3D10Device_Release (d3d10.h:5505)
==6421==    by 0x48732D7: test_scissor (???:0)
==6421==    by 0x487E4D6: func_device (device.c:3167)
==6421==    by 0x487F22D: run_test (test.h:584)
==6421==    by 0x487F666: main (test.h:666)
==6421==  Address 0x7f0fe708 is 0 bytes inside a block of size 4,884 free'd
==6421==    at 0x7BC49E5B: notify_free (heap.c:262)
==6421==    by 0x7BC4E178: RtlFreeHeap (heap.c:1761)
==6421==    by 0x4973195: context_destroy (context.c:1810)
==6421==    by 0x4A2308E: swapchain_cleanup (swapchain.c:65)
==6421==    by 0x4A23332: wined3d_swapchain_decref (swapchain.c:108)
==6421==    by 0x4A285E2: wined3d_texture_decref (texture.c:418)
==6421==    by 0x4A2A289: texture_resource_decref (texture.c:940)
==6421==    by 0x4A3AEB3: wined3d_resource_decref (wined3d_private.h:2138)
==6421==    by 0x4A3B01B: wined3d_rendertarget_view_decref (view.c:47)
==6421==    by 0x498BD8C: wined3d_device_set_rendertarget_view (device.c:3991)
==6421==    by 0x4981484: wined3d_device_uninit_3d (device.c:1118)
==6421==    by 0x491A039: dxgi_device_Release (device.c:83)
==6421==    by 0x48DDD40: d3d10_device_Release (device.c:120)
==6421==    by 0x48732D7: ID3D10Device_Release (d3d10.h:5505)
==6421==    by 0x48732D7: test_scissor (???:0)
==6421==    by 0x487E4D6: func_device (device.c:3167)
==6421==    by 0x487F22D: run_test (test.h:584)
==6421==    by 0x487F666: main (test.h:666)
==6421==

==6421== Invalid read of size 4
==6421==    at 0x496EAD6: context_restore_pixel_format (context.c:774)
==6421==    by 0x4970066: context_release (context.c:1163)
==6421==    by 0x49814CD: wined3d_device_uninit_3d (device.c:1126)
==6421==    by 0x491A039: dxgi_device_Release (device.c:83)
==6421==    by 0x48DDD40: d3d10_device_Release (device.c:120)
==6421==    by 0x48732D7: ID3D10Device_Release (d3d10.h:5505)
==6421==    by 0x48732D7: test_scissor (???:0)
==6421==    by 0x487E4D6: func_device (device.c:3167)
==6421==    by 0x487F22D: run_test (test.h:584)
==6421==    by 0x487F666: main (test.h:666)
==6421==  Address 0x7f0ff6f0 is 4,072 bytes inside a block of size 4,884 free'd
==6421==    at 0x7BC49E5B: notify_free (heap.c:262)
==6421==    by 0x7BC4E178: RtlFreeHeap (heap.c:1761)
==6421==    by 0x4973195: context_destroy (context.c:1810)
==6421==    by 0x4A2308E: swapchain_cleanup (swapchain.c:65)
==6421==    by 0x4A23332: wined3d_swapchain_decref (swapchain.c:108)
==6421==    by 0x4A285E2: wined3d_texture_decref (texture.c:418)
==6421==    by 0x4A2A289: texture_resource_decref (texture.c:940)
==6421==    by 0x4A3AEB3: wined3d_resource_decref (wined3d_private.h:2138)
==6421==    by 0x4A3B01B: wined3d_rendertarget_view_decref (view.c:47)
==6421==    by 0x498BD8C: wined3d_device_set_rendertarget_view (device.c:3991)
==6421==    by 0x4981484: wined3d_device_uninit_3d (device.c:1118)
==6421==    by 0x491A039: dxgi_device_Release (device.c:83)
==6421==    by 0x48DDD40: d3d10_device_Release (device.c:120)
==6421==    by 0x48732D7: ID3D10Device_Release (d3d10.h:5505)
==6421==    by 0x48732D7: test_scissor (???:0)
==6421==    by 0x487E4D6: func_device (device.c:3167)
==6421==    by 0x487F22D: run_test (test.h:584)
==6421==    by 0x487F666: main (test.h:666)
==6421==

==6421== Invalid write of size 4
==6421==    at 0x496EC28: context_restore_pixel_format (context.c:795)
==6421==    by 0x4970066: context_release (context.c:1163)
==6421==    by 0x49814CD: wined3d_device_uninit_3d (device.c:1126)
==6421==    by 0x491A039: dxgi_device_Release (device.c:83)
==6421==    by 0x48DDD40: d3d10_device_Release (device.c:120)
==6421==    by 0x48732D7: ID3D10Device_Release (d3d10.h:5505)
==6421==    by 0x48732D7: test_scissor (???:0)
==6421==    by 0x487E4D6: func_device (device.c:3167)
==6421==    by 0x487F22D: run_test (test.h:584)
==6421==    by 0x487F666: main (test.h:666)
==6421==  Address 0x7f0ff6f0 is 4,072 bytes inside a block of size 4,884 free'd
==6421==    at 0x7BC49E5B: notify_free (heap.c:262)
==6421==    by 0x7BC4E178: RtlFreeHeap (heap.c:1761)
==6421==    by 0x4973195: context_destroy (context.c:1810)
==6421==    by 0x4A2308E: swapchain_cleanup (swapchain.c:65)
==6421==    by 0x4A23332: wined3d_swapchain_decref (swapchain.c:108)
==6421==    by 0x4A285E2: wined3d_texture_decref (texture.c:418)
==6421==    by 0x4A2A289: texture_resource_decref (texture.c:940)
==6421==    by 0x4A3AEB3: wined3d_resource_decref (wined3d_private.h:2138)
==6421==    by 0x4A3B01B: wined3d_rendertarget_view_decref (view.c:47)
==6421==    by 0x498BD8C: wined3d_device_set_rendertarget_view (device.c:3991)
==6421==    by 0x4981484: wined3d_device_uninit_3d (device.c:1118)
==6421==    by 0x491A039: dxgi_device_Release (device.c:83)
==6421==    by 0x48DDD40: d3d10_device_Release (device.c:120)
==6421==    by 0x48732D7: ID3D10Device_Release (d3d10.h:5505)
==6421==    by 0x48732D7: test_scissor (???:0)
==6421==    by 0x487E4D6: func_device (device.c:3167)
==6421==    by 0x487F22D: run_test (test.h:584)
==6421==    by 0x487F666: main (test.h:666)
==6421==

==6421== Invalid write of size 4
==6421==    at 0x496EC35: context_restore_pixel_format (context.c:796)
==6421==    by 0x4970066: context_release (context.c:1163)
==6421==    by 0x49814CD: wined3d_device_uninit_3d (device.c:1126)
==6421==    by 0x491A039: dxgi_device_Release (device.c:83)
==6421==    by 0x48DDD40: d3d10_device_Release (device.c:120)
==6421==    by 0x48732D7: ID3D10Device_Release (d3d10.h:5505)
==6421==    by 0x48732D7: test_scissor (???:0)
==6421==    by 0x487E4D6: func_device (device.c:3167)
==6421==    by 0x487F22D: run_test (test.h:584)
==6421==    by 0x487F666: main (test.h:666)
==6421==  Address 0x7f0ff6f4 is 4,076 bytes inside a block of size 4,884 free'd
==6421==    at 0x7BC49E5B: notify_free (heap.c:262)
==6421==    by 0x7BC4E178: RtlFreeHeap (heap.c:1761)
==6421==    by 0x4973195: context_destroy (context.c:1810)
==6421==    by 0x4A2308E: swapchain_cleanup (swapchain.c:65)
==6421==    by 0x4A23332: wined3d_swapchain_decref (swapchain.c:108)
==6421==    by 0x4A285E2: wined3d_texture_decref (texture.c:418)
==6421==    by 0x4A2A289: texture_resource_decref (texture.c:940)
==6421==    by 0x4A3AEB3: wined3d_resource_decref (wined3d_private.h:2138)
==6421==    by 0x4A3B01B: wined3d_rendertarget_view_decref (view.c:47)
==6421==    by 0x498BD8C: wined3d_device_set_rendertarget_view (device.c:3991)
==6421==    by 0x4981484: wined3d_device_uninit_3d (device.c:1118)
==6421==    by 0x491A039: dxgi_device_Release (device.c:83)
==6421==    by 0x48DDD40: d3d10_device_Release (device.c:120)
==6421==    by 0x48732D7: ID3D10Device_Release (d3d10.h:5505)
==6421==    by 0x48732D7: test_scissor (???:0)
==6421==    by 0x487E4D6: func_device (device.c:3167)
==6421==    by 0x487F22D: run_test (test.h:584)
==6421==    by 0x487F666: main (test.h:666)
==6421==

==6421== Invalid read of size 4
==6421==    at 0x4970084: context_release (context.c:1165)
==6421==    by 0x49814CD: wined3d_device_uninit_3d (device.c:1126)
==6421==    by 0x491A039: dxgi_device_Release (device.c:83)
==6421==    by 0x48DDD40: d3d10_device_Release (device.c:120)
==6421==    by 0x48732D7: ID3D10Device_Release (d3d10.h:5505)
==6421==    by 0x48732D7: test_scissor (???:0)
==6421==    by 0x487E4D6: func_device (device.c:3167)
==6421==    by 0x487F22D: run_test (test.h:584)
==6421==    by 0x487F666: main (test.h:666)
==6421==  Address 0x7f0ff6e8 is 4,064 bytes inside a block of size 4,884 free'd
==6421==    at 0x7BC49E5B: notify_free (heap.c:262)
==6421==    by 0x7BC4E178: RtlFreeHeap (heap.c:1761)
==6421==    by 0x4973195: context_destroy (context.c:1810)
==6421==    by 0x4A2308E: swapchain_cleanup (swapchain.c:65)
==6421==    by 0x4A23332: wined3d_swapchain_decref (swapchain.c:108)
==6421==    by 0x4A285E2: wined3d_texture_decref (texture.c:418)
==6421==    by 0x4A2A289: texture_resource_decref (texture.c:940)
==6421==    by 0x4A3AEB3: wined3d_resource_decref (wined3d_private.h:2138)
==6421==    by 0x4A3B01B: wined3d_rendertarget_view_decref (view.c:47)
==6421==    by 0x498BD8C: wined3d_device_set_rendertarget_view (device.c:3991)
==6421==    by 0x4981484: wined3d_device_uninit_3d (device.c:1118)
==6421==    by 0x491A039: dxgi_device_Release (device.c:83)
==6421==    by 0x48DDD40: d3d10_device_Release (device.c:120)
==6421==    by 0x48732D7: ID3D10Device_Release (d3d10.h:5505)
==6421==    by 0x48732D7: test_scissor (???:0)
==6421==    by 0x487E4D6: func_device (device.c:3167)
==6421==    by 0x487F22D: run_test (test.h:584)
==6421==    by 0x487F666: main (test.h:666)
==6421==

==6421== Conditional jump or move depends on uninitialised value(s)
==6421==    at 0x66ED27D: ??? (in
/usr/lib/i386-linux-gnu/libnvidia-glcore.so.340.65)
==6421==    by 0x49A9116: shader_glsl_load_constants (glsl_shader.c:958)
==6421==    by 0x4979FB2: context_apply_draw_state (context.c:3128)
==6421==    by 0x49A3286: draw_primitive (drawprim.c:667)
==6421==    by 0x497A86A: wined3d_cs_exec_draw (cs.c:318)
==6421==    by 0x497C0FD: wined3d_cs_st_submit (cs.c:1071)
==6421==    by 0x497A8D7: wined3d_cs_emit_draw (cs.c:335)
==6421==    by 0x4989ED7: wined3d_device_draw_primitive (device.c:3425)
==6421==    by 0x48DE2B2: d3d10_device_Draw (device.c:221)
==6421==    by 0x487B1C2: ID3D10Device_Draw (d3d10.h:5527)
==6421==    by 0x487B1C2: test_texture (???:0)
==6421==    by 0x487E4E5: func_device (device.c:3170)
==6421==    by 0x487F22D: run_test (test.h:584)
==6421==    by 0x487F666: main (test.h:666)
==6421==  Uninitialised value was created by a stack allocation
==6421==    at 0x49A880A: shader_glsl_load_constants (glsl_shader.c:852)
==6421==

[Bug 38442] valgrind shows some uninitialized variables in d3d10core/tests/device.c test_scissor()

https://bugs.winehq.org/show_bug.cgi?id=38442

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
       Distribution|---                         |Debian

[Bug 38442] valgrind shows some uninitialized variables in d3d10core/tests/device.c test_scissor()

https://bugs.winehq.org/show_bug.cgi?id=38442

--- Comment #1 from Henri Verbeet  ---
Created attachment 51299
  --> https://bugs.winehq.org/attachment.cgi?id=51299
patch

Does the attached patch help?

[Bug 38442] valgrind shows some uninitialized variables in d3d10core/tests/device.c test_scissor()

https://bugs.winehq.org/show_bug.cgi?id=38442

--- Comment #2 from Henri Verbeet  ---
Please? :)

[Bug 38442] valgrind shows some uninitialized variables in d3d10core/tests/device.c test_scissor()

https://bugs.winehq.org/show_bug.cgi?id=38442

--- Comment #3 from Austin English  ---
(In reply to Henri Verbeet from comment #1)
> Created attachment 51299 [details]
> patch
>
> Does the attached patch help?

Yes, it works, thanks.

[Bug 38442] valgrind shows some uninitialized variables in d3d10core/tests/device.c test_scissor()

https://bugs.winehq.org/show_bug.cgi?id=38442

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |79f4ca9ec4dd6642c09f8f59744
                   |                            |9074a6d1c1415
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Austin English  ---
(In reply to Austin English from comment #3)
> (In reply to Henri Verbeet from comment #1)
> > Created attachment 51299 [details]
> > patch
> >
> > Does the attached patch help?
>
> Yes, it works, thanks.

https://source.winehq.org/git/wine.git/commitdiff/79f4ca9ec4dd6642c09f8f5974...

[Bug 38442] valgrind shows some uninitialized variables in d3d10core/tests/device.c test_scissor()

https://bugs.winehq.org/show_bug.cgi?id=38442

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.42.