http://bugs.winehq.org/show_bug.cgi?id=19184
Summary: File copying fails during installation of Mordor Product: Wine Version: 1.1.25 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: perchrh-wine@pvv.org
When installing the game, file copying fails. Files are extracted to the temp dir (C:\MDRTMP.TM~) and copied to the installation directory (C:\MORDOR).
A popup shows this error message: "Mordor 1.1 is not properly installed. Please re-run setup at a later time to install Mordor 1.1 properly."
Debug logs (file and file+relay channels) attached. The problem seems to occur when copying SHOCK.WAV, or right after that. The file is found in the installation directory after the error shows. The contents of the installation diretory and the temp directory at time of the error is attached.
To reproduce: Download demo, unzip MORDOR1A.zip and MORDOR1B.zip, run setup.exe and check (only) "Install MORDOR" and "Install WAVE files". Optionally, first install MORDOR only (completes without error), then re-run setup and install the WAVE files.
http://bugs.winehq.org/show_bug.cgi?id=19184
--- Comment #1 from Per Christian Henden perchrh-wine@pvv.org 2009-07-04 10:39:01 --- Created an attachment (id=22176) --> (http://bugs.winehq.org/attachment.cgi?id=22176) debug log +file
The debug log from starting the installer to the error message is shown.
http://bugs.winehq.org/show_bug.cgi?id=19184
Per Christian Henden perchrh-wine@pvv.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |http://decklinsdomain.net/D | |emDev/archives/contents.htm
http://bugs.winehq.org/show_bug.cgi?id=19184
--- Comment #2 from Per Christian Henden perchrh-wine@pvv.org 2009-07-04 10:40:10 --- Created an attachment (id=22177) --> (http://bugs.winehq.org/attachment.cgi?id=22177) debug log +file,+relay
http://bugs.winehq.org/show_bug.cgi?id=19184
--- Comment #3 from Per Christian Henden perchrh-wine@pvv.org 2009-07-04 10:40:54 --- Created an attachment (id=22178) --> (http://bugs.winehq.org/attachment.cgi?id=22178) List of file in the installation directory when the error occurs
http://bugs.winehq.org/show_bug.cgi?id=19184
--- Comment #4 from Per Christian Henden perchrh-wine@pvv.org 2009-07-04 10:41:22 --- Created an attachment (id=22179) --> (http://bugs.winehq.org/attachment.cgi?id=22179) List of file in the temporary directory when the error occurs
http://bugs.winehq.org/show_bug.cgi?id=19184
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, Installer
http://bugs.winehq.org/show_bug.cgi?id=19184
Niko Sandschneider nsandschn@gmx.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |nsandschn@gmx.de
--- Comment #5 from Niko Sandschneider nsandschn@gmx.de 2010-02-07 06:40:34 --- Confirming with wine 1.1.38. The only terminal output is:
fixme:hook:SetWindowsHookEx16 System-global hooks (5) broken in Win16 err:ddeml:WDML_CreateString Unknown code page 437
http://bugs.winehq.org/show_bug.cgi?id=19184
--- Comment #6 from Per Christian Henden perchrh-wine@pvv.org 2011-01-07 16:34:30 CST --- Also occurs with wine 1.3.10.
http://bugs.winehq.org/show_bug.cgi?id=19184
Loray oraydio@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |oraydio@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=19184
Jack Byer ftn768@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ftn768@gmail.com
--- Comment #7 from Jack Byer ftn768@gmail.com 2011-12-17 22:11:10 CST --- Same with 1.3.34
http://bugs.winehq.org/show_bug.cgi?id=19184
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |win16 CC| |wylda@volny.cz
--- Comment #8 from Wylda wylda@volny.cz 2012-05-07 18:57:08 CDT ---
Still present in wine-1.5.3-188-gb80c71a.
http://bugs.winehq.org/show_bug.cgi?id=19184
Frédéric Delanoy frederic.delanoy@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |frederic.delanoy@gmail.com Ever Confirmed|0 |1
--- Comment #9 from Frédéric Delanoy frederic.delanoy@gmail.com 2013-05-19 12:33:17 CDT --- Can't find the demo version to download. Can someone provide a download link and/or retest with recent wine (1.5.30 or later)?
http://bugs.winehq.org/show_bug.cgi?id=19184
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL|http://decklinsdomain.net/D |http://cd.textfiles.com/gig |emDev/archives/contents.htm |agames3/WIN/RPG/MORDOR11.ZI | |P CC| |00cpxxx@gmail.com
--- Comment #10 from Bruno Jesus 00cpxxx@gmail.com 2013-05-19 16:31:52 CDT --- New download link added. The installer does not run in wine 1.5.30.
http://bugs.winehq.org/show_bug.cgi?id=19184
--- Comment #11 from Per Christian Henden perchrh-wine@pvv.org 2013-05-20 06:19:51 CDT --- Created attachment 44503 --> http://bugs.winehq.org/attachment.cgi?id=44503 wine-1.5.30 warn+all debug logs
After unzipping mordor11.zip, using wine-1.5.30 default install on ubuntu, with a clean .wine folder, I ran WINDEBUG=warn+all wine ./setup.exe and collected the output.
The installer fails to start at all. This is a more severe bug than originally reported.
http://bugs.winehq.org/show_bug.cgi?id=19184
Per Christian Henden perchrh-wine@pvv.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #22176|0 |1 is obsolete| | Attachment #22177|0 |1 is obsolete| | Attachment #44503|0 |1 is obsolete| |
--- Comment #12 from Per Christian Henden perchrh-wine@pvv.org 2013-06-27 16:38:37 CDT --- Created attachment 45004 --> http://bugs.winehq.org/attachment.cgi?id=45004 wine-1.6rc3 warn+all debug logs
http://bugs.winehq.org/show_bug.cgi?id=19184
--- Comment #13 from Per Christian Henden perchrh-wine@pvv.org 2013-06-27 16:47:35 CDT --- Installer starts with wine-1.6rc3. It fails during file copying, and earlier than it did in previous wine-versions. There seems to be a new issue when the installer attempts to copy an .ini file to c:\windows.
warn:ntdll:FILE_CreateFile L"\??\C:\WINDOWS\WAVEMIX.INI" not found (c0000034) warn:module:load_builtin_dll cannot open .so lib for builtin L"WAVEMIX.INI": /usr/bin/../lib/i386-linux-gnu/wine/wavemix.ini.so: cannot open shared object file: No such file or directory warn:module:load_dll Failed to load module L"C:\WINDOWS\WAVEMIX.INI"; status=c0000135
https://bugs.winehq.org/show_bug.cgi?id=19184
Jarkko K jarkko_korpi@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jarkko_korpi@hotmail.com
--- Comment #14 from Jarkko K jarkko_korpi@hotmail.com --- Still an issue, the progress bar shows 9%.
fixme:hook:SetWindowsHookEx16 System-global hooks (5) broken in Win16 err:ddeml:WDML_CreateString Unknown code page 437 jarkko@jarkko-desktop:~/Downloads/mor$ wine setup fixme:hook:SetWindowsHookEx16 System-global hooks (5) broken in Win16 err:ddeml:WDML_CreateString Unknown code page 437
wine 1.7.18
https://bugs.winehq.org/show_bug.cgi?id=19184
super_man@post.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man@post.com
--- Comment #15 from super_man@post.com --- fixme:hook:SetWindowsHookEx16 System-global hooks (5) broken in Win16 err:ddeml:WDML_CreateString Unknown code page 437
the same 1.7.49
https://bugs.winehq.org/show_bug.cgi?id=19184
--- Comment #16 from super_man@post.com --- wine SETUP.EXE fixme:hook:SetWindowsHookEx16 System-global hooks (5) broken in Win16 err:ddeml:WDML_CreateString Unknown code page 437
wine 1.7.54
https://bugs.winehq.org/show_bug.cgi?id=19184
Sebastian Lackner sebastian@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |STAGED CC| |dmitry@baikal.ru, | |erich.e.hoover@wine-staging | |.com, michael@fds-team.de, | |sebastian@fds-team.de Staged patchset| |https://github.com/wine-com | |pholio/wine-staging/tree/ma | |ster/patches/krnl386.exe16- | |_lclose16
https://bugs.winehq.org/show_bug.cgi?id=19184
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |kernel32
https://bugs.winehq.org/show_bug.cgi?id=19184
André H. nerv@dawncrow.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Staged patchset|https://github.com/wine-com |https://github.com/wine-sta |pholio/wine-staging/tree/ma |ging/wine-staging/tree/mast |ster/patches/krnl386.exe16- |er/patches/krnl386.exe16-_l |_lclose16 |close16 CC| |nerv@dawncrow.de
https://bugs.winehq.org/show_bug.cgi?id=19184
Per Christian Henden perchrh-wine@pvv.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|STAGED |RESOLVED Resolution|--- |FIXED
--- Comment #17 from Per Christian Henden perchrh-wine@pvv.org --- The file copying now works! Tested using Wine 4.0-rc1-release.
https://bugs.winehq.org/show_bug.cgi?id=19184
--- Comment #18 from Nikolay Sivov bunglehead@gmail.com --- This patch wasn't merged yet, are you testing with wine-staging?
https://bugs.winehq.org/show_bug.cgi?id=19184
--- Comment #19 from Wylda wylda@volny.cz --- (In reply to Nikolay Sivov from comment #18)
This patch wasn't merged yet, are you testing with wine-staging?
Strange, but it works for me too in: * /opt/1.9.10.000-64-nonstag * /opt/4.00.rc1-64-nonstag
For sure i did clean prefix installation and tried also as "WINEARCH=win32". So seems to be fixed pretty long time and more curious are uncommited staging patches ;)
https://bugs.winehq.org/show_bug.cgi?id=19184
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |focht@gmx.net Fixed by SHA1| |414c73feabb6d33be969f3927f8 | |b3e8a8075bcd4
--- Comment #20 from Anastasius Focht focht@gmx.net --- Hello Wylda,
it was fixed by commit https://source.winehq.org/git/wine.git/commitdiff/414c73feabb6d33be969f3927f...
Wine-1.9.9
Regards
https://bugs.winehq.org/show_bug.cgi?id=19184
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |leslie_alistair@hotmail.com
--- Comment #21 from Wylda wylda@volny.cz --- Hi Anastasius, thanks for clarification. So is that staging's patch still useful or it should be dropped?
https://bugs.winehq.org/show_bug.cgi?id=19184
--- Comment #22 from Anastasius Focht focht@gmx.net --- Hello Wylda,
--- quote --- So is that staging's patch still useful or it should be dropped? --- quote ---
I don't see any specific Wine-Staging patches mentioned/linked in the comments.
To see the former value of the 'Staged patchset' field in Bugzilla I would need to reopen the ticket and mark it 'staged' again.
Using the Wine-Staging repository git history I can only find the patch that matches the commit that I identified using reverse bisecting method.
--- snip --- $ git remote -v origin https://github.com/wine-staging/wine-staging.git (fetch) origin https://github.com/wine-staging/wine-staging.git (push)
$ git log -p --all -G '19184]'
commit 9b9d2c756643a5118a1f369a3225e08dabd703c0 Author: Sebastian Lackner sebastian@fds-team.de Date: Sat Feb 27 05:11:25 2016 +0100
Added patch to avoid reassigning default handles after they got closed.
diff --git a/patches/krnl386.exe16-_lclose16/definition b/patches/krnl386.exe16-_lclose16/definition new file mode 100644 index 00000000..09964e69 --- /dev/null +++ b/patches/krnl386.exe16-_lclose16/definition @@ -0,0 +1 @@ +Fixes: [19184] Do not reassign default handles after they got closed diff --git a/patches/patchinstall.sh b/patches/patchinstall.sh index f00207c9..48a217db 100755 --- a/patches/patchinstall.sh +++ b/patches/patchinstall.sh @@ -177,6 +177,7 @@ patch_enable_all () enable_kernel32_VerifyVersionInfo="$1" enable_krnl386_exe16_GDT_LDT_Emulation="$1" enable_krnl386_exe16_Invalid_Console_Handles="$1" + enable_krnl386_exe16__lclose16="$1" enable_libs_Debug_Channel="$1" enable_libs_Unicode_Collation="$1" enable_makedep_PARENTSPEC="$1" @@ -679,6 +680,9 @@ patch_enable () krnl386.exe16-Invalid_Console_Handles) enable_krnl386_exe16_Invalid_Console_Handles="$2" ;; + krnl386.exe16-_lclose16) + enable_krnl386_exe16__lclose16="$2" + ;; libs-Debug_Channel) enable_libs_Debug_Channel="$2" ;; @@ -4219,6 +4223,21 @@ if test "$enable_krnl386_exe16_Invalid_Console_Handles" -eq 1; then ) >> "$patchlist" fi
+# Patchset krnl386.exe16-_lclose16 +# | +# | This patchset fixes the following Wine bugs: +# | * [#19184] Do not reassign default handles after they got closed +# | +# | Modified files: +# | * dlls/krnl386.exe16/file.c +# | ... --- snip ---
Regards
https://bugs.winehq.org/show_bug.cgi?id=19184
--- Comment #23 from Wylda wylda@volny.cz --- Hi Anastasius, thanks and sorry for me being dumb probably ;) but i still see a this patch in staging, which confused me:
https://github.com/wine-staging/wine-staging/tree/master/patches/krnl386.exe...
definition: Fixes: [19184] Do not reassign default handles after they got closed
0001-krnl386.exe16-Do-not-reassign-default-handles-after-.patch:
From 8acd785888b9324994f0477d6d2f2bdcd3b91219 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Michael=20M=C3=BCller?= michael@fds-team.de Date: Sat, 27 Feb 2016 03:20:34 +0100 Subject: krnl386.exe16: Do not reassign default handles after they got closed.
--- dlls/krnl386.exe16/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dlls/krnl386.exe16/file.c b/dlls/krnl386.exe16/file.c index b66b753..9b720ef 100644 --- a/dlls/krnl386.exe16/file.c +++ b/dlls/krnl386.exe16/file.c @@ -363,7 +363,7 @@ HFILE16 WINAPI _lclose16( HFILE16 hFile ) } TRACE("%d (handle32=%p)\n", hFile, dos_handles[hFile] ); CloseHandle( dos_handles[hFile] ); - dos_handles[hFile] = 0; + dos_handles[hFile] = (hFile < 5) ? INVALID_HANDLE_VALUE : 0; return 0; }
https://bugs.winehq.org/show_bug.cgi?id=19184
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12@gmail.com
--- Comment #24 from Zebediah Figura z.figura12@gmail.com --- (In reply to Wylda from comment #23)
Hi Anastasius, thanks and sorry for me being dumb probably ;) but i still see a this patch in staging, which confused me:
https://github.com/wine-staging/wine-staging/tree/master/patches/krnl386. exe16-_lclose16
Yep, it looks like it does the same thing, in a slightly different way. I guess it must have been overlooked back then; we'll remove it now.
https://bugs.winehq.org/show_bug.cgi?id=19184
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #25 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 4.0-rc2.