http://bugs.winehq.org/show_bug.cgi?id=12660
Summary: SIGSEGV if no PT_INTERP in target of wine-preloader Product: Wine Version: 0.9.59. Platform: Other OS/Version: other Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: jreiser@BitWagon.com
Created an attachment (id=12311) --> (http://bugs.winehq.org/attachment.cgi?id=12311) patch to wine-0.9.60/loader/preloader.c
wine-preloader gets a SIGSEGV if the target program has no PT_INTERP. Patch attached.
http://bugs.winehq.org/show_bug.cgi?id=12660
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
http://bugs.winehq.org/show_bug.cgi?id=12660
--- Comment #1 from Austin English austinenglish@gmail.com 2008-04-19 18:03:54 --- Please send your patch to wine-patches@winehq.org
http://bugs.winehq.org/show_bug.cgi?id=12660
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dank@kegel.com
--- Comment #2 from Dan Kegel dank@kegel.com 2008-04-20 04:19:54 --- I think John is trying to load Valgrind with the preloader (or something like that).
Usually we like to see a series of patches that yield a concrete benefit, but hey, this one looks simple and sane, no reason not to commit. (Although I might have put the default initializers in the else clause, to make it clear they weren't needed normally?)
http://bugs.winehq.org/show_bug.cgi?id=12660
--- Comment #3 from John Reiser jreiser@BitWagon.com 2008-04-20 10:00:42 --- Those default initializers could be put in an 'else' following the "if (interp)". The tradeoff is code size.
[The top-level valgrind itself has a PT_INTERP. It's the tools (memcheck, ...) which have no PT_INTERP. Another patch with more accommodations for valgrind tools will appear soon; this present patch is totally general for any ELF.]
http://bugs.winehq.org/show_bug.cgi?id=12660
--- Comment #4 from Austin English austinenglish@gmail.com 2008-10-23 15:39:57 --- Is this still an issue in current (1.1.6 or newer) wine?
http://bugs.winehq.org/show_bug.cgi?id=12660
--- Comment #5 from John Reiser jreiser@BitWagon.com 2008-10-23 16:22:43 --- Yes, wine 1.1.6 still has the problem.
http://bugs.winehq.org/show_bug.cgi?id=12660
--- Comment #6 from Austin English austinenglish@gmail.com 2008-10-23 16:32:40 --- You might resend the patch and ask for comments. Also, be sure to put it in git diff format.
http://bugs.winehq.org/show_bug.cgi?id=12660
--- Comment #7 from Austin English austinenglish@gmail.com 2009-05-03 21:10:58 --- Ping.
http://bugs.winehq.org/show_bug.cgi?id=12660
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |ABANDONED
--- Comment #8 from Dan Kegel dank@kegel.com 2009-05-03 21:22:25 --- I think we might want to mark this one abandoned; I was John's customer, and I'm happy with leaving this one unfixed for now. (John, feel free to reopen if you want to push on it.)
Valgrind's trunk now works fairly well with Wine on a number of apps, partly due to the subset of John's patches that have made it in to both wine and valgrind. We may well want to revisit some of John's unapplied patches at some point, but I haven't run into a reason just yet.
http://bugs.winehq.org/show_bug.cgi?id=12660
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #9 from Austin English austinenglish@gmail.com 2009-05-03 21:25:24 --- Closing.
-
wine-bugs＠winehq.org