[Bug 16346] New: App hangs creating modal dialog from WM_ACTIVATEAPP

http://bugs.winehq.org/show_bug.cgi?id=16346

Summary: App hangs creating modal dialog from WM_ACTIVATEAPP
           Product: Wine
           Version: 1.1.10
          Platform: Other
        OS/Version: other
            Status: UNCONFIRMED
          Severity: major
          Priority: P2
         Component: user32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]

Created an attachment (id=17660)
 --> (http://bugs.winehq.org/attachment.cgi?id=17660)
Simple windows app with source that brings up a message box every time the
window is activated.

I have an app which opens a modal dialog under some circumstances when the
window is activated.  Under Windows this works perfectly, but under wine it
causes the app to hang.  I have attached a trivial sample app showing this
behavior.

I poked around a bit, and the app is no longer receiving any messages (mouse
moves, keyboard, paint, etc), but I'm not sure where to go from here.

Also under Windows, since the app checks for the wParam (bActive) on
WM_ACTIVATEAPP, it only brings up one copy of the dialog box even after
multiple window activations.  Under wine it will bring up another copy of the
dialog if there is already a modal dialog on that app.

[Bug 16346] App hangs creating modal dialog from WM_ACTIVATEAPP

http://bugs.winehq.org/show_bug.cgi?id=16346

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, source

[Bug 16346] App hangs creating modal dialog from WM_ACTIVATEAPP

http://bugs.winehq.org/show_bug.cgi?id=16346

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |normal

[Bug 16346] App hangs creating modal dialog from WM_ACTIVATEAPP

http://bugs.winehq.org/show_bug.cgi?id=16346

Jeff Zaroyko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #1 from Jeff Zaroyko   2008-12-06 01:05:27 ---
confirming.

[Bug 16346] App hangs creating modal dialog from WM_ACTIVATEAPP

http://bugs.winehq.org/show_bug.cgi?id=16346

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]     |

--- Comment #2 from Dmitry Timoshkov   2008-12-07 03:43:27 ---
Please add a test case to the Wine test suite, once it's in I'll have
a look at the bug.

What Wine version are you running, and what window manager?

[Bug 16346] App hangs creating modal dialog from WM_ACTIVATEAPP

http://bugs.winehq.org/show_bug.cgi?id=16346

--- Comment #3 from Jeff Miller   2008-12-08 12:51:13 ---
I'm running Wine version 1.1.10 and my window manager is Metacity 2.16 (RHEL
5/Gnome).

I'll work on creating a wine test case, thanks.

[Bug 16346] App hangs creating modal dialog from WM_ACTIVATEAPP

http://bugs.winehq.org/show_bug.cgi?id=16346

--- Comment #4 from Jeff Miller   2008-12-15 13:40:30 ---
Created an attachment (id=17968)
 --> (http://bugs.winehq.org/attachment.cgi?id=17968)
patch to allow nested X11 events to be handled

This patch allows nested X11 events to be handled.  Without this, a modal
dialog called in response to an X11 event will prevent any other X11 events
from being handled, resulting in deadlock.

[Bug 16346] App hangs creating modal dialog from WM_ACTIVATEAPP

http://bugs.winehq.org/show_bug.cgi?id=16346

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from André H.   2009-08-16 11:17:43 ---
this doesnt happen in virtual desktop mode.
can you send your patch to wine-patches?

[Bug 16346] App hangs creating modal dialog from WM_ACTIVATEAPP

http://bugs.winehq.org/show_bug.cgi?id=16346

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Bruno Jesus  2012-02-05 23:08:06 CST ---
Friendly reminder of over 2 years without new posts.

[Bug 16346] App hangs creating modal dialog from WM_ACTIVATEAPP

http://bugs.winehq.org/show_bug.cgi?id=16346

--- Comment #7 from André H.  2012-02-10 12:44:43 CST ---
Yeah, A patch is great. still a testcase would be needed at least right now in
code freeze

[Bug 16346] App hangs creating modal dialog from WM_ACTIVATEAPP

http://bugs.winehq.org/show_bug.cgi?id=16346

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Dan Kegel  2012-06-22 18:17:36 CDT ---
The app still hangs under current wine (I had to play with it a bit,
it only hung when it put up the dialog the second time).

[Bug 16346] App hangs creating modal dialog from WM_ACTIVATEAPP

http://bugs.winehq.org/show_bug.cgi?id=16346

--- Comment #9 from Dan Kegel  2012-06-23 18:15:06 CDT ---
Created attachment 40668
  --> http://bugs.winehq.org/attachment.cgi?id=40668
Plain C test case

[Bug 16346] App hangs creating modal dialog from WM_ACTIVATEAPP

http://bugs.winehq.org/show_bug.cgi?id=16346

--- Comment #10 from Dan Kegel  2012-06-23 18:18:12 CDT ---
Created attachment 40669
  --> http://bugs.winehq.org/attachment.cgi?id=40669
Resource file for plain C test case

I've investigated this a bit with the attached plain C test app.
It seems that the handler for the X event carrying WM_TAKE_FOCUS 
calls SetForegroundWindow, and during that call, the entire
sequence of events from parent's WM_ACTIVATEAPP up until the
modal dialog is dismissed happens.  That's a long event handler.

[Bug 16346] App hangs creating modal dialog from WM_ACTIVATEAPP

https://bugs.winehq.org/show_bug.cgi?id=16346

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |testcase

--- Comment #11 from Ken Sharp  ---
Is this still an issue in Wine 1.7.45 or later?

[Bug 16346] App hangs creating modal dialog from WM_ACTIVATEAPP

https://bugs.winehq.org/show_bug.cgi?id=16346

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from [e-mail] ---
This is almost certainly still an issue. Bug 38933 documents a similar
situation on OS X.

[Bug 16346] App hangs creating modal dialog from WM_ACTIVATEAPP

https://bugs.winehq.org/show_bug.cgi?id=16346

--- Comment #13 from [e-mail] ---
It's been almost 7 years since a patch was proposed. Is it time to accept it
yet?

[Bug 16346] App hangs creating modal dialog from WM_ACTIVATEAPP

https://bugs.winehq.org/show_bug.cgi?id=16346

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]

[Bug 16346] App hangs creating modal dialog from WM_ACTIVATEAPP

https://bugs.winehq.org/show_bug.cgi?id=16346

--- Comment #14 from [e-mail] ---
Could someone review the patch?

It applies cleanly against wine 1.9.8-git.

patching file dlls/winex11.drv/event.c
Hunk #1 succeeded at 486 (offset 83 lines).

[Bug 16346] App hangs creating modal dialog from WM_ACTIVATEAPP

https://bugs.winehq.org/show_bug.cgi?id=16346

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #15 from [e-mail] ---
(In reply to alexchandel from comment #13)
> It's been almost 7 years since a patch was proposed. Is it time to accept it
> yet?

Patches arent picked from bug tracker, you need to send them for review
wine-patches list.

[Bug 16346] App hangs creating modal dialog from WM_ACTIVATEAPP

https://bugs.winehq.org/show_bug.cgi?id=16346

--- Comment #16 from [e-mail] ---
(In reply to alexchandel from comment #12)
> This is almost certainly still an issue. Bug 38933 documents a similar
> situation on OS X.

According to your own words on the other bug report the patch here fixes the
behaviour

"It fixes it on the X11 driver & on linux, but not on OSX/macOS with the native
Aqua driver."

[Bug 16346] App hangs creating modal dialog from WM_ACTIVATEAPP

https://bugs.winehq.org/show_bug.cgi?id=16346

--- Comment #17 from [e-mail] ---
(In reply to winetest from comment #16)
> (In reply to alexchandel from comment #12)
> > This is almost certainly still an issue. Bug 38933 documents a similar
> > situation on OS X.
>
> According to your own words on the other bug report the patch here fixes the
> behaviour
>
> "It fixes it on the X11 driver & on linux, but not on OSX/macOS with the
> native Aqua driver."

Yes, on X11 (but not Aqua, which is what Wine uses on OSX).

Could you send the patch to the wine-patches list for review?

[Bug 16346] App hangs creating modal dialog from WM_ACTIVATEAPP

https://bugs.winehq.org/show_bug.cgi?id=16346

joaopa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #18 from joaopa  ---
I do not understand the bug.
Does the bug still occur with current wine(4.0-rc1)?

[Bug 16346] App hangs creating modal dialog from WM_ACTIVATEAPP

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=16346

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 16346] App hangs creating modal dialog from WM_ACTIVATEAPP

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=16346

--- Comment #19 from [e-mail] ---
Yes, this bug still occurs in wine 4.19.  The patch fixes it on X11, but not
native macOS.