[Bug 16692] New: Morrowind Construction Set Crashes on Saving New Plugin

Summary: Morrowind Construction Set Crashes on Saving New Plugin Product: Wine Version: 1.1.11 Platform: PC-x86-64 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: directx-d3d AssignedTo: wine-bugs@winehq.org ReportedBy: aestrivex@gmail.com

Created an attachment (id=18347) --> (http://bugs.winehq.org/attachment.cgi?id=18347) ASCII text file of error output

TES III: Morrowind's Construction Set does not allow the creation of new plugin files (mods) and causes a crash to desktop upon saving a new plugin file. Changes to old plugin files suffer no such crashes.

-- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

Show replies by date

wine-bugs＠winehq.org

31 Dec 31 Dec

8:26 p.m.

New subject: [Bug 16692] Morrowind Construction Set Crashes on Saving New Plugin

Vitaliy Margolen vitaliy@kievinfo.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Component|directx-d3d |-unknown

--- Comment #1 from Vitaliy Margolen vitaliy@kievinfo.com 2008-12-31 14:26:06 --- Please install debug symbols or compile Wine from source.

wine-bugs＠winehq.org

30 Jun 30 Jun

4:43 p.m.

New subject: [Bug 16692] Morrowind Construction Set Crashes on Saving New Plugin

--- Comment #2 from Austin English austinenglish@gmail.com 2009-06-30 11:43:07 --- Is this still an issue in current (1.1.24 or newer) wine?

wine-bugs＠winehq.org

8:58 p.m.

New subject: [Bug 16692] Morrowind Construction Set Crashes on Saving New Plugin

--- Comment #3 from Roan L aestrivex@gmail.com 2009-06-30 15:58:53 --- confirming that this bug is still present.

wine-bugs＠winehq.org

4 Jun 4 Jun

5:52 p.m.

New subject: [Bug 16692] Morrowind Construction Set Crashes on Saving New Plugin

Austin English austinenglish@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |austinenglish@gmail.com

wine-bugs＠winehq.org

27 Jun 27 Jun

2:48 a.m.

New subject: [Bug 16692] Morrowind Construction Set Crashes on Saving New Plugin

Felipe Moraes felipemoraesbr@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |felipemoraesbr@gmail.com

--- Comment #4 from Felipe Moraes felipemoraesbr@gmail.com 2010-06-26 21:48:53 --- I have been affected by this on current wine 1.2-rc5

wine-bugs＠winehq.org

10 Jul 10 Jul

5:54 a.m.

New subject: [Bug 16692] Morrowind Construction Set Crashes on Saving New Plugin

--- Comment #5 from William J May may.11b@runbox.com 2010-07-10 00:54:50 --- Created an attachment (id=29485) --> (http://bugs.winehq.org/attachment.cgi?id=29485) output from 1.2-rc7

wine-bugs＠winehq.org

6:01 a.m.

New subject: [Bug 16692] Morrowind Construction Set Crashes on Saving New Plugin

William J May may.11b@runbox.com changed:

--- Comment #6 from William J May may.11b@runbox.com 2010-07-10 01:01:19 --- *** This bug has been confirmed by popular vote. ***

wine-bugs＠winehq.org

10 Oct 10 Oct

11:53 a.m.

New subject: [Bug 16692] Morrowind Construction Set Crashes on Saving New Plugin

--- Comment #7 from Kurt kurtjaeke@gmx.de 2010-10-10 06:52:53 CDT --- Created an attachment (id=31207) --> (http://bugs.winehq.org/attachment.cgi?id=31207) crash log of wine 1.3.4 on MacOSX 10.6

Crash log of wine 1.3.4 on MacOSX 10.6.

So, this still happens with 1.3.4.

wine-bugs＠winehq.org

11:53 a.m.

New subject: [Bug 16692] Morrowind Construction Set Crashes on Saving New Plugin

Kurt kurtjaeke@gmx.de changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |kurtjaeke@gmx.de

wine-bugs＠winehq.org

6 Aug 6 Aug

7:49 p.m.

New subject: [Bug 16692] Morrowind Construction Set Crashes on Saving New Plugin

MadDin MadDin081591@gmx.de changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |MadDin081591@gmx.de

--- Comment #8 from MadDin MadDin081591@gmx.de 2011-08-06 14:49:38 CDT --- The same problem here on Ubuntu 10.04 with Wine 1.3.25

wine-bugs＠winehq.org

18 Feb 18 Feb

8:03 a.m.

New subject: [Bug 16692] Morrowind Construction Set Crashes on Saving New Plugin

jisaak98@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |jisaak98@gmail.com

--- Comment #9 from jisaak98@gmail.com 2012-02-18 02:03:30 CST --- wine 1.4-rc4, the problem is still there. (openSUSE x86_64)

wine-bugs＠winehq.org

6 Apr 6 Apr

7:06 a.m.

New subject: [Bug 16692] Morrowind Construction Set Crashes on Saving New Plugin

[1] http://msdn.microsoft.com/en-us/library/windows/desktop/ms646839%28v=vs.85%2...

Jan-Peter Nilsson peppe@bsnet.se changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |peppe@bsnet.se

--- Comment #10 from Jan-Peter Nilsson peppe@bsnet.se 2012-04-06 02:06:03 CDT --- The OPENFILENAMEA structure given to GetSaveFileNameA() have a nMaxFile of 0 and NULL lpstrFile.

According to what I found on MSDN this does not appear to be valid values. "The GetOpenFileName and GetSaveFileName functions return FALSE if the buffer is too small to contain the file information. The buffer should be at least 256 characters long." [1]

So I guess either GetSaveFileName on windows doesn't actually work as described, or wine is triggering a different behavior at some earlier stage that leads to the call to GetSaveFileNameA() getting an empty buffer.

wine-bugs＠winehq.org

4:28 p.m.

New subject: [Bug 16692] Morrowind Construction Set Crashes on Saving New Plugin

--- Comment #11 from Juan Lang juan.lang@gmail.com 2012-04-06 11:28:36 CDT --- (In reply to comment #10)

The OPENFILENAMEA structure given to GetSaveFileNameA() have a nMaxFile of 0 and NULL lpstrFile.

According to what I found on MSDN this does not appear to be valid values. "The GetOpenFileName and GetSaveFileName functions return FALSE if the buffer is too small to contain the file information. The buffer should be at least 256 characters long." [1]

Interesting. Should be relatively simple to write a test case for GetSaveFileNameA. Care to give it a go?

wine-bugs＠winehq.org

12 Apr 12 Apr

4:37 a.m.

New subject: [Bug 16692] Morrowind Construction Set Crashes on Saving New Plugin

Austin English austinenglish@gmail.com changed:

--- Comment #12 from Austin English austinenglish@gmail.com 2012-04-11 23:37:19 CDT --- Created attachment 39759 --> http://bugs.winehq.org/attachment.cgi?id=39759 hacked up tests

I took a quick look at hacking together some tests. These pass on windows/wine, which is getting false from Get{Open,Save}FileNameA.

Of course, these tests may by flawed, I don't know comdlg32, just hacked/slashed this up :).

wine-bugs＠winehq.org

6:04 a.m.

New subject: [Bug 16692] Morrowind Construction Set Crashes on Saving New Plugin

--- Comment #13 from Jan-Peter Nilsson peppe@bsnet.se 2012-04-12 01:04:55 CDT --- I played a bit with GetSaveFileNameA on Windows XP, it seems that giving a nMaxFile/lpstrFile combination that is not large enough to contain the selected path will as expected return false. This is using the same value for Flags as TESCS did.

However giving it a zero/null nMaxFile/lpstrFile I get it to return true. In this case lpstrFile is still null after, so I have no idea how you would actually get the selected filename. I can't get to that code at the moment though, can't power that computer up, possibly broken PSU.

wine-bugs＠winehq.org

7:11 p.m.

New subject: [Bug 16692] Morrowind Construction Set Crashes on Saving New Plugin

--- Comment #14 from Jan-Peter Nilsson peppe@bsnet.se 2012-04-12 14:11:04 CDT --- Created attachment 39779 --> http://bugs.winehq.org/attachment.cgi?id=39779 comdlg32: Avoid null dereference in FILEDLG95_OnOpen

This patch makes us avoid the crash, but does not make it work.

wine-bugs＠winehq.org

7:13 p.m.

New subject: [Bug 16692] Morrowind Construction Set Crashes on Saving New Plugin

--- Comment #15 from Jan-Peter Nilsson peppe@bsnet.se 2012-04-12 14:13:54 CDT --- Created attachment 39780 --> http://bugs.winehq.org/attachment.cgi?id=39780 Test triggering the problem

This test triggers the crash for me in wine, on Windows XP it passes.

wine-bugs＠winehq.org

13 Apr 13 Apr

1:56 a.m.

New subject: [Bug 16692] Morrowind Construction Set Crashes on Saving New Plugin

--- Comment #16 from Vitaliy Margolen vitaliy-bugzilla@kievinfo.com 2012-04-12 20:56:21 CDT --- (In reply to comment #14) Please merge your 2 commits together and send it to wine-patches mailing list. Patches are not picked up from bugzilla.

wine-bugs＠winehq.org

6:21 a.m.

New subject: [Bug 16692] Morrowind Construction Set Crashes on Saving New Plugin

--- Comment #17 from Jan-Peter Nilsson peppe@bsnet.se 2012-04-13 01:21:18 CDT --- (In reply to comment #16)

(In reply to comment #14) Please merge your 2 commits together and send it to wine-patches mailing list. Patches are not picked up from bugzilla.

I'm aware of that, they are not meant for inclusion in their current form. The point was to share what I have found so far, perhaps I should have been more clear about that.

Patch 1 (null pointer dereference): Prevents the crash but does not actually make it work, based on the looks of if a real solution should probably not even get into this code path. So depending on the real solution required to make the application work this may prove to be pointless.

Patch 2 (test): The test is interactive, I believe it should be made non-interactive. It is also incomplete, as previously mentioned, I don't yet know how to get the selected filename out of it, so currently it is only testing the return value. Whatever method TECS is using the get the selected filename is not working, modifying the function to return the expected value is not enough to make it work.

wine-bugs＠winehq.org

2 Sep 2 Sep

12:59 a.m.

New subject: [Bug 16692] Morrowind Construction Set Crashes on Saving New Plugin

Bruno Jesus 00cpxxx@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |00cpxxx@gmail.com

--- Comment #18 from Bruno Jesus 00cpxxx@gmail.com 2012-09-01 19:59:23 CDT --- Please, try again in wine 1.5.12. This is possibly a duplicate of bug 17229 that was fixed by http://source.winehq.org/git/wine.git/commitdiff/8c5cf7e25f8c547306f37ae151d...

wine-bugs＠winehq.org

9:55 a.m.

New subject: [Bug 16692] Morrowind Construction Set Crashes on Saving New Plugin

--- Comment #19 from Jan-Peter Nilsson peppe@bsnet.se 2012-09-02 04:55:38 CDT --- The correction for bug 17229 prevents the crash but does not make it work. TESCS does not get the selected filename so the behaviour is basically the same as selecting cancel.

wine-bugs＠winehq.org

12:10 p.m.

New subject: [Bug 16692] Morrowind Construction Set Crashes on Saving New Plugin

--- Comment #20 from Bruno Jesus 00cpxxx@gmail.com 2012-09-02 07:10:25 CDT --- I guess I don't understand this bug then =)

Can you try to clarify it more? I have Morrowind somewhere here, does every cd-rom comes with the construction set or do I have to download it?

wine-bugs＠winehq.org

3 Sep 3 Sep

4:49 p.m.

New subject: [Bug 16692] Morrowind Construction Set Crashes on Saving New Plugin

--- Comment #21 from Jan-Peter Nilsson peppe@bsnet.se 2012-09-03 11:49:11 CDT --- The construction set is (at least in the edition I have) available from a separate CD that I got with Morrowind.

It no longer crashes so it is improved, but after selecting a filename to save to it appears that the construction set does not recognize that a filename was selected. A file with the selected name is not created.

If you find the construction set you should be able to reproduce it by: 1. Start the construction set 2. Click the save button 3. Enter a filename, select save 4. Notice that the file was not created

wine-bugs＠winehq.org

9 Aug 9 Aug

5:23 p.m.

New subject: [Bug 16692] Morrowind Construction Set Crashes on Saving New Plugin

--- Comment #22 from Bruno Jesus 00cpxxx@gmail.com --- I can see the problem in wine 1.7.24.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

10 Aug 10 Aug

3:33 p.m.

New subject: [Bug 16692] Morrowind Construction Set does nothing while saving new plugin

Bruno Jesus 00cpxxx@gmail.com changed:

--- Comment #23 from Bruno Jesus 00cpxxx@gmail.com --- I can't really understand what the application is doing... The application does not pass lpstrFile and still is able to get the path on windows, I have no idea why.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

9 Sep 9 Sep

8:38 a.m.

New subject: [Bug 16692] Morrowind Construction Set does nothing while saving new plugin

--- Comment #24 from Austin English austinenglish@gmail.com --- This is your friendly reminder that there has been no bug activity for over a year. Is this still an issue in current (1.7.51 or newer) wine?

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

13 Sep 13 Sep

11:12 a.m.

New subject: [Bug 16692] Morrowind Construction Set does nothing while saving new plugin

--- Comment #25 from Jan-Peter Nilsson peppe@bsnet.se --- The problem is still exists with the current master (a7e294c).

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

6 Dec 6 Dec

10:23 p.m.

New subject: [Bug 16692] Morrowind Construction Set does nothing while saving new plugin

trymeout@tutanota.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |trymeout@tutanota.com

--- Comment #26 from trymeout@tutanota.com --- Created attachment 65887 --> https://bugs.winehq.org/attachment.cgi?id=65887 wine 4.18

Does not work in wine 4.18. Here is a log

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

11:15 p.m.

New subject: [Bug 16692] Morrowind Construction Set does nothing while saving new plugin

Paul Gofman gofmanp@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |gofmanp@gmail.com

--- Comment #27 from Paul Gofman gofmanp@gmail.com --- (In reply to Bruno Jesus from comment #23)

I can't really understand what the application is doing... The application does not pass lpstrFile and still is able to get the path on windows, I have no idea why.

Did you see what it passes in lpstrFileTitle? I have no game to test, but I made a brief unit test, with lpstrFile and nMaxFile set to 0, but lpstrFileTitle and nMaxFileTitle set to valid buffer, Windows (XP & 7) returns the selected file name to the provided lpstrFileTitle in this case, while Wine does not.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

7 Dec 7 Dec

2:54 a.m.

New subject: [Bug 16692] Morrowind Construction Set does nothing while saving new plugin

--- Comment #28 from trymeout@tutanota.com --- I believe this issue is also present for the Oblivion Construction set, and the Skyrim Creation Kit.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

13 Apr 13 Apr

8:01 a.m.

New subject: [Bug 16692] Morrowind Construction Set does nothing while saving new plugin

--- Comment #29 from Jan-Peter Nilsson peppe@bsnet.se --- (In reply to Paul Gofman from comment #27)

Did you see what it passes in lpstrFileTitle? I have no game to test, but I made a brief unit test, with lpstrFile and nMaxFile set to 0, but lpstrFileTitle and nMaxFileTitle set to valid buffer, Windows (XP & 7) returns the selected file name to the provided lpstrFileTitle in this case, while Wine does not.

It does pass nMaxFileTitle/lpstrFileTitle.

Patching wine so that we insert the filenamename in lpstrFileTitle even without lpstrFile I can see that the construction set does get the filename and it seems to work properly as long as you don't change directory.

If you change directory it will save to the 'Data Files'* directory anyway. It does set the OFN_NOCHANGEDIR flag, so GetSaveFileNameA does not change the working directory.

It is possible this works the same on Windows, I will try.

* 'Data Files' is the default directory, it is passed in to lpstrInitialDir, working directory is 'C:\Program Files\Bethesda Softworks\Morrowind' so that becomes 'C:\Program Files\Bethesda Softworks\Morrowind\Data Files'

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

9:09 a.m.

New subject: [Bug 16692] Morrowind Construction Set does nothing while saving new plugin

--- Comment #30 from Jan-Peter Nilsson peppe@bsnet.se --- (In reply to Jan-Peter Nilsson from comment #29)

If you change directory it will save to the 'Data Files'* directory anyway. It does set the OFN_NOCHANGEDIR flag, so GetSaveFileNameA does not change the working directory.

It is possible this works the same on Windows, I will try.

I'm seeing the same behavior on Windows 8, the construction set only uses the filename from the save dialog and saves to the 'Data Files' directory even if you change directory in the save dialog.

So it does not appear to be anything else going on, GetSaveFileNameA not populating lpstrFileTitle is the problem.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

20 Apr 20 Apr

2:21 a.m.

New subject: [Bug 16692] Morrowind Construction Set does nothing while saving new plugin