[Bug 58026] New: vbscript: Script running error when Dictionary contains array

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=58026

Bug ID: 58026
           Summary: vbscript: Script running error when Dictionary
                    contains array
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: vbscript
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Dim dicInfo : Set dicInfo = CreateObject("Scripting.Dictionary")
dicInfo.Add "Key" , Array( "Value1", Array("SubValue1","SubValue2"))

Dim KeyName
KeyName = "Key"
If dicInfo.Item(KeyName)(0).Text <> "" Then 
    msgbox "value is not empty"    
End If

When running above script, it shows error
(vbscript:stack_pop_disp is no disp {VT_EMPTY})

[Bug 58026] vbscript: Script running error when Dictionary contains array

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=58026

--- Comment #1 from Nikolay Sivov  ---
This does not work on Windows either. The ".Text" property does not exist. Did
you mean to use:

If dicInfo.Item(KeyName)(0) <> "" Then 
    msgbox "value is not empty"    
End If

This does show different results. On Windows I get a popup, on Wine I don't.

[Bug 58026] vbscript: Script running error when Dictionary contains array

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=58026

--- Comment #2 from Jiali Fang  ---
Hi,

Thanks for reply.

Yes, I mean to use:

If dicInfo.Item(KeyName)(0) <> "" Then 
    msgbox "value is not empty"    
End If

And why Wine don't show the popup?

[Bug 58026] vbscript: Script running error when Dictionary contains array

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=58026

--- Comment #3 from Nikolay Sivov  ---
It's an interpreter bug that needs fixing.

[Bug 58026] vbscript: Script running error when Dictionary contains array

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=58026

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |10.4

[Bug 58026] vbscript: Script running error when Dictionary contains array

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=58026

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #4 from Nikolay Sivov  ---
The call chain that's problematic is:

interp_vcall -> variant_call(v) with byref result returned to 'v' ->
VariantClear(v).

The issue here is that there is no storage to keep a referenced variant in.
Maybe stack should be made smarter to hold two variants per push conditionally,
but this is not going to work with ret_val right away I guess.

This is causing array access (0) to return VT_EMPTY, because it's cleared. Then
comparison VT_EMPTY <> VT_BSTR "" happen.

[Bug 58026] vbscript: Script running error when Dictionary contains array

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=58026

--- Comment #5 from Jiali Fang  ---
Hi,

Thank you very much for your explanation.

Is there a plan to revise this problem?

[Bug 58026] vbscript: Script running error when Dictionary contains array

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=58026

--- Comment #6 from Nikolay Sivov  ---
Sure, this is definitely something to fix, but I don't know who's going to work
on it, or when.