[Bug 10120] New: Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

Summary: Oblivion lines in water (regression)
           Product: Wine
           Version: 0.9.47.
          Platform: PC-x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: wine-directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]

With Wine 0.9.47, in Elder Scrolls IV: Oblivion v1.2, there are horizonal white
lines in the water. It's a regression between 0.9.44 and 0.9.45. I've done
regression testing and found the following commit to be the cause:

[322b55e29a83a3ab61a1912d751816aa24662e9f] wined3d: Fix the half pixel
correction.

(I used oss sound not alsa becouse of some crash in between.)

[Bug 10120] Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

--- Comment #1 from Ambro   2007-10-20 11:26:37 ---
Created an attachment (id=8684)
 --> (http://bugs.winehq.org/attachment.cgi?id=8684)
Screenshot of the water

[Bug 10120] Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |trivial

--- Comment #2 from Vitaliy Margolen   2007-10-20 11:31:06 ---
What is your video card and drivers?

[Bug 10120] Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

--- Comment #3 from Ambro   2007-10-20 11:39:51 ---
(In reply to comment #2)
> What is your video card and drivers?

It's GeForce 8800 GTX, driver 100.14.23 (also happens on 100.14.19)

[Bug 10120] Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

--- Comment #4 from Stefan Dösinger   2007-10-20 16:20:26 ---
I guess this happens because we'd have to move by -0.5 pixels in the y
direction instead of 0.5 when rendering offscreen, because everything is upside
down. We don't do that currently, and I've failed to get that to work, for some
reason. Should be simple, but doesn't do what I want :-(

[Bug 10120] Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

--- Comment #5 from Stefan Dösinger   2007-10-20 16:21:33 ---
Vitaliy: I'm not sure if trivial is the right severity for this, the problem is
quite deeply rooted. I gave up on understanding the severity applied to our
bugs though. Everyone seems to have his own metric.

[Bug 10120] Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

--- Comment #6 from Vitaliy Margolen   2007-10-21 12:05:30 ---
Trivial is a "UI glitch that doesn't affect running of a program". I wouldn't
compare it to inverted colors or up side down geometry for example. Which are
minimal, because games still work.

[Bug 10120] Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

Ben Hodgetts (Enverex)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #7 from Ben Hodgetts (Enverex)   2008-03-01 07:07:00 ---
Still present in GIT (0.9.56+) but doesn't happen if you switch to FBO.

[Bug 10120] Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

--- Comment #8 from Ben Hodgetts (Enverex)   2008-06-10 07:31:52 ---
Created an attachment (id=13877)
 --> (http://bugs.winehq.org/attachment.cgi?id=13877)
The lined water in Morrowind

Still present in Wine 1.0-RC4. Attaching screenshot of how it affects
Morrowind. Upping severity to minor because it affects at least 2 games (but
nothing more because FBO fixes it).

[Bug 10120] Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

Tobias Jakobi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 10120] Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Keywords|                            |regression

--- Comment #9 from Austin English   2008-07-14 05:58:05 ---
Still present?

[Bug 10120] Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

--- Comment #10 from Tobias Jakobi   2008-07-15 15:53:16 ---
I don't own Oblivion but I can reconfirm the problem with wine-1.1.0 and
Morrowind (patched to version 1.2.0722 - the GOTY edition).

[Bug 10120] Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

--- Comment #11 from Tobias Jakobi   2008-07-25 14:19:28 ---
Reconfirming with wine-1.1.2

[Bug 10120] Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

--- Comment #12 from Tobias Jakobi   2008-07-25 14:22:11 ---
Created an attachment (id=15036)
 --> (http://bugs.winehq.org/attachment.cgi?id=15036)
View from Seyda Neen lighthouse (lots of lines)

taken with wine-1.1.2

[Bug 10120] Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

Oisin O Malley  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #13 from Oisin O Malley   2008-07-30 05:51:17 ---
This appears to be fixed with Morrowind in current cvs.

Note I'm using;
OffscreenRenderingMode="pbuffers"

[Bug 10120] Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

--- Comment #14 from Tobias Jakobi   2008-07-30 11:22:30 ---
Hey great, I have to check this (as soon as I get home).

Can you also check if it's happening with backbuffer and fbo? I did never
really use pbuffers, so I dunno if it appeared there anywhere in the past.

Greets,
Tobias

[Bug 10120] Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

--- Comment #15 from Tobias Jakobi   2008-07-30 12:58:16 ---
Deconfirming.
Tried it with all available ORM modes. None of them has the issue fixed.
With fbo it doesn't even render correctly, plus the performance is a disaster
(seems like Morrowind is also affected by the NP2 changes, that also affect MP2
rendering performance with NVFX cards).

[Bug 10120] Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

--- Comment #16 from Tobias Jakobi   2008-07-30 13:03:44 ---
However I found out this:
With wine-1.1.0 and ORM=fbo the lines don't appear and the performance isn't
all that bad.

wine-1.1.0, ORM=pbuffer: lines
wine-1.1.0, ORM=backbuffer: lines

To it seems like fbo fixes this problem, but it's currently broken because of
the patches discussed here: http://bugs.winehq.org/show_bug.cgi?id=14038

[Bug 10120] Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

Spencer Taufer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #17 from Spencer Taufer   2008-09-21 12:10:35 ---
As of wine 1.1.5 the need for registry edits seems no longer necessary.
However, the lines in the water still exists.

ORM=fbo: lines
ORM=pbuffer: lines

[Bug 10120] Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

--- Comment #18 from Tobias Jakobi   2008-09-21 12:18:33 ---
(In reply to comment #17)
> As of wine 1.1.5 the need for registry edits seems no longer necessary.
> However, the lines in the water still exists.

What do you mean by that? Do you mean overriding the default
OffscreenRenderingMode by "registry edits"?
> ORM=fbo: lines
> ORM=pbuffer: lines

So FBOs break again, right? Like I mentioned in comment #16 the issues were
gone with wine-1.1.0 and ORM=fbo, so this looks like a regression to me.
However I currently can't test this.

What about ORM=auto/backbuffer, does this work at all?

[Bug 10120] Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

--- Comment #19 from Spencer Taufer   2008-09-22 14:41:06 ---
Video Card:
nVidia 8800 GTS 640MB using 173.14.12 Driver (updated regularly using Envyng)

Regression testing of Water with Lines in Oblivion

Test 1: Failed
ORM = fbo

Test 2: Failed
ORM = pbuffer

Test 3: Failed
ORM = auto

Test 4: Failed
ORM = backbuffer
*Noticed a significant decrease in FPS when using backbuffer, lines acted
differently and were slightly less noticeable but still existent.

[Bug 10120] Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

--- Comment #20 from Tobias Jakobi   2008-10-07 18:12:07 ---
@Spencer: auto currently maps to backbuffer, so switching from auto to
backbuffer should not add anything new

My current list of issues (with wine git master):
ORM=backbuffer: lines are there
ORM=fbo: not working at all, the water plane is sometimes not rendered at all,
if the viewing angle is positioned right then I can manage to get the plane
rendered, but with a lot of flickering

However when bringing up the ingame main menu (the one where you can exit the
game) the scene is rendered correctly. And this the main menu open I can also
see that the waterplane is rendered correctly, without lines and no
corruptions.

While in ORM=fbo mode the console outputs a lot of these:
fixme:d3d_shader:shader_arb_deselect_depth_blt >>>>>>>>>>>>>>>>>
GL_INVALID_OPERATION (0x502) from glBindProgramARB(GL_VERTEX_PROGRAM_ARB,
vertexShader->prgId); @ arb_program_shader.c / 1904

So to summarize this:
backbuffer: no change at all, it's still broken
fbo: became more broken with recent wine versions, however it seems to fix the
lines issue for me (although it's still not rendered correctly)

All this was done with GLSL off.

[Bug 10120] Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

--- Comment #21 from Tobias Jakobi   2008-10-07 18:16:34 ---
Oh yes, I forgot something.

It's not only the waterplane not rendered for me. Also the leaves of the trees
are affected. The rendering of waterplane and leaves is tied together. When no
waterplane is visible then no leaves are visible, the same goes for a visible
waterplane.

Needless to say that the leaves also appear when opening the main menu.

I also made a test with GLSL enabled, but it produces the same issues.
Only the error messages on the console are differently:
fixme:d3d_shader:shader_glsl_deselect_depth_blt >>>>>>>>>>>>>>>>>
GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3481

[Bug 10120] Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

Josef Schimke  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #22 from Josef Schimke   2008-10-28 12:51:53 ---
Water seems to render fine for me with ORM=fbo in Wine 1.1.7.  With backbuffer,
the lines are still present, and the surface of the water lacks the
glimmering/moving affect.  The game doesn't want to start at all with pbuffer
anymore - I'll figure out why some time.

[Bug 10120] Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

Vit Hrachovy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #23 from Vit Hrachovy   2008-11-17 03:11:35 ---
Water seems to render fine in 1.1.8 with backbuffer.
Lines are still present in fbo.

[Bug 10120] Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

--- Comment #24 from Tobias Jakobi   2008-11-17 17:28:29 ---
My results with newest git master.

ORM=pbuffer and ORM=backbuffer: Line issue is there with pixelshader water
ORM=fbo: No lines / no issue

@Vit: Are you sure you didn't mix something up?

[Bug 10120] Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

Xavier Vachon  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #25 from Xavier Vachon   2008-11-23 18:38:53 ---
I am using a clean wineprefix with no registry tweaks for Morrowind with Wine
1.1.9, and the water around Seyda Neen and Balmora renders fine. I use the
unofficial patch 1.6.3b available here :
http://www.etherealsoftware.com.au/patch/#Version

[Bug 10120] Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

--- Comment #26 from Vit Hrachovy   2008-12-06 05:03:39 ---
In 1.1.10 fbo and backbuffer works greatly, pbuffer shows this error.

[Bug 10120] Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

DL  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #27 from DL   2008-12-28 03:56:34 ---
I still get lined water with wine-1.1.11 and FBO enabled.Occurs with Oblivion
and Morrowind.

[Bug 10120] Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

Dominges  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 10120] Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

--- Comment #28 from Tobias Jakobi   2009-01-29 15:50:00 ---
Retested with wine-1.1.13:

ORM=fbo: no lines
ORM=backbuffer, pbuffer: lines

[Bug 10120] Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

Mehdi Yousfi-Monod  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #29 from Mehdi Yousfi-Monod   2009-03-31 17:14:15 ---
I had the same issue using ORM=fbo, and I get rid of it by unchecking "allow
pixel shader" in winecfg (but maybe it's a pixelshader issue only, not sure I'm
helpful :P).
Config: Wine 1.1.18, Ubuntu Intrepid 64, Morrowind GOTY (French), laptop Sager
NP2096 / GPU NVidia 9600M GT, drivers x86_64-180.44 / CPU Intel P9600

[Bug 10120] Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

--- Comment #30 from Tobias Jakobi   2009-04-26 09:12:33 ---
Reconfirming with wine-1.1.20

[Bug 10120] Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

Robert Munteanu  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 10120] Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

sheen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #31 from sheen   2009-06-14 17:59:42 ---
Still present in Wine 1.1.23 with OffscreenRenderingMode=fbo

[Bug 10120] Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

--- Comment #32 from Tobias Jakobi   2009-06-14 18:35:03 ---
Are you sure about that? On what card did you test this?

[Bug 10120] Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

--- Comment #33 from DL   2009-06-14 21:44:37 ---
(In reply to comment #32)
> Are you sure about that? On what card did you test this?

Still occurs for me with an 8800GT.

[Bug 10120] Oblivion lines in water (regression)

http://bugs.winehq.org/show_bug.cgi?id=10120

--- Comment #34 from sheen   2009-06-15 00:32:21 ---
(In reply to comment #32)
> Are you sure about that? On what card did you test this?

Yes I'm sure, my GPU is an nVidia 8800 GTS 512 Mb

[Bug 10120] Oblivion lines in water

http://bugs.winehq.org/show_bug.cgi?id=10120

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Oblivion lines in water     |Oblivion lines in water
                   |(regression)                |

[Bug 10120] Oblivion lines in water

http://bugs.winehq.org/show_bug.cgi?id=10120

Chris W  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #35 from Chris W   2009-07-03 12:51:01 ---
Issue persists on wine-1.1.24 -- tested on Fable which is also affected by this
bug.

[Bug 10120] Oblivion lines in water

http://bugs.winehq.org/show_bug.cgi?id=10120

Léon van der Kaap  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #36 from Léon van der Kaap   2009-07-05 09:53:41 ---
Running Morrowind+Tirbunal+Bloodmoon+patches with 1.1.25 and I do not have any
lines in the water. Confirm/Deny?

[Bug 10120] Oblivion lines in water

http://bugs.winehq.org/show_bug.cgi?id=10120

--- Comment #37 from Xavier Vachon   2009-07-05 10:03:18 ---
(In reply to comment #36)
> Running Morrowind+Tirbunal+Bloodmoon+patches with 1.1.25 and I do not have any
> lines in the water. Confirm/Deny?

I still have lines in water with latest git (1.1.25)

[Bug 10120] Oblivion lines in water

http://bugs.winehq.org/show_bug.cgi?id=10120

--- Comment #38 from Chris W   2009-07-06 01:46:50 ---
Created an attachment (id=22213)
 --> (http://bugs.winehq.org/attachment.cgi?id=22213)
Water lines present in Fable: The Lost Chapters

The same bug also affects fable.

[Bug 10120] Oblivion lines in water

http://bugs.winehq.org/show_bug.cgi?id=10120

--- Comment #39 from Chris W   2009-07-06 01:49:53 ---
I can confirm this is still an issue in 1.1.25.

[Bug 10120] Oblivion lines in water

http://bugs.winehq.org/show_bug.cgi?id=10120

--- Comment #40 from Chris W   2009-09-04 10:28:49 ---
Believe it or not, I can no longer reproduce this issue as of wine-1.1.28; it
appears to be fixed. :) Can anyone confirm this?

[Bug 10120] Oblivion lines in water

http://bugs.winehq.org/show_bug.cgi?id=10120

--- Comment #41 from Henri Verbeet   2009-09-04 10:34:41 ---
Probably ffb38da024b044b4958d21784b5cc290291883a9.

[Bug 10120] Oblivion lines in water

http://bugs.winehq.org/show_bug.cgi?id=10120

--- Comment #42 from Raymond Hawkins   2009-09-04 11:36:20 ---
Created an attachment (id=23426)
 --> (http://bugs.winehq.org/attachment.cgi?id=23426)
screenshot from wine 1.1.29

Confirming that the water lines no longer exist in wine 1.1.29. (Screenshot
attached)

[Bug 10120] Oblivion lines in water

http://bugs.winehq.org/show_bug.cgi?id=10120

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |[e-mail]
         Resolution|                            |FIXED

--- Comment #43 from Louis Lenders   2009-09-04 12:02:27 ---
reported twice fixed then

[Bug 10120] Oblivion lines in water

http://bugs.winehq.org/show_bug.cgi?id=10120

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #44 from Jerome Leclanche   2009-09-06 01:04:16 ---
(In reply to comment #43)
> reported twice fixed then

Close dupe of #9931 rather.

[Bug 10120] Oblivion lines in water

http://bugs.winehq.org/show_bug.cgi?id=10120

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #45 from Alexandre Julliard   2009-09-25 12:22:59 ---
Closing bugs fixed in 1.1.30.