https://bugs.winehq.org/show_bug.cgi?id=45650
Bug ID: 45650 Summary: x32 chromium sandbox expects different syscall thunks Product: Wine Version: 3.13 Hardware: x86 OS: Linux Status: NEW Keywords: patch Severity: normal Priority: P2 Component: ntdll Assignee: wine-bugs@winehq.org Reporter: dark.shadow4@web.de Distribution: ---
Created attachment 62079 --> https://bugs.winehq.org/attachment.cgi?id=62079 0010-winebuild-Simplifly-32bit-syscall-thunk-to-fix-issue
Follow up to bug 45649, and basically an addition to bug 21232.
The existing api thunks work already kind of, but not for all windows versions.
Attached a patch to makes 32bit chrome and chromium work with any windows version >=XP, both in 32bit and 64bit WINEPREFIX.
https://bugs.winehq.org/show_bug.cgi?id=45650
Fabian Maurer dark.shadow4@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|x32 chromium sandbox |chromium x32 sandbox |expects different syscall |expects different syscall |thunks |thunks
https://bugs.winehq.org/show_bug.cgi?id=45650
Fabian Maurer dark.shadow4@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.winehq.org/sho | |w_bug.cgi?id=21232
https://bugs.winehq.org/show_bug.cgi?id=45650
Fabian Maurer dark.shadow4@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12@gmail.com
--- Comment #1 from Fabian Maurer dark.shadow4@web.de --- Since this is an update to a staging patchset, I guess it would make sense to merge it into staging. Since I don't know exactly why it was done the way it was done in staging, maybe a second look would make sense though, to make sure it doesn't break another program.
https://bugs.winehq.org/show_bug.cgi?id=45650
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|chromium x32 sandbox |chromium 32-bit sandbox |expects different syscall |expects different syscall |thunks |thunks depending on Windows | |version
--- Comment #2 from Zebediah Figura z.figura12@gmail.com --- As far as I understand (not that I've verified this empirically), the shape of the syscall thunks differs between Windows versions, and Chromium expects the correct set of bytes corresponding to the reported OS version. Is this not the case?
https://bugs.winehq.org/show_bug.cgi?id=45650
--- Comment #3 from Fabian Maurer dark.shadow4@web.de --- Yes, and no. Yes, they check the exact byte sequence. However, they have a "relaxed" mode patching, where they do a generic approach of hooking. This approach doesn't work with the current syscall thunks, but it works after my patch. At least that's my current understanding of the issue, and what my testing with chromium shows.
https://bugs.winehq.org/show_bug.cgi?id=45650
mirh mirh@protonmail.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mirh@protonmail.ch
https://bugs.winehq.org/show_bug.cgi?id=45650
Fabian Maurer dark.shadow4@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |flaburgan@geexxx.fr
--- Comment #4 from Fabian Maurer dark.shadow4@web.de --- *** Bug 45679 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=45650
Robert Walker bob.mt.wya@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |bob.mt.wya@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=45650
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |5b5978875218b2851b8591c8b59 | |517a8502890b3 Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #5 from Zebediah Figura z.figura12@gmail.com --- This has been committed as https://github.com/wine-staging/wine-staging/commit/5b5978875218b2851b8591c8b59517a8502890b3.
https://bugs.winehq.org/show_bug.cgi?id=45650
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |UNCONFIRMED Ever confirmed|1 |0 Resolution|FIXED |---
--- Comment #6 from Zebediah Figura z.figura12@gmail.com --- Ech, actually, let's keep this open as a bug against Wine.
https://bugs.winehq.org/show_bug.cgi?id=45650
Fabian Maurer dark.shadow4@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Staged patchset| |https://github.com/wine-sta | |ging/wine-staging/tree/mast | |er/patches/winebuild-Fake_D | |lls Status|UNCONFIRMED |STAGED Ever confirmed|0 |1
--- Comment #7 from Fabian Maurer dark.shadow4@web.de --- Marking STAGED.
https://bugs.winehq.org/show_bug.cgi?id=45650
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|STAGED |RESOLVED Fixed by SHA1|5b5978875218b2851b8591c8b59 |20715ee3fdaa794a7b6ba285cdb |517a8502890b3 |72b68991c65af
--- Comment #8 from Zebediah Figura z.figura12@gmail.com --- This was basically fixed by https://source.winehq.org/git/wine.git/commitdiff/20715ee3fdaa794a7b6ba285cdb72b68991c65af.
https://bugs.winehq.org/show_bug.cgi?id=45650
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #9 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 5.22.
-
wine-bugs＠winehq.org -
WineHQ Bugzilla