http://bugs.winehq.org/show_bug.cgi?id=12730
Summary: gdi32: some tests fail when X is run in 16 bit mode, but not 32 bit Product: Wine Version: CVS/GIT Platform: PC OS/Version: Linux Status: NEW Keywords: source, testcase Severity: minor Priority: P2 Component: gdi32 AssignedTo: wine-bugs@winehq.org ReportedBy: austinenglish@gmail.com
Created an attachment (id=12382) --> (http://bugs.winehq.org/attachment.cgi?id=12382) +gdi trace in git
+make[2]: *** [bitmap.ok] Error 2 +make[2]: *** [font.ok] Error 2 +make[2]: *** [palette.ok] Error 3 +make[2]: Target `test' not remade because of errors. +make[1]: *** [gdi32/tests/__test__] Error 2
Tried running make -k test with X in 16 bit mode. Surprisingly, all the graphics tests still passed (more likely skipped, didn't check). However, gdi32 is fishy and not skipping, but instead failing.
+gdi log attached
http://bugs.winehq.org/show_bug.cgi?id=12730
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|CVS/GIT |0.9.60
http://bugs.winehq.org/show_bug.cgi?id=12730
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dank@kegel.com Keywords| |patch Target Milestone|--- |1.0.0
--- Comment #1 from Dan Kegel dank@kegel.com 2008-04-25 16:49:49 --- Francois said in http://bugs.winehq.org/show_bug.cgi?id=9916#c66 :
As far as I know there are two possible failures for bitmap.c.
One is in the black and white tests and can happen in any screen depth. Nothing is known about that failure mode.
The other specifically happens when the screen is in 16bpp and the patch below should fix it. The problem is I ran out of time just before submitting it and I haven't had time to pick it up since.
http://www.winehq.org/pipermail/wine-patches/2007-November/046504.html
http://bugs.winehq.org/show_bug.cgi?id=12730
shakaran shakaran@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |shakaran@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=12730
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|1.0.0 |1.2.0
--- Comment #2 from Dan Kegel dank@kegel.com 2008-06-09 10:13:49 --- Deferring, as 16 bit mode isn't all that common anymore, and we're perilously close to releasing 1.0.
http://bugs.winehq.org/show_bug.cgi?id=12730
--- Comment #3 from Jörg Höhle hoehle@users.sourceforge.net 2008-06-12 13:53:21 --- Created an attachment (id=13950) --> (http://bugs.winehq.org/attachment.cgi?id=13950) 16bpp screenshot showing text on opaque white boxes instead of blending in
Hi, I've not tried to apply François' patch which sounds interesting. "Meine Traumburg" is a children game which shows white boxes surrounding text output when started in 16bpp (startx -- :1 -depth 16). In 32bpp, the graphics is perfect and there's no visible box. These white boxes are opaque hence shadow the underlying graphics. The screen snapshot shows that when no text is output, the graphics remains visible. Maybe it's related to the testsuite failures? In any case, I promise to test the game again after a future release of wine successfully runs the testsuite in 16bpp X display. Or is there any WINEDEBUG trace you'd like to see right now?
http://bugs.winehq.org/show_bug.cgi?id=12730
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords|source |download
--- Comment #4 from Austin English austinenglish@gmail.com 2008-12-16 15:27:42 --- +font works fine in git, but bitmap and palette still fail. New +gdi on the way.
http://bugs.winehq.org/show_bug.cgi?id=12730
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #12382|0 |1 is obsolete| |
--- Comment #5 from Austin English austinenglish@gmail.com 2008-12-16 15:29:53 --- Created an attachment (id=17991) --> (http://bugs.winehq.org/attachment.cgi?id=17991) +gdi, bzip2 -9'ed
http://bugs.winehq.org/show_bug.cgi?id=12730
--- Comment #6 from Austin English austinenglish@gmail.com 2008-12-16 15:43:53 --- (In reply to comment #4)
+font works fine in git, but bitmap and palette still fail. New +gdi on the way.
Err, make that the font.ok test works fine now.
http://bugs.winehq.org/show_bug.cgi?id=12730
--- Comment #7 from Jörg Höhle hoehle@users.sourceforge.net 2009-03-11 08:18:44 --- Created an attachment (id=19881) --> (http://bugs.winehq.org/attachment.cgi?id=19881) excerpts from winetest version 1.1.15 logfiles in 16 vs. 32bpp
Attached is a summary of differences between running winetest in 32bpp and 16bpp modes on the same machine.
Tests from build 8e39646ac4d256b813ff69a23ba0c62ab4f08d33 (wine-1.1.15)
Differences are in: - visual.c - 3 different files?! (one per directx dir?) - bitmap.c - GetDIBits; also performs significantly less tests - palette.c - getColor - input.c - msg.c - win.c - GetForegroundWindow
o In 16bpp the three visual.c tests are mostly skipped, although the summary doesn't say so: visual.c:1306: Sanity check returned an incorrect color(00000000), can't assure the correctness of the tests, skipping visual: 3 tests executed (0 marked as todo, 0 failures), 0 skipped. (Likewise on http://test.winehq.org, some entries are green because almost no test was performed). In 32bpp, plenty of tests would be executed in visual.c.
o Some differences in the number of tests executed are not understandable, as there's no mention of skipping anything nor any difference in the log file, e.g.: sock: 13181 tests executed (5 marked as todo, 0 failures), 0 skipped. vs 32bpp: sock: 13899 tests executed (5 marked as todo, 0 failures), 0 skipped.
o Noteworthy are tests where there are more errors (or only errors) in 32bpp: - editor.c:4590: Test failed: test paste: strcmp = 1, text='testing paste Ts' - menu.c:1826: Test failed: test 0, 2, 4, 6, 8, 10, 12, 14, 16 - msg.c: sequence; testing xyz press/release
Finally, msg.c performed more tests and better results in 16bpp! msg: 13057 tests executed (52 marked as todo, 24 failures), 2 skipped. vs. with 16bpp: msg: 14296 tests executed (52 marked as todo, 2 failures), 2 skipped. Perhaps msg.c was written in 16bpp times?
In 1.1.15, "Meine Traumburg" still exhibits the 16bpp bug I mentioned in comment #3. (I promised to open a distinct issue should 16bpp tests become as successful as 32bpp while this bug persists)
http://bugs.winehq.org/show_bug.cgi?id=12730
--- Comment #8 from Alexandre Julliard julliard@winehq.org 2009-03-11 08:24:26 --- (In reply to comment #7)
o Some differences in the number of tests executed are not understandable, as there's no mention of skipping anything nor any difference in the log file, e.g.: sock: 13181 tests executed (5 marked as todo, 0 failures), 0 skipped. vs 32bpp: sock: 13899 tests executed (5 marked as todo, 0 failures), 0 skipped.
o Noteworthy are tests where there are more errors (or only errors) in 32bpp:
- editor.c:4590: Test failed: test paste: strcmp = 1, text='testing paste
Ts'
- menu.c:1826: Test failed: test 0, 2, 4, 6, 8, 10, 12, 14, 16
- msg.c: sequence; testing xyz press/release
Finally, msg.c performed more tests and better results in 16bpp! msg: 13057 tests executed (52 marked as todo, 24 failures), 2 skipped. vs. with 16bpp: msg: 14296 tests executed (52 marked as todo, 2 failures), 2 skipped. Perhaps msg.c was written in 16bpp times?
All of these are race conditions in the tests and have most likely nothing to do with 16/32 bpp.
http://bugs.winehq.org/show_bug.cgi?id=12730
Scott Ritchie scott@open-vote.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |scott@open-vote.org
--- Comment #9 from Scott Ritchie scott@open-vote.org 2009-11-08 03:31:16 --- This bug may already be fixed it seems - could you please retest?
http://bugs.winehq.org/show_bug.cgi?id=12730
--- Comment #10 from Austin English austinenglish@gmail.com 2009-11-30 23:54:04 --- gdi32/bitmap and gdi32/palette still fail: http://test.winehq.org/data/cb5a2bbb021469b6ebea56d8d3b3078474ab13dd/wine_ae... http://test.winehq.org/data/cb5a2bbb021469b6ebea56d8d3b3078474ab13dd/wine_ae...
Additionally, d3d8:visual fails, ddraw:dsurface crashes, opengl32:opengl fails, user32:cursoricon fails, and user32:msg has a todo_fixed (msg.c:4517: Test succeeded inside todo block: ShowWindow(SW_RESTORE):overlapped: marked "todo_wine" but succeeds): http://test.winehq.org/data/cb5a2bbb021469b6ebea56d8d3b3078474ab13dd/wine_ae...
http://bugs.winehq.org/show_bug.cgi?id=12730
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #11 from Alexandre Julliard julliard@winehq.org 2012-01-23 08:19:55 CST --- This is fixed now.
http://bugs.winehq.org/show_bug.cgi?id=12730
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #12 from Alexandre Julliard julliard@winehq.org 2012-01-27 14:17:56 CST --- Closing bugs fixed in 1.4-rc1.
-
wine-bugs＠winehq.org