[Bug 13536] New: MDAC 2.8 installer is launched with invalid command line syntax in ThinkWave Educator installer
http://bugs.winehq.org/show_bug.cgi?id=13536
Summary: MDAC 2.8 installer is launched with invalid command line syntax in ThinkWave Educator installer Product: Wine Version: CVS/GIT Platform: PC URL: http://download.thinkwave.org/twe28132.exe OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: nodisgod@yahoo.com
Created an attachment (id=13470) --> (http://bugs.winehq.org/attachment.cgi?id=13470) ThinkWave output
With Wine version wine-1.0-rc2-134-g4c928d3, during installation, the MDAC 2.8 installer is run, but the application complains of "command line option syntax error". Relevant lines are probably:
trace:process:CreateProcessW app (null) cmdline L"C:\windows\temp\msi3040.tmp /q /c:""setup.exe /qn1""" trace:process:find_exe_file looking for L"C:\windows\temp\msi3040.tmp" trace:process:find_exe_file Trying native exe L"C:\windows\temp\msi3040.tmp" trace:process:CreateProcessW starting L"C:\windows\temp\msi3040.tmp" as Win32 binary (0x1000000-0x154e000)
Output is attached.
http://bugs.winehq.org/show_bug.cgi?id=13536
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download
http://bugs.winehq.org/show_bug.cgi?id=13536
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #1 from Austin English austinenglish@gmail.com 2008-11-27 12:34:17 --- Still present in 1.1.9.
http://bugs.winehq.org/show_bug.cgi?id=13536
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|CVS/GIT |unspecified
--- Comment #2 from Austin English austinenglish@gmail.com 2009-01-20 02:39:08 --- Removing deprecated CVS/GIT version tag. Please retest in current git. If the bug is still present in today's wine, but was not present in some earlier version of wine, please update version field to earliest known version of wine that had the bug. Thanks!
http://bugs.winehq.org/show_bug.cgi?id=13536
Rosanne DiMesio dimesio@earthlink.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dimesio@earthlink.net
--- Comment #3 from Rosanne DiMesio dimesio@earthlink.net 2009-02-13 08:58:44 --- Still present in 1.1.14. Winetricks mdac28 fixes this particular problem.
http://bugs.winehq.org/show_bug.cgi?id=13536
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Installer
--- Comment #4 from Austin English austinenglish@gmail.com 2010-07-15 01:01:27 --- Still in 1.2-rc7.
http://bugs.winehq.org/show_bug.cgi?id=13536
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |focht@gmx.net Component|-unknown |msi Version|unspecified |1.0-rc2 Summary|MDAC 2.8 installer is |ThinkWave Educator |launched with invalid |installer launches MDAC 2.8 |command line syntax in |installer with invalid |ThinkWave Educator |command line (MSI command |installer |line property quote | |parsing)
--- Comment #5 from Anastasius Focht focht@gmx.net 2011-06-16 13:40:16 CDT --- Hello,
confirming, still present. The MDAC 2.8 installer command line is stored in MDAC28_INSTALL_CMD property in msi database and contains quotes. Dumping with Orca:
Custom action table:
--- snip --- InstallMDAC28.E7D6BCFA_9BFA_49D4_A1EE_767B7FD61E38 66 NewBinary1.E7D6BCFA_9BFA_49D4_A1EE_767B7FD61E38 [MDAC28_INSTALL_CMD] --- snip ---
Property table:
--- snip --- MDAC28_INSTALL_CMD /q /c:"setup.exe /qn1" --- snip ---
The InstallShield IDriver process passes all the properties in a huge command line to Wine MSI, some of them double quoted:
The relevant part of command line:
--- snip --- Wine-dbg>x/u szCommandLine+18666 MDAC28_INSTALL_CMD="/q /c:""setup.exe /qn1""" MDAC28_INSTALL_SEQ=EXEC MDAC28_REBOOT_NOW=0 MDAC28_SETUP_VER=2.80.1022.3 MS.1E64E430_36E0_11D2_A794_0060089A724B=C:\windows\system32\ MS.3207D1B0_80E5_11D2_B95D_006097C4DE24=C:\windows\system32\ MS.3207D1B6_80 ... --- snip ---
Corresponding trace where Wine msi sets the parsed MDAC28_INSTALL_CMD property:
--- snip --- 0045:trace:msi:msi_parse_command_line Found commandline property L"MDAC28_INSTALL_CMD" = L"/q /c:"setup.exe /qn1" MDAC28_INSTALL_SEQ=EXEC MDAC28_REBOOT_NOW=0 MDAC28_SETUP_VER=2.80.1022.3 MS.1E64E430_36E0_11D2_A794_0060089A724B=C:\windows\system32\ MS.3207D1B0_80E5_11D2_B95D_006097C4DE24=C:\windows\system32\ MS.3207D1B6_80E5_11D2_B95D_006097C4DE24=C:\windows\system32\ MS.3207D1B9"... 0045:trace:msi:msi_set_property 0x1b4618 L"MDAC28_INSTALL_CMD" L"/q /c:"setup.exe /qn1" MDAC28_INSTALL_SEQ=EXEC MDAC28_REBOOT_NOW=0 MDAC28_SETUP_VER=2.80.1022.3 MS.1E64E430_36E0_11D2_A794_0060089A724B=C:\windows\system32\ MS.3207D1B0_80E5_11D2_B95D_006097C4DE24=C:\windows\system32\ MS.3207D1B6_80E5_11D2_B95D_006097C4DE24=C:\windows\system32\ MS.3207D1B9"... --- snip ---
Because of erroneous quote parsing, the properties following are also treated as belonging to MDAC28_INSTALL_CMD property, hence the faulty command line for MDAC 2.8 installer later.
Code: http://source.winehq.org/git/wine.git/blob/4c9c50d86b475f2531f841c0ad1176470...
$ sha1sum twe28132.exe 325d91bdddf24de11901b6b18a3f51c2ed19e338 twe28132.exe
$ wine --version wine-1.3.22-129-gdad3342
Regards
http://bugs.winehq.org/show_bug.cgi?id=13536
--- Comment #6 from Hans Leidekker hans@meelstraat.net 2011-06-27 03:44:10 CDT --- Yep, we need to handle escaped double quotes.
http://bugs.winehq.org/show_bug.cgi?id=13536
Hans Leidekker hans@meelstraat.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #7 from Hans Leidekker hans@meelstraat.net 2011-07-01 15:58:43 CDT --- Fixed by b32c643c183d4e132a2a7018ef996d552b6bf0c7.
http://bugs.winehq.org/show_bug.cgi?id=13536
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #8 from Alexandre Julliard julliard@winehq.org 2011-07-08 13:48:24 CDT --- Closing bugs fixed in 1.3.24.
http://bugs.winehq.org/show_bug.cgi?id=13536
Hans Leidekker hans@meelstraat.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |b32c643c183d4e132a2a7018ef9 | |96d552b6bf0c7
-
wine-bugs＠winehq.org