[Bug 12804] New: winecfg: pressing enter in library override closes winecfg

http://bugs.winehq.org/show_bug.cgi?id=12804

Summary: winecfg: pressing enter in library override closes
                    winecfg
           Product: Wine
           Version: 0.9.60
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: programs
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]

Pressing enter when entering a dll override doesn't add the override. For those
of us that find mice an exercise in masochism and prefer keyboards, it's quite
a pain...

[Bug 12804] winecfg: pressing enter in library override closes winecfg

http://bugs.winehq.org/show_bug.cgi?id=12804

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.2.0

--- Comment #1 from Austin English   2008-04-25 22:00:14 ---
Nominating for 1.2.

[Bug 12804] winecfg: pressing enter in library override closes winecfg

http://bugs.winehq.org/show_bug.cgi?id=12804

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]       |

--- Comment #2 from Austin English   2008-04-25 22:18:24 ---
Didn't mean to CC you jeff, sorry about that.

[Bug 12804] winecfg: pressing enter in library override closes winecfg

http://bugs.winehq.org/show_bug.cgi?id=12804

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |minor

--- Comment #3 from Lei Zhang   2008-04-26 14:09:32 ---
Press Alt + A.

[Bug 12804] winecfg: pressing enter in library override closes winecfg

http://bugs.winehq.org/show_bug.cgi?id=12804

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Austin English   2008-06-12 12:17:31 ---
*** Bug 13870 has been marked as a duplicate of this bug. ***

[Bug 12804] winecfg: pressing enter in library override closes winecfg

http://bugs.winehq.org/show_bug.cgi?id=12804

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, source

--- Comment #5 from Austin English   2008-12-11 10:41:48 ---
Still present.

[Bug 12804] winecfg: pressing enter in library override closes winecfg

http://bugs.winehq.org/show_bug.cgi?id=12804

Andre Wisplinghoff  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Andre Wisplinghoff   2008-12-22 21:51:44 ---
patch sent:
http://www.winehq.org/pipermail/wine-patches/2008-December/066619.html

[Bug 12804] winecfg: pressing enter in library override closes winecfg

http://bugs.winehq.org/show_bug.cgi?id=12804

RD  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from RD   2009-07-22 09:05:37 ---
Still present in wine 1.1.26

[Bug 12804] winecfg: pressing enter in library override closes winecfg

http://bugs.winehq.org/show_bug.cgi?id=12804

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Jerome Leclanche   2009-10-25 17:08:52 ---
Any reason why patch wasn't committed?

[Bug 12804] winecfg: pressing enter in library override closes winecfg

http://bugs.winehq.org/show_bug.cgi?id=12804

Vincent Povirk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 12804] winecfg: pressing enter in library override closes winecfg

http://bugs.winehq.org/show_bug.cgi?id=12804

--- Comment #9 from Vincent Povirk   2009-11-11 16:32:10 ---
There were some replies to that patch, and they were addressed in this later
version:

http://www.winehq.org/pipermail/wine-patches/2008-December/066762.html

I don't know why the later version wasn't committed.

[Bug 12804] winecfg: pressing enter in library override closes winecfg

http://bugs.winehq.org/show_bug.cgi?id=12804

--- Comment #10 from Jerome Leclanche   2009-11-11 16:51:04 ---
@Andre

Julliard says: "It shouldn't be necessary to subclass the window, setting the
default button should be enough"

[Bug 12804] winecfg: pressing enter in library override closes winecfg

http://bugs.winehq.org/show_bug.cgi?id=12804

--- Comment #11 from Andre Wisplinghoff   2009-11-11 17:23:03 ---
@Jerome

Thanks for the info. Unfortunately, I don't intend continuing my work for wine,
though, so please some other guy go fix the bug in a simpler way :-)

[Bug 12804] winecfg: pressing enter in library override closes winecfg

http://bugs.winehq.org/show_bug.cgi?id=12804

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from Dan Kegel   2009-11-11 18:05:31 ---
This has always bugged me, hope it gets fixed for 1.2

[Bug 12804] winecfg: pressing enter in library override closes winecfg

http://bugs.winehq.org/show_bug.cgi?id=12804

Matthew Millar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #13 from Matthew Millar   2009-11-24 15:33:43 ---
Hi,

Where can you get the source for winecfg?

Is winecfg seperate source code to the general wine source?

Is winecfg programmed in C++ also? or is it gtk?

I'll try and program a patch to fix this problem.

Thanks,

Matthew Millar

[Bug 12804] winecfg: pressing enter in library override closes winecfg

http://bugs.winehq.org/show_bug.cgi?id=12804

--- Comment #14 from Dan Kegel   2009-11-24 15:38:24 ---
It's in the wine tree, in programs/winecfg.  It's in C (not c++),
and it's a win32 (winelib) app.

[Bug 12804] winecfg: pressing enter in library override closes winecfg

http://bugs.winehq.org/show_bug.cgi?id=12804

Alex Balut  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #15 from Alex Balut   2010-05-24 17:04:09 ---
Adding this SendMessage call after the call for enabling the Add button solves
the problem (when running winecfg.exe on Vista):

enable(IDC_DLLS_ADDDLL);
SendMessage(dialog, DM_SETDEFID, (WPARAM)IDC_DLLS_ADDDLL, 0);

But it does not work in Wine because there is bug 22862.

[Bug 12804] winecfg: pressing enter in library override closes winecfg

http://bugs.winehq.org/show_bug.cgi?id=12804

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
         Depends on|                            |22862

[Bug 12804] winecfg: pressing enter in library override closes winecfg

http://bugs.winehq.org/show_bug.cgi?id=12804

Mr Nobody  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #16 from Mr Nobody  2011-01-03 18:31:04 CST ---
Still present in wine-1.3.10

[Bug 12804] winecfg: pressing enter in library override closes winecfg

http://bugs.winehq.org/show_bug.cgi?id=12804

Frédéric Delanoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #17 from Frédéric Delanoy  2012-01-25 03:35:33 CST ---
Still in 1.3.37

[Bug 12804] winecfg: pressing enter in library override closes winecfg

http://bugs.winehq.org/show_bug.cgi?id=12804

A Wine user  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 12804] winecfg: pressing enter in library override closes winecfg

http://bugs.winehq.org/show_bug.cgi?id=12804

--- Comment #18 from Frédéric Delanoy  2013-05-23 13:54:38 CDT ---
Still in 1.5.30

[Bug 12804] winecfg: pressing enter in library override closes winecfg

http://bugs.winehq.org/show_bug.cgi?id=12804

Andrey Gusev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #19 from Andrey Gusev  2013-12-08 05:41:39 CST ---
Works fine in 1.7.8

[Bug 12804] winecfg: pressing enter in library override closes winecfg

http://bugs.winehq.org/show_bug.cgi?id=12804

--- Comment #20 from Rosanne DiMesio  2013-12-08 06:45:16 CST ---
Nothing has changed. Problem is still present in 1.7.8.

[Bug 12804] winecfg: pressing enter in library override closes winecfg

http://bugs.winehq.org/show_bug.cgi?id=12804

--- Comment #21 from Jerome Leclanche  2013-12-08 06:45:54 CST ---
Confirmed, still present.

[Bug 12804] winecfg: pressing enter in library override closes winecfg

http://bugs.winehq.org/show_bug.cgi?id=12804

--- Comment #22 from Andrey Gusev  2013-12-08 06:56:42 CST ---
(In reply to comment #20)
(In reply to comment #21)
What steps for reproducing the issue?

[Bug 12804] winecfg: pressing enter in library override closes winecfg

http://bugs.winehq.org/show_bug.cgi?id=12804

--- Comment #23 from André H.  2013-12-08 08:02:24 CST ---
(In reply to comment #22)
> (In reply to comment #20)
> (In reply to comment #21)
> What steps for reproducing the issue?

start winecfg
go to the libraries tab
click into the combobox
write 'abc'
press enter
expected: 'abc' in the listbox below
bug happening: winecfg closes because the OK button wrongly is the default one
and catches the enter.

[Bug 12804] winecfg: pressing enter in library override closes winecfg

http://bugs.winehq.org/show_bug.cgi?id=12804

--- Comment #24 from Andrey Gusev  2013-12-08 08:08:55 CST ---
(In reply to comment #23)

Sorry, my fault. Really still present.

[Bug 12804] winecfg: pressing enter in library override closes winecfg

http://bugs.winehq.org/show_bug.cgi?id=12804

--- Comment #25 from Rosanne DiMesio  ---
This bug is not just a minor annoyance; because of it, inexperienced users
sometimes think they've set an override when they haven't, and then report on
the forum or here that they did try a recommended native dll, but it didn't
solve their problem. The net result is a lot of wasted time and confusion for
those users and the people trying to help them.

[Bug 12804] winecfg: pressing enter in library override closes winecfg

http://bugs.winehq.org/show_bug.cgi?id=12804

Alex Henrie  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 12804] winecfg: pressing enter in library override closes winecfg

http://bugs.winehq.org/show_bug.cgi?id=12804

Hugh McMaster  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #26 from Hugh McMaster  ---
Created attachment 48868
  --> http://bugs.winehq.org/attachment.cgi?id=48868
Patch to fix the Enter key issue (by Hugh McMaster)

After going through a few different solutions -- all ugly -- I've come up with
a possible solution to this bug.

The attached patch works for me, but I need other users to test/confirm the
patch.

Feel free to post any advice or feedback. Once I can get confirmation that the
patch solves this problem, I'll submit it to wine-patches.

[Bug 12804] winecfg: pressing enter in library override closes winecfg

https://bugs.winehq.org/show_bug.cgi?id=12804

--- Comment #27 from Austin English  ---
(In reply to Hugh McMaster from comment #26)
> Created attachment 48868 [details]
> Patch to fix the Enter key issue (by Hugh McMaster)
>
> After going through a few different solutions -- all ugly -- I've come up
> with a possible solution to this bug.
>
> The attached patch works for me, but I need other users to test/confirm the
> patch.
>
> Feel free to post any advice or feedback. Once I can get confirmation that
> the patch solves this problem, I'll submit it to wine-patches.

Works for me, thanks!

[Bug 12804] winecfg: pressing enter in library override closes winecfg

http://bugs.winehq.org/show_bug.cgi?id=12804

Julian Rüger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 12804] winecfg: pressing enter in library override closes winecfg

https://bugs.winehq.org/show_bug.cgi?id=12804

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #28 from Sebastian Lackner  ---
I've added a slightly modified patch to wine-staging:

https://github.com/wine-compholio/wine-staging/tree/master/patches/winecfg-L...

The patch suggested by Hugh McMaster had the disadvantage that the default
control element was not set properly when the focus was restored after an
CBN_KILLFOCUS message, if the user didn't enter additional text.

[Bug 12804] winecfg: pressing enter in library override closes winecfg

https://bugs.winehq.org/show_bug.cgi?id=12804

--- Comment #29 from Sebastian Lackner  ---
Should be fixed with
http://source.winehq.org/git/wine.git/commit/317fc7aaf8dfa5153d4efbb27d09445...

[Bug 12804] winecfg: pressing enter in library override closes winecfg

https://bugs.winehq.org/show_bug.cgi?id=12804

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |317fc7aaf8dfa5153d4efbb27d0
                   |                            |944514b73de0f
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #30 from Austin English  ---
(In reply to Sebastian Lackner from comment #29)
> Should be fixed with
> http://source.winehq.org/git/wine.git/commit/
> 317fc7aaf8dfa5153d4efbb27d0944514b73de0f

Indeed. Thanks! I owe you a beer.

[Bug 12804] winecfg: pressing enter in library override closes winecfg

https://bugs.winehq.org/show_bug.cgi?id=12804

--- Comment #31 from Jerome Leclanche  ---
(In reply to Austin English from comment #30)

And I too. (Assuming #27562 isn't fixed by then)

[Bug 12804] winecfg: pressing enter in library override closes winecfg

https://bugs.winehq.org/show_bug.cgi?id=12804

--- Comment #32 from Jerome Leclanche  ---
I meant bug 27162 :)

[Bug 12804] winecfg: pressing enter in library override closes winecfg

https://bugs.winehq.org/show_bug.cgi?id=12804

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #33 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.38.

[Bug 12804] winecfg: pressing enter in library override closes winecfg

https://bugs.winehq.org/show_bug.cgi?id=12804
Bug 12804 depends on bug 22862, which changed state.

Bug 22862 Summary: Setting the default button in a PropertySheetPage does not work
https://bugs.winehq.org/show_bug.cgi?id=22862

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |ABANDONED