http://bugs.winehq.org/show_bug.cgi?id=21957
Summary: Missing GUID check in IAMMultiMediaStreamImpl_QueryInterface? Product: Wine Version: unspecified Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: amstream AssignedTo: wine-bugs@winehq.org ReportedBy: rainy6144@gmail.com
This is necessary to make some games work (without actually showing the media, though).
--- amstream.c.bak 2010-03-06 16:55:24.000000000 +0800 +++ amstream.c 2010-03-06 16:55:36.000000000 +0800 @@ -79,6 +79,7 @@ TRACE("(%p/%p)->(%s,%p)\n", iface, This, debugstr_guid(riid), ppvObject);
if (IsEqualGUID(riid, &IID_IUnknown) || + IsEqualGUID(riid, &IID_IMultiMediaStream) || IsEqualGUID(riid, &IID_IAMMultiMediaStream)) { IClassFactory_AddRef(iface);
http://bugs.winehq.org/show_bug.cgi?id=21957
--- Comment #1 from Jeff Zaroyko jeffz@jeffz.name 2010-03-07 01:33:52 --- Which applications are affected?
http://bugs.winehq.org/show_bug.cgi?id=21957
--- Comment #2 from rainy6144@gmail.com 2010-03-07 01:56:41 --- Solfege from Kogado Studio, for one. Without this patch, when a video clip is expected to be played, wine shows a QueryInterface error with IMultiMediaStream's GUID and the game then locks up. With the patch, the video clips are simply skipped with a couple of amstream fixme's and the game continues normally. Since the video clips can be viewed outside the game, skipping them doesn't affect gameplay too much.
By the way, I'm using wine 1.1.35, although the patch is apparently still applicable to the latest git source.
I don't know too much about COM, but since IMultiMediaStream is IAMMultiMediaStream's super-interface, I suppose it should be included in the QueryInterface.
http://bugs.winehq.org/show_bug.cgi?id=21957
Jeff Zaroyko jeffz@jeffz.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch Version|unspecified |1.1.35 Summary|Missing GUID check in |Solfege from Kogado Studio |IAMMultiMediaStreamImpl_Que |hangs when trying to |ryInterface? |playing video
--- Comment #3 from Jeff Zaroyko jeffz@jeffz.name 2010-03-07 02:39:52 --- Revising summary to reflect the problem, adding patch keyword.
http://bugs.winehq.org/show_bug.cgi?id=21957
Christian Costa titan.costa@wanadoo.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |titan.costa@wanadoo.fr
--- Comment #4 from Christian Costa titan.costa@wanadoo.fr 2010-03-07 03:47:37 --- IAMMultiMediaStream inherits from IMultiMediaStrea so your patch is correct. Please send it to wine-patches. Make sure the identation is correct before that (4 spaces tabs).
http://bugs.winehq.org/show_bug.cgi?id=21957
--- Comment #5 from Christian Costa titan.costa@wanadoo.fr 2010-04-07 04:22:18 --- The patch has been commited. This bug can be mark as resolved.
http://bugs.winehq.org/show_bug.cgi?id=21957
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED
--- Comment #6 from Dmitry Timoshkov dmitry@codeweavers.com 2010-04-07 04:31:21 --- Reported fixed.
http://bugs.winehq.org/show_bug.cgi?id=21957
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #7 from Alexandre Julliard julliard@winehq.org 2010-04-16 13:03:09 --- Closing bugs fixed in 1.1.43.
https://bugs.winehq.org/show_bug.cgi?id=21957
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|amstream |quartz
-
wine-bugs＠winehq.org