[Bug 11657] New: Problems with MessageBox API

List overview All Threads

newer

older

[Bug 19733] New: Pendulumania:...

[Bug 37373] New: No Limits 2: Help...

wine-bugs＠winehq.org

20 Feb 2008 20 Feb '08

10:16 a.m.

http://bugs.winehq.org/show_bug.cgi?id=11657

Summary: Problems with MessageBox API Product: Wine Version: 0.9.55. Platform: PC-x86-64 OS/Version: Linux Status: UNCONFIRMED Severity: major Priority: P2 Component: user32 AssignedTo: wine-bugs@winehq.org ReportedBy: lightning_uk@imgburn.com

Created an attachment (id=10859) --> (http://bugs.winehq.org/attachment.cgi?id=10859) Screenshots

When using the 'MessageBox' API, wine doesn't handle the flag 'MB_CANCELTRYCONTINUE' correctly.

It ends up displaying every button possible rather than just...

'Cancel', 'Try Again', 'Continue'.

Also, when using MB_RETRYCANCEL it puts the two buttons like this...

'Cancel', 'Retry'.

rather than...

'Retry', 'Cancel'

Screenshots of both issues have been attached.

There may be other inconsistencies, I've not tried them all.

-- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

Show replies by date

wine-bugs＠winehq.org

22 Feb 22 Feb

8 p.m.

New subject: [Bug 11657] Problems with MessageBox API

http://bugs.winehq.org/show_bug.cgi?id=11657

--- Comment #1 from Lei Zhang thestig@google.com 2008-02-22 14:00:03 --- What application(s) does this affect?

wine-bugs＠winehq.org

8:47 p.m.

New subject: [Bug 11657] Problems with MessageBox API

http://bugs.winehq.org/show_bug.cgi?id=11657

--- Comment #2 from LIGHTNING UK! lightning_uk@imgburn.com 2008-02-22 14:47:38 --- Well my program - ImgBurn - calls the MessageBox API with both those flags at one point or another. Obviously this isn't application specific though.

Those screenshots were taken having just done this quickly in code to test wine's handling of it (because I'd noticed it earlier on when I was doing something else)...

MessageBox(NULL, "Bug in wine?", "ImgBurn", MB_CANCELTRYCONTINUE);

and

MessageBox(NULL, "Bug in wine?", "ImgBurn", MB_RETRYCANCEL);

wine-bugs＠winehq.org

7 Mar 7 Mar

9:53 p.m.

New subject: [Bug 11657] Problems with MessageBox API

http://bugs.winehq.org/show_bug.cgi?id=11657

Jason Edmeades us@edmeades.me.uk changed:

--- Comment #3 from Jason Edmeades us@edmeades.me.uk 2008-03-07 15:53:34 --- Confirmed

wine-bugs＠winehq.org

11:21 p.m.

New subject: [Bug 11657] Problems with MessageBox API

http://bugs.winehq.org/show_bug.cgi?id=11657

--- Comment #4 from Jason Edmeades us@edmeades.me.uk 2008-03-07 17:21:17 --- Created an attachment (id=11184) --> (http://bugs.winehq.org/attachment.cgi?id=11184) Patch

Should fix this - please test

wine-bugs＠winehq.org

11:21 p.m.

New subject: [Bug 11657] Problems with MessageBox API

http://bugs.winehq.org/show_bug.cgi?id=11657

--- Comment #5 from Jason Edmeades us@edmeades.me.uk 2008-03-07 17:21:48 --- Created an attachment (id=11185) --> (http://bugs.winehq.org/attachment.cgi?id=11185) Sample C pgm for testing

wine-bugs＠winehq.org

8 Mar 8 Mar

8:10 a.m.

New subject: [Bug 11657] Problems with MessageBox API

http://bugs.winehq.org/show_bug.cgi?id=11657

--- Comment #6 from Dmitry Timoshkov dmitry@codeweavers.com 2008-03-08 02:10:50 ---

...

/* Index the order the buttons need to appear to an ID* constant */

static int buttonOrder[10] = { 6, 7, 1, 3, 4, 2, 5, 10, 11, 9 };

Should be 'const'

...

for (i=1; i < 12; i++)
```
   /* No button 8 (Close) */
```
```
   if (i != 8) {
```

       SendDlgItemMessageW (hwnd, i, WM_SETFONT, (WPARAM)hFont, 0);

```
   }
```

...

for (buttons = 0, i = 1; i < 8; i++)
for (buttons = 0, i = 1; i < 12; i++) {
   if (i == 8) continue; /* No CLOSE button */

What's so special about Close button?

...

for (buttons = i = 0; i < (sizeof(buttonOrder) / sizeof(int)); i++) {

Should be 'sizeof(buttonOrder) / sizeof(buttonOrder[0])'

wine-bugs＠winehq.org

2:17 p.m.

New subject: [Bug 11657] Problems with MessageBox API

http://bugs.winehq.org/show_bug.cgi?id=11657

--- Comment #7 from Jason Edmeades us@edmeades.me.uk 2008-03-08 08:17:15 ---

...

Should be 'const' Should be 'sizeof(buttonOrder) / sizeof(buttonOrder[0])'

Thanks

...

What's so special about Close button?

I cant see a way for the API to provide such a button! Its got an ID value in the range used for the other buttons, but we dont need a close button - hence its skipped.

Thanks - I'll make the changes and submit as soon as I get a chance

wine-bugs＠winehq.org

9 Jun 9 Jun

7:20 p.m.

New subject: [Bug 11657] Problems with MessageBox API

http://bugs.winehq.org/show_bug.cgi?id=11657

Austin English austinenglish@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch, testcase

--- Comment #8 from Austin English austinenglish@gmail.com 2008-06-09 14:20:10 --- Is this still an issue in current (1.0-rc4 or newer) wine?

wine-bugs＠winehq.org

12 Jun 12 Jun

9:30 a.m.

New subject: [Bug 11657] Problems with MessageBox API

http://bugs.winehq.org/show_bug.cgi?id=11657

johne53 johne53@tiscali.co.uk changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |johne53@tiscali.co.uk

--- Comment #9 from johne53 johne53@tiscali.co.uk 2008-06-12 04:30:24 --- This might be related to a problem I've just found this morning.... Windows itself seems to create message boxes based on the supplied type / icontype etc. So, for example, a message box created with MB_YESNO|MB_ICONSTOP will have a button with IDYES and a button with IDNO. But it WOULDN'T have buttons with IDs of (say) IDOK and IDCANCEL.

However, Wine seems to create message boxes with all the standard button IDs predefined - but then it only uses (i.e. displays) the ones that are relevant. Therefore, given a suitable handle to a messagebox, GetDlgItem(hMsgBox, IDOK) will return a seemingly valid handle - even if the message box DOESN'T have an OK button.

Is this something that the developers are aware of?

P.S. Congratulations on a great and impressive product.

wine-bugs＠winehq.org

13 Dec 13 Dec

11:31 p.m.

New subject: [Bug 11657] Problems with MessageBox API

http://bugs.winehq.org/show_bug.cgi?id=11657

--- Comment #10 from Austin English austinenglish@gmail.com 2008-12-13 17:31:02 --- Is this still an issue in current (1.1.10) or newer wine?

wine-bugs＠winehq.org

12 Mar 12 Mar

6:21 p.m.

New subject: [Bug 11657] Problems with MessageBox API

http://bugs.winehq.org/show_bug.cgi?id=11657

--- Comment #11 from LIGHTNING UK! lightning_uk@imgburn.com 2009-03-12 13:21:46 --- The buttons are fixed in that the right ones show up when they should do and in the correct order. (This is with 1.1.16)

I did notice that the keyboard accelerators don't look right when 'MB_CANCELTRYCONTINUE' is specified though. The 'Cancel' and 'Continue' buttons both have the underscore under the 'C'.

When that box is displayed under Windows (Vista SP1), the 'Cancel' button doesn't have an accelerator and 'C' is used for the 'Continue' button.

wine-bugs＠winehq.org

16 Mar 16 Mar

4:46 a.m.

New subject: [Bug 11657] Problems with MessageBox API

http://bugs.winehq.org/show_bug.cgi?id=11657

--- Comment #12 from Dmitry Timoshkov dmitry@codeweavers.com 2009-03-15 23:46:14 --- (In reply to comment #11)

...

When that box is displayed under Windows (Vista SP1), the 'Cancel' button doesn't have an accelerator and 'C' is used for the 'Continue' button.

That's a simple patch for dlls/user32/resources/user32_En.rc, feel free to submit to wine-patches.

wine-bugs＠winehq.org

4:47 a.m.

New subject: [Bug 11657] Problems with MessageBox API

http://bugs.winehq.org/show_bug.cgi?id=11657

--- Comment #13 from Dmitry Timoshkov dmitry@codeweavers.com 2009-03-15 23:47:24 --- If this bug is fixed please mark it as FIXED.

wine-bugs＠winehq.org

10:17 a.m.

New subject: [Bug 11657] Problems with MessageBox API

http://bugs.winehq.org/show_bug.cgi?id=11657

--- Comment #14 from LIGHTNING UK! lightning_uk@imgburn.com 2009-03-16 05:17:01 --- Changing it in dlls/user32/resources/user32_En.rc would then make it apply to all the MessageBox calls though wouldn't it?

It just needs to lose the 'C' accelerator on the 'Cancel' button when 'MB_CANCELTRYCONTINUE' is used.

wine-bugs＠winehq.org

15 Sep 15 Sep

8:33 p.m.

New subject: [Bug 11657] Problems with MessageBox API

http://bugs.winehq.org/show_bug.cgi?id=11657

--- Comment #15 from Austin English austinenglish@gmail.com 2009-09-15 15:33:26 --- Is this still an issue in current (1.1.29 or newer) wine?

wine-bugs＠winehq.org

19 Dec 19 Dec

11:13 p.m.

New subject: [Bug 11657] Problems with MessageBox API

http://bugs.winehq.org/show_bug.cgi?id=11657

Jason Edmeades us@edmeades.me.uk changed:

What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|us@edmeades.me.uk |wine-bugs@winehq.org

wine-bugs＠winehq.org

29 Dec 29 Dec

2:29 p.m.

New subject: [Bug 11657] Problems with MessageBox API

http://bugs.winehq.org/show_bug.cgi?id=11657

--- Comment #16 from LIGHTNING UK! lightning_uk@imgburn.com 2009-12-29 08:29:00 --- Still an issue in 1.1.35 with the keyboard accelerator being on the letter 'C' for both 'Continue' and 'Cancel' when the message box is displayed with the 'MB_CANCELTRYCONTINUE' layout.

wine-bugs＠winehq.org

5:17 p.m.

New subject: [Bug 11657] Problems with MessageBox API

http://bugs.winehq.org/show_bug.cgi?id=11657

Dmitry Timoshkov dmitry@codeweavers.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Severity|major |minor

wine-bugs＠winehq.org

29 Mar 29 Mar

11:57 p.m.

New subject: [Bug 11657] Problems with MessageBox API

http://bugs.winehq.org/show_bug.cgi?id=11657

Austin English austinenglish@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download

--- Comment #17 from Austin English austinenglish@gmail.com 2011-03-29 18:57:41 CDT --- (In reply to comment #16)

...

Still an issue in 1.1.35 with the keyboard accelerator being on the letter 'C' for both 'Continue' and 'Cancel' when the message box is displayed with the 'MB_CANCELTRYCONTINUE' layout.

Still in 1.3.16.

wine-bugs＠winehq.org

24 Nov 24 Nov

2:21 a.m.

New subject: [Bug 11657] Problems with MessageBox API

http://bugs.winehq.org/show_bug.cgi?id=11657

Bruno Jesus 00cpxxx@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |00cpxxx@gmail.com

--- Comment #18 from Bruno Jesus 00cpxxx@gmail.com 2011-11-23 20:21:38 CST --- Still present in 1.3.33. Is it possible to fix this in a simple way? In portuguese the Cancel also does not display the accelerator.

wine-bugs＠winehq.org

13 Jun 13 Jun

11:19 p.m.

New subject: [Bug 11657] Problems with MessageBox API

https://bugs.winehq.org/show_bug.cgi?id=11657

--- Comment #19 from Ken Sharp imwellcushtymelike@gmail.com --- Is this still an issue in Wine 1.7.45 or later?

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

6 Feb 6 Feb

2:17 a.m.

New subject: [Bug 11657] Problems with MessageBox API

https://bugs.winehq.org/show_bug.cgi?id=11657

Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:

--- Comment #20 from Alistair Leslie-Hughes leslie_alistair@hotmail.com --- This issue appears to be fixed in 1.9.2.

If the problem still exists, please re-open.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

19 Feb 19 Feb

2:57 p.m.

New subject: [Bug 11657] Problems with MessageBox API

https://bugs.winehq.org/show_bug.cgi?id=11657

Alexandre Julliard julliard@winehq.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED

--- Comment #21 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 1.9.4.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

3249

Age (days ago)

6170

Last active (days ago)

wine-bugs@winehq.org

23 comments

1 participants

tags (0)

participants (1)

wine-bugs＠winehq.org