http://bugs.winehq.org/show_bug.cgi?id=22735
Summary: Resize of PlayOnline viewer's window makes it's content upside down Product: Wine Version: 1.1.44 Platform: x86 URL: http://dl.square-enix.co.jp/polus/setup.exe OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: wylda@volny.cz
In windowed mode, resize of PlayOnline viewer's window makes it's content upside down.
1. This is not 100% regression as everybody imagine under this term, but i didn't want to make more mess with this bit different behavior in bug 22290 and because this patch may not be correct i filled up new bug. Actually there is a "nearly perfect" patch for this resize issue in bug 22290, see comment #9.
2. I did a regression test between 1.1.43 and 1.1.44:
commit be43c867a5fd06dc6b9f5b686abb22a1e17a712e Author: Henri Verbeet hverbeet@codeweavers.com Date: Mon May 3 22:03:27 2010 +0200
wined3d: Split context_apply_state() into separate functions for each usage.
:040000 040000 d82b202d5a2928a54657cdb72c22bae5f324cacb f7c2e8dfdb1fdadad39807822c75d5ed62efaca0 M dlls
3. No other bug report suffers from this commit.
4. Revert of this patch after git checkout makes that problem go away.
5. Adding author of this patch to CC.
--private keyword: bisected
http://bugs.winehq.org/show_bug.cgi?id=22735
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |hverbeet@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=22735
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, regression Component|-unknown |directx-d3d
http://bugs.winehq.org/show_bug.cgi?id=22735
--- Comment #1 from Henri Verbeet hverbeet@gmail.com 2010-05-17 08:21:02 --- Created an attachment (id=28037) --> (http://bugs.winehq.org/attachment.cgi?id=28037) patch
Please give this patch a try.
There is still a bug where the window offset relative to the bottom-left corner of the screen doesn't appear to be subtracted properly for front buffer blits. I didn't investigate that yet, but does there already exist a bug for that somewhere?
http://bugs.winehq.org/show_bug.cgi?id=22735
--- Comment #2 from Wylda wylda@volny.cz 2010-05-17 10:46:26 ---
Please give this patch a try.
Yes, no more upside down picture :)
There is still a bug where the window offset relative to the bottom-left corner of the screen doesn't appear to be subtracted properly for front buffer blits.
There is a patch/hack/prove of concept in bug 22290 comment #8 / #9. When applied, then relative offset gone - even asynchronous speed of window and it's content gone (during the movement). I don't know, why Stefan didn't drag that to the finish (git merging) :(
Maybe looking into that could save you time with finding out what's going on. It doesn't work with current git, but if you take that patch and apply on git around 2010-04-10, it will definitely work correctly.
I didn't investigate that yet, but does there already exist a bug for that somewhere?
Actually if this patch gets into the git, we can close this bug and even bug 22290. And if Stefan patch is somewhat usable for you and can be used together with your patch, i won't need to open new bug for that :)
I saw this issue with other games and my notes have at least one particular entry(game) with such symptoms, but do not want to mix that now.
http://bugs.winehq.org/show_bug.cgi?id=22735
--- Comment #3 from Wylda wylda@volny.cz 2010-05-17 10:53:22 ---
Maybe looking into that could save you time with finding out what's going on. It doesn't work with current git, but if you take that patch and apply on git around 2010-04-10, it will definitely work correctly.
Oppps i take this part back :) Still works in current git without offset, upside down etc. I applied that patch with switch --dry-run, thus it wasn't truly applied ;)
http://bugs.winehq.org/show_bug.cgi?id=22735
--- Comment #4 from Henri Verbeet hverbeet@gmail.com 2010-05-19 11:54:05 --- Should be fixed by 96cdab179245b18ef98be7cfa37f68ce43ee740e.
http://bugs.winehq.org/show_bug.cgi?id=22735
--- Comment #5 from Wylda wylda@volny.cz 2010-05-19 12:42:40 --- (In reply to comment #4)
Should be fixed by 96cdab179245b18ef98be7cfa37f68ce43ee740e.
I tried that, but it is a different commit...
Confirming, FIXED in wine-1.1.44-322-g5cc00e8.
Particular commit (wine-1.1.44-274-g4889c33): http://source.winehq.org/git/wine.git/?a=commit;h=4889c33da6831a909e505229bc...
Thank you Henri!
http://bugs.winehq.org/show_bug.cgi?id=22735
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED
--- Comment #6 from Wylda wylda@volny.cz 2010-05-19 12:43:51 ---
Ahh, i forgot to setup the flag ;)
http://bugs.winehq.org/show_bug.cgi?id=22735
--- Comment #7 from Henri Verbeet hverbeet@gmail.com 2010-05-19 12:48:34 --- 96cdab179245b18ef98be7cfa37f68ce43ee740e just fixes this "regression", 4889c33da6831a909e505229bc59cf64461617ec is for bug 22290.
http://bugs.winehq.org/show_bug.cgi?id=22735
--- Comment #8 from Wylda wylda@volny.cz 2010-05-19 13:00:12 --- (In reply to comment #7)
96cdab179245b18ef98be7cfa37f68ce43ee740e just fixes this "regression", 4889c33da6831a909e505229bc59cf64461617ec is for bug 22290.
OK, sorry for confusion.
http://bugs.winehq.org/show_bug.cgi?id=22735
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #9 from Alexandre Julliard julliard@winehq.org 2010-05-21 14:40:24 --- Closing bugs fixed in 1.2-rc1.
http://bugs.winehq.org/show_bug.cgi?id=22735
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |96cdab179245b18ef98be7cfa37 | |f68ce43ee740e Regression SHA1| |be43c867a5fd06dc6b9f5b686ab | |b22a1e17a712e
-
wine-bugs＠winehq.org