[Bug 20598] New: Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

Summary: Elements Do Not Appear in Patcher Dialogue Box in
                    Perfectworld International
           Product: Wine
           Version: 1.1.32
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=24577)
 --> (http://bugs.winehq.org/attachment.cgi?id=24577)
Settings Element Dialogue Box

Hi it would seem that a new problem has cropped up with wine 1.1.32. Elements
of Patcher's dialogue box do not appear as can be seen in the attached screen
shot. That is the Background color does show up, Radio buttons and the like do
not show up.

I can start the game OK.

It worked fine up to 1.1.29. It was suggested that I do a regression test.
Could you please describe how I might do that?

Thanks

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #1 from Austin English   2009-11-07 03:27:10 ---
http://wiki.winehq.org/RegressionTesting

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #2 from Eli Wapniarski   2009-11-07 14:12:17 ---
Looks involved... But I will certainly try to do this.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #3 from Eli Wapniarski   2009-11-08 05:51:31 ---
Builing from git, the problem seems to persist. Will progress to regression
testing.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #4 from Eli Wapniarski   2009-11-08 09:45:24 ---
K then....

ran

git bisect start
git bisect good wine-1.1.29
git bisect bad wine-1.1.32
CC="ccache gcc -m32" ./configure --prefix=/usr --with-x
make depend
make
make install

got

make[2]: Entering directory `/home/eli/wine-git/dlls/winecrt0'
/usr/bin/install -c  -m 644  libwinecrt0.a /usr/lib/wine/libwinecrt0.a
make[2]: Leaving directory `/home/eli/wine-git/dlls/winecrt0'
/usr/bin/install -c  -m 644  `basename __install__/commdlg.dll16`
/usr/lib/wine/`basename __install__/commdlg.dll16`
/usr/bin/install -c  -m 644  `basename __install__/gdi.exe16`
/usr/lib/wine/`basename __install__/gdi.exe16`
/usr/bin/install -c  -m 644  `basename __install__/krnl386.exe16`
/usr/lib/wine/`basename __install__/krnl386.exe16`
/usr/bin/install -c  -m 644  `basename __install__/mmsystem.dll16`
/usr/lib/wine/`basename __install__/mmsystem.dll16`
/usr/bin/install: omitting directory `mmsystem.dll16'
make[1]: *** [__install__/mmsystem.dll16] Error 1
make[1]: Leaving directory `/home/eli/wine-git/dlls'
make: *** [dlls/__install__] Error 2

ran 3 times

git bisect skip

same result

Any advice

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

Eli Wapniarski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Eli Wapniarski   2009-11-08 09:49:35 ---
However... running

env WINEPREFIX="/home/eli/.wine" ~/wine-git/wine "C:\Program Files\Perfect
World Entertainment\Perfect World International\patcher\patcher.exe"

The game runs without the bug....Continuing with

git bisect good

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #6 from Eli Wapniarski   2009-11-08 14:41:18 ---
k... Done....

2854884a428e222cbb9078d875068a72f25365c4 is first bad commit
commit 2854884a428e222cbb9078d875068a72f25365c4
Author: Nikolay Sivov 
Date:   Thu Oct 22 13:15:30 2009 +0400

gdi32: Always create a context for DIB_RGB_COLORS.

:040000 040000 7c58b1ef8bd519a7156105b62a2b31c48bfd61df
8cc661ec9142cdada7a04afffc8c53670ee2c0a2 M      dlls

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #7 from Eli Wapniarski   2009-11-08 14:47:19 ---
If there's anything else I can do to help fix this, please let me know.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
                 CC|                            |[e-mail]

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |gdi32

--- Comment #8 from Nikolay Sivov   2009-11-08 20:24:30 ---
(In reply to comment #6)
> k... Done....
>
> 2854884a428e222cbb9078d875068a72f25365c4 is first bad commit
> commit 2854884a428e222cbb9078d875068a72f25365c4
> Author: Nikolay Sivov 
> Date:   Thu Oct 22 13:15:30 2009 +0400
> gdi32: Always create a context for DIB_RGB_COLORS.
>
> :040000 040000 7c58b1ef8bd519a7156105b62a2b31c48bfd61df
> 8cc661ec9142cdada7a04afffc8c53670ee2c0a2 M      dlls

Does reverting help? Attach a screenshot without this patch please.

Also provide a download link for this application, I'd like to test it.
Probably we should still use supplied context for DIB_RGB_COLORS if it's valid.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #9 from Eli Wapniarski   2009-11-09 00:24:58 ---
The game can be downloaded from

http://pwi.perfectworld.com/download

Not applying the patch does help. I will be providing a screen shot ASAP

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #10 from Eli Wapniarski   2009-11-09 02:31:18 ---
Created an attachment (id=24613)
 --> (http://bugs.winehq.org/attachment.cgi?id=24613)
Working Patcher Settings Dialogue Box

Here is the requested screen shot

Thanks for your help with this

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
                URL|                            |http://pwi.perfectworld.com
                   |                            |/download

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #11 from Nikolay Sivov   2009-11-09 09:25:24 ---
(In reply to comment #9)
> The game can be downloaded from
>
> http://pwi.perfectworld.com/download
>
> Not applying the patch does help. I will be providing a screen shot ASAP

Ok. Unfortunately I'm a bit away of my devel box, and home speedy network, so I
can't be fast enough here. For anyone willing to help - I think the first thing
to try is to use supplied context for DIB_RGB_COLORS flag if it's valid, and
create another context only if it's invalid. It's a very simple diff, I'm sorry
I'm not able to do it now.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #12 from Nikolay Sivov   2009-11-09 19:10:07 ---
Created an attachment (id=24629)
 --> (http://bugs.winehq.org/attachment.cgi?id=24629)
Try to use supplied context first

Try this patch. Also we need to retest the initial problem that failed patch
fixes - bug 15312. A very simple way to install VS2005 is 'winetricks
vc2005express', I'd like you to test this one too.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #13 from Eli Wapniarski   2009-11-09 23:32:08 ---
Just ran:

git bisect --head origin
CC="ccache gcc -m32" ./configure
make depend
make

compiling now...

After quick testing the original problem, I will install  vc2005 via winetricks
and let you know.

Thank you so very much for your very quick assistance with this.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #14 from Eli Wapniarski   2009-11-09 23:35:14 ---
oops wrong sequence of events mentioned. Would have been kinda pointless if I
didn't apply the patch you provided :)

git bisect --head origin
patch -p1 < setdibits.diff
CC="ccache gcc -m32" ./configure
make depend
make

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #15 from Eli Wapniarski   2009-11-10 04:23:45 ---
K... Thank you for the fix...

Perfectworld International is working again as it should.

I tried to do the second test... dotnet20, msxml6 and vc2005express seemed to
install just fine. However, when I tried running the application

env WINEPREFIX="/home/eli/.wine" ~/wine-git/wine "C:\Program Files\Microsoft
Visual Studio 8\Common7\IDE\VCExpress.exe"

It crashed and I get the following output.

fixme:ole:CoInitializeSecurity (0x33f908,-1,(nil),(nil),0,0,(nil),8,(nil)) -
stub!
fixme:urlmon:CoInternetSetFeatureEnabled 13, 0x00000002, 1, stub
err:ole:TLB_ReadTypeLib Loading of typelib L"C:\Program Files\Microsoft
Visual Studio 8\Common7\IDE\dte80a.olb" failed with error 2
fixme:imm:ImmDisableIME (-1): stub
fixme:ntdll:find_reg_tz_info Can't find matching timezone information in the
registry for bias -120, std (d/m/y): 27/09/2009, dlt (d/m/y): 27/03/2009
fixme:thread:NtQueryInformationThread Cannot get kerneltime or usertime of
other threads
fixme:thread:NtQueryInformationThread info class 9 not supported yet
fixme:thread:NtQueryInformationThread info class 9 not supported yet
fixme:advapi:RegisterEventSourceW ((null),L"Microsoft VC Express Edition"):
stub
fixme:advapi:ReportEventW
(0xcafe4242,0x0001,0x0000,0x000003e8,(nil),0x0008,0x000000e4,0x3009a1b4,0x6cc620):
stub
err:eventlog:ReportEventW L"vcexpress.exe"
err:eventlog:ReportEventW L"8.0.50727.42"
err:eventlog:ReportEventW L"4333d0ba"
err:eventlog:ReportEventW L"unknown"
err:eventlog:ReportEventW L"0.0.0.0"
err:eventlog:ReportEventW L"00000000"
err:eventlog:ReportEventW L"0"
err:eventlog:ReportEventW L"68350c3e"
fixme:advapi:DeregisterEventSource (0xcafe4242) stub
err:ole:CoInitializeEx Attempt to change threading model of this apartment from
multi-threaded to apartment threaded
err:ole:CoInitializeEx Attempt to change threading model of this apartment from
multi-threaded to apartment threaded
fixme:richedit:ME_HandleMessage EM_SETMARGINS: stub
fixme:richedit:ME_HandleMessage EM_SETMARGINS: stub
err:ole:CoUninitialize Mismatched CoUninitialize
err:ole:CoUninitialize Mismatched CoUninitialize

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #16 from Nikolay Sivov   2009-11-10 06:56:27 ---
(In reply to comment #15)
> K... Thank you for the fix...
>
> Perfectworld International is working again as it should.

That's expected.
> I tried to do the second test... dotnet20, msxml6 and vc2005express seemed to
> install just fine. However, when I tried running the application
>
> env WINEPREFIX="/home/eli/.wine" ~/wine-git/wine "C:\Program Files\Microsoft
> Visual Studio 8\Common7\IDE\VCExpress.exe"
>
> It crashed and I get the following output.

Crap. Did you try just 'winetricks vc2005express'? It should install all
prerequisites automatically. This could mean another regression (or winetricks
problem). It crashes without patching too I suppose? (if so please file a bug
for that, cause it definitely used to work - I tested on it).

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #17 from Eli Wapniarski   2009-11-10 07:47:34 ---
Yes... I just did it from winetricks. I even tried a completely fresh ~/.wine

Just crashed...

How would you like me to proceed with the bug report?

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #18 from Vitaliy Margolen   2009-11-10 08:34:10 ---
(In reply to comment #17)
> How would you like me to proceed with the bug report?

vcexpress has nothing to do with this bug report. Open a new one.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #19 from Eli Wapniarski   2009-11-10 11:24:05 ---
Just wanna check with you one last time before opening a new bug report...

Sorry if I seem a little overly cautious.

I just tested running vcexpress against wine without the patch and everything
seemed to work OK. It did not crash and No black backgrounds as expected.

With the wine patched with your patch and it crashed. I'm assuming that the
patch has not yet been committed and so I just wanted to make sure you wanted
me to proceed with a new bug report.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #20 from Nikolay Sivov   2009-11-10 19:59:29 ---
(In reply to comment #19)
> Just wanna check with you one last time before opening a new bug report...
>
> Sorry if I seem a little overly cautious.
>
> I just tested running vcexpress against wine without the patch and everything
> seemed to work OK. It did not crash and No black backgrounds as expected.

Ok. No need for new report then, will think more.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #21 from Dmitry Timoshkov   2009-12-27 23:31:38 ---
*** Bug 21160 has been marked as a duplicate of this bug. ***

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #22 from BD   2009-12-29 09:04:24 ---
(In reply to comment #21)
> *** Bug 21160 has been marked as a duplicate of this bug. ***

the only way i have been able to fix this is by using the version 1.1.31
version gdi folder and compiling it into version 1.1.35. (removing the
gdi.exe16 folder and configure/configure.ac lines in top level dir to not
compile the gdi.exe16.

should the next wine versions use the version 1.1.31 gdi format until a fix is
found? i'll keep checking back and willing to help test :)

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #23 from Nikolay Sivov   2009-12-29 09:10:34 ---
There's no need to play with subdirs, try to revert regressed commit mentioned
here. There's most likely no relation to 16-bit separation you've mentioned.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #24 from BD   2009-12-29 13:51:34 ---
(In reply to comment #23)
> There's no need to play with subdirs, try to revert regressed commit mentioned
> here. There's most likely no relation to 16-bit separation you've mentioned.

the above patch got the icons working now. using fresh wine-1.1.35 source i
used
patch -p1 < setdibits.diff
then ./configure && make depend && make
ty for the fix.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #25 from Wylda   2010-01-03 11:57:52 ---

Still not fixed in wine-1.1.35-364-g9dc584d, consider UNCONFIRMED->NEW.

* Also confirming regression test between 1.1.31 and 1.1.32:
2854884a428e222cbb9078d875068a72f25365c4 (comment #6) is correctly bisected
commit.

* Revert of this patch on top of wine-1.1.35-364-g9dc584d makes that problem
go away.

* Patch from comment #12 applied on top of vanilla wine-1.1.35-364-g9dc584d
fixes the problem

* I also tried "winetricks vc2005express", during installation it offers three
choices and i left the default (only the 1st choice ~ IDE). Installation of VC
end up with "...Successfully installed..."

@Nikolay> everything seems OK :)  Well, at least these two tests are OK.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #26 from Wylda   2010-01-05 15:59:05 ---

Still not fixed in wine-1.1.35-439-g2f529c3.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #27 from BD   2010-01-09 14:11:29 ---
(In reply to comment #26)
> Still not fixed in wine-1.1.35-439-g2f529c3.

not working in wine-1.1.36 either but i think i have a fix if anyone wants to
confirm it. reversing 2 statements in dib.c makes it work.

original non working section in dib.c:

INT WINAPI SetDIBits( HDC hdc, HBITMAP hbitmap, UINT startscan,
              UINT lines, LPCVOID bits, const BITMAPINFO *info,
              UINT coloruse )
{
    DC *dc;
    BITMAPOBJ *bitmap;
    INT result = 0;

if (coloruse == DIB_RGB_COLORS) hdc = CreateCompatibleDC(0);

if (!(dc = get_dc_ptr( hdc )))
        return 0;

update_dc( dc );

changed and working dib.c:

INT WINAPI SetDIBits( HDC hdc, HBITMAP hbitmap, UINT startscan,
              UINT lines, LPCVOID bits, const BITMAPINFO *info,
              UINT coloruse )
{
    DC *dc;
    BITMAPOBJ *bitmap;
    INT result = 0;

if (!(dc = get_dc_ptr( hdc ))) return 0;

if (coloruse == DIB_RGB_COLORS) hdc = CreateCompatibleDC(0);

update_dc( dc );

hopefully this has it fixed for all.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #28 from Wylda   2010-01-09 14:29:53 ---
(In reply to comment #27)
> (In reply to comment #26)
> > Still not fixed in wine-1.1.35-439-g2f529c3.
>
> not working in wine-1.1.36 either but i think i have a fix if anyone wants to
> confirm it. reversing 2 statements in dib.c makes it work.

OK, test scheduled :) Anyway, do you think this is a better patch than
Nikolay's patch at comment #12 which is already confirmed as working??

BTW: Did you try "winetricks vc2005express" if does it still install correctly
with your patch?

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #29 from BD   2010-01-09 16:17:31 ---
(In reply to comment #28)
> (In reply to comment #27)
> > (In reply to comment #26)
> > > Still not fixed in wine-1.1.35-439-g2f529c3.
> >
> > not working in wine-1.1.36 either but i think i have a fix if anyone wants to
> > confirm it. reversing 2 statements in dib.c makes it work.
>
> OK, test scheduled :) Anyway, do you think this is a better patch than
> Nikolay's patch at comment #12 which is already confirmed as working??
>
> BTW: Did you try "winetricks vc2005express" if does it still install correctly
> with your patch?

i think this patch is best because it keeps the same coding in version 1.1.36
with just the 2 statements switched around. vc2005express installed with
winetricks with no problems.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #30 from Nikolay Sivov   2010-01-09 16:46:18 ---
(In reply to comment #29)
> i think this patch is best because it keeps the same coding in version 1.1.36
> with just the 2 statements switched around.

That's not a point. Patch is wrong cause in DIB_RGB_COLORS case we don't care
about supplied context.
> vc2005express installed with
> winetricks with no problems.

Yes, but run it you see black corruptions on toolbars, don't you?

I'll ask for some advice at wine-devel next week, cause I really need a test
here to fix it properly.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #31 from BD   2010-01-09 16:59:22 ---
Created an attachment (id=25631)
 --> (http://bugs.winehq.org/attachment.cgi?id=25631)
screen shot of vc++

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #32 from BD   2010-01-09 17:00:15 ---
(In reply to comment #31)
> Created an attachment (id=25631)

--> (http://bugs.winehq.org/attachment.cgi?id=25631) [details]
> screen shot of vc++

i dont see any corruption

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #33 from Nikolay Sivov   2010-01-09 17:06:35 ---
(In reply to comment #32)
> i dont see any corruption

Black panel headers and black panel tab area.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #34 from BD   2010-01-09 17:20:00 ---
(In reply to comment #33)
> (In reply to comment #32)
> > i dont see any corruption
>
> Black panel headers and black panel tab area.

ok, i see that. sorry for wasting you all's time. good luck on getting it fixed
because its out of my league. ( i was having fun and learned a lot tho :)
thanks for the patience.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #35 from BD   2010-01-11 14:24:54 ---
(In reply to comment #34)
> (In reply to comment #33)
> > (In reply to comment #32)
> > > i dont see any corruption
> >
> > Black panel headers and black panel tab area.
>
> ok, i see that. sorry for wasting you all's time. good luck on getting it fixed
> because its out of my league. ( i was having fun and learned a lot tho :)
> thanks for the patience.

i fixed it :)

INT WINAPI SetDIBits( HDC hdc, HBITMAP hbitmap, UINT startscan,
              UINT lines, LPCVOID bits, const BITMAPINFO *info,
              UINT coloruse )
{
    DC *dc;
    BITMAPOBJ *bitmap;
    INT result = 0;
    BOOL bDesktopDC = FALSE;

if (hdc == 0)
    {
        hdc = CreateCompatibleDC(0);
        bDesktopDC = TRUE;
    }

if (!(dc = get_dc_ptr( hdc )))
        return 0;

update_dc( dc );

if (!(bitmap = GDI_GetObjPtr( hbitmap, OBJ_BITMAP )))
    {
        release_dc_ptr( dc );
        return 0;
    }

if (!bitmap->funcs && !BITMAP_SetOwnerDC( hbitmap, dc )) goto done;

result = lines;
    if (bitmap->funcs)
    {
        if (bitmap->funcs != dc->funcs)
            ERR( "not supported: DDB bitmap %p not belonging to device %p\n",
hbitmap, hdc );
        else if (dc->funcs->pSetDIBits)
            result = dc->funcs->pSetDIBits( dc->physDev, hbitmap, startscan,
lines,
                                            bits, info, coloruse );
    }

done:
    GDI_ReleaseObj( hbitmap );
    release_dc_ptr( dc );
    return result;
}

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #36 from BD   2010-01-11 20:28:26 ---
(In reply to comment #35)
> (In reply to comment #34)
> > (In reply to comment #33)
> > > (In reply to comment #32)
> > > > i dont see any corruption
> > >
> > > Black panel headers and black panel tab area.
> >
> > ok, i see that. sorry for wasting you all's time. good luck on getting it fixed
> > because its out of my league. ( i was having fun and learned a lot tho :)
> > thanks for the patience.
>
> i fixed it :)
>
> INT WINAPI SetDIBits( HDC hdc, HBITMAP hbitmap, UINT startscan,
>               UINT lines, LPCVOID bits, const BITMAPINFO *info,
>               UINT coloruse )
> {
>     DC *dc;
>     BITMAPOBJ *bitmap;
>     INT result = 0;
>     BOOL bDesktopDC = FALSE;
>  if (hdc == 0)
> {
>     hdc = CreateCompatibleDC(0);
>     bDesktopDC = TRUE;
> }
>
> if (!(dc = get_dc_ptr( hdc )))
>     return 0;
>
> update_dc( dc );
>
> if (!(bitmap = GDI_GetObjPtr( hbitmap, OBJ_BITMAP )))
> {
>     release_dc_ptr( dc );
>     return 0;
> }
>
> if (!bitmap->funcs && !BITMAP_SetOwnerDC( hbitmap, dc )) goto done;
>
> result = lines;
> if (bitmap->funcs)
> {
>     if (bitmap->funcs != dc->funcs)
>         ERR( "not supported: DDB bitmap %p not belonging to device %p\n",
>
> hbitmap, hdc );
>         else if (dc->funcs->pSetDIBits)
>             result = dc->funcs->pSetDIBits( dc->physDev, hbitmap, startscan,
> lines,
>                                             bits, info, coloruse );
>     }
>
> done:
>     GDI_ReleaseObj( hbitmap );
>     release_dc_ptr( dc );
>     return result;
> }

i added 2 release lines so complete code should be this:

INT WINAPI SetDIBits( HDC hdc, HBITMAP hbitmap, UINT startscan,
              UINT lines, LPCVOID bits, const BITMAPINFO *info,
              UINT coloruse )
{
    DC *dc;
    BITMAPOBJ *bitmap;
    INT result = 0;
    BOOL bDesktopDC = FALSE;

if (hdc == 0)
    {
        hdc = CreateCompatibleDC(0);
        bDesktopDC = TRUE;
    }

if (!(dc = get_dc_ptr( hdc )))
        return 0;

update_dc( dc );

if (!(bitmap = GDI_GetObjPtr( hbitmap, OBJ_BITMAP )))
    {
        release_dc_ptr( dc );
    if (hdc == 0) DeleteDC(hdc);
        return 0;
    }

if (!bitmap->funcs && !BITMAP_SetOwnerDC( hbitmap, dc )) goto done;

result = lines;
    if (bitmap->funcs)
    {
        if (bitmap->funcs != dc->funcs)
            ERR( "not supported: DDB bitmap %p not belonging to device %p\n",
hbitmap, hdc );
        else if (dc->funcs->pSetDIBits)
            result = dc->funcs->pSetDIBits( dc->physDev, hbitmap, startscan,
lines,
                                            bits, info, coloruse );
    }

done:
    GDI_ReleaseObj( hbitmap );
    release_dc_ptr( dc );
    if (hdc == 0) DeleteDC(hdc);
    return result;
}

please test and see if it all works ty

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #37 from Nikolay Sivov   2010-01-12 06:34:22 ---
(In reply to comment #36)

Stop pasting this please. If you want to show your patch attach in once, no
need to duplicate almost the same things.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #38 from BD   2010-01-23 20:14:37 ---
(In reply to comment #37)
> (In reply to comment #36)
>
> Stop pasting this please. If you want to show your patch attach in once, no
> need to duplicate almost the same things.

1.1.37 has been released and the above fix i posted was not added so patcher
icons are still broke until i apply the fix. is something wrong with the code?
it has been working great for me so far.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #39 from Vincent Povirk   2010-01-23 21:08:54 ---
Patches are not picked up from Bugzilla. See
http://wiki.winehq.org/SubmittingPatches

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #40 from BD   2010-01-24 14:13:06 ---
Created an attachment (id=25870)
 --> (http://bugs.winehq.org/attachment.cgi?id=25870)
diff file

here is the patch and if no problems in the next few days i will submit it.
thanks everyone for all the help.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #41 from Vincent Povirk   2010-01-24 14:56:43 ---
The diff should really only include the parts of the function you've changed.

Maybe you changed the line endings somehow?

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #42 from BD   2010-01-24 15:04:00 ---
(In reply to comment #41)
> The diff should really only include the parts of the function you've changed.
>
> Maybe you changed the line endings somehow?

i pasted the section from my patched file to the git file. i'll make a new
patch by just changing the individual lines. thanks for pointing that out.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #43 from BD   2010-01-24 15:41:15 ---
Created an attachment (id=25871)
 --> (http://bugs.winehq.org/attachment.cgi?id=25871)
dib.diff file

here is the patch. thanks again for the help :)

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #44 from Nikolay Sivov   2010-01-24 16:00:01 ---
(In reply to comment #43)
> Created an attachment (id=25871)

--> (http://bugs.winehq.org/attachment.cgi?id=25871) [details]
> dib.diff file
>
> here is the patch. thanks again for the help :)

---
+        bDesktopDC = TRUE;
---

What is it for? It's not used.

---
+        if (hdc == 0) DeleteDC(hdc);
---

What?

P.S. Please submit patch to mail list when you will be sure about it. Now it's
not a patch, with such mistakes.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #45 from BD   2010-01-24 17:47:24 ---
Created an attachment (id=25873)
 --> (http://bugs.winehq.org/attachment.cgi?id=25873)
dib.diff file

removed the unused lines. PWI patcher icons and vc++ still working.

ps. i wont mail anything until its a solid fix or you can submit it since you
started working the bug. im just trying to help what little i can to give back
to the wine community.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #46 from Vitaliy Margolen   2010-01-24 23:54:51 ---
You leaking hdc. You still have to delete if it was created.
Just add an additional HDC variable and assing "hdc" to it. And if it's 0
create one. Make sure you delete created DC on each return.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #47 from BD   2010-01-25 10:15:57 ---
Created an attachment (id=25884)
 --> (http://bugs.winehq.org/attachment.cgi?id=25884)
dib.diff

please check this patch for mistakes. if someone else wants to take over this
bug then please do because im out of ideas/know how on what else to do.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #48 from BD   2010-01-26 16:08:54 ---
Created an attachment (id=25903)
 --> (http://bugs.winehq.org/attachment.cgi?id=25903)
diff

i think this patch is correct. when i quit vc++ the memory shows it being
released as it should.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #49 from Jeff Zaroyko   2010-01-26 16:28:10 ---
(In reply to comment #48)
> Created an attachment (id=25903)

--> (http://bugs.winehq.org/attachment.cgi?id=25903) [details]
> diff
>
> i think this patch is correct. when i quit vc++ the memory shows it being
> released as it should.

dib.c: In function `SetDIBits':
dib.c:349: warning: comparison of distinct pointer types lacks a cast
dib.c:368: warning: comparison of distinct pointer types lacks a cast

Look at the warnings generated, you're comparing hdc with CreateCompatibleDC, a
function pointer.  This doesn't make sense.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #50 from Nikolay Sivov   2010-01-26 16:34:43 ---
(In reply to comment #48)
> Created an attachment (id=25903)

--> (http://bugs.winehq.org/attachment.cgi?id=25903) [details]
> diff
>
> i think this patch is correct.

No. What is this?

---
+        DeleteDC(0);
---

Actually a test required here to fix this regression.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #51 from BD   2010-01-26 17:39:50 ---
(In reply to comment #50)
> (In reply to comment #48)
> > Created an attachment (id=25903)

--> (http://bugs.winehq.org/attachment.cgi?id=25903) [details] [details]
> > diff
> >
> > i think this patch is correct.
>
> No. What is this?
> -
>    DeleteDC(0);
>
> Actually a test required here to fix this regression.

the DeleteDC(0); has me a bit confused. using DeleteDC(hdc); in the done:
section makes vc++ complain of not deleting a busy dc. as for the test do you
mean like an if statement for that section?

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #52 from BD   2010-01-26 22:09:46 ---
Created an attachment (id=25907)
 --> (http://bugs.winehq.org/attachment.cgi?id=25907)
new diff

changed coloruse to hdc and everything works. hopefully this is ok.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #53 from BD   2010-01-26 22:20:38 ---
(In reply to comment #52)
> Created an attachment (id=25907)

--> (http://bugs.winehq.org/attachment.cgi?id=25907) [details]
> new diff
>
> changed coloruse to hdc and everything works. hopefully this is ok.

nevermind on the last post. found a problem.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #54 from BD   2010-01-26 22:49:15 ---
(In reply to comment #53)
> (In reply to comment #52)
> > Created an attachment (id=25907)

--> (http://bugs.winehq.org/attachment.cgi?id=25907) [details] [details]
> > new diff
> >
> > changed coloruse to hdc and everything works. hopefully this is ok.
>
> nevermind on the last post. found a problem.

my bad, everything is working as normal using hdc instead of coloruse. sorry
for posting so much i just want to get this fixed because its bugging me :D

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #55 from BD   2010-01-27 23:01:41 ---
Created an attachment (id=25913)
 --> (http://bugs.winehq.org/attachment.cgi?id=25913)
dib.diff

ok then, im most comfortable with this last patch. im going to use it until a
final fix is done by someone. as far as the coloruse goes,, in version 1.1.31
has this:  if (coloruse == DIB_RGB_COLORS) FIXME( "shouldn't require a DC for
DIB_RGB_COLORS\n" );  so i'll use my last patch here and let the pros handle it
from now on. G'luck and happy coding/gaming!

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #56 from Wylda   2010-02-27 17:48:41 ---

Still not fixed in wine-1.1.39-163-g583f0f0.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #57 from BD   2010-03-17 11:57:22 ---
(In reply to comment #56)
> Still not fixed in wine-1.1.39-163-g583f0f0.

new update for perfect world redone the patcher window and now everything works
so problem is now solved.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #58 from Eli Wapniarski   2010-03-18 01:10:58 ---
Confirmed.... I wouldn't say that is was solved though.... Just us PWI users
can not longer provide meaningful feedback regarding the underlying problem. :(

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #59 from Wylda   2010-04-11 00:05:58 ---
(In reply to comment #58)
> Confirmed.... I wouldn't say that is was solved though.... Just us PWI users
> can not longer provide meaningful feedback regarding the underlying problem. :(

No problem for me :) When i install PWI, then won't patcher get updated
(disconnect from internet or shutdown the interface) i still can provide
feedback like now:

This regression (bisected) is still present in wine-1.1.42-182-g8f77dd8.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #60 from Eli Wapniarski   2010-04-11 03:31:52 ---
I have absolutely no problem with the patcher. However, you could do a manual
patch and see if that works.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #61 from Wylda   2010-04-11 03:36:54 ---
(In reply to comment #60)
> I have absolutely no problem with the patcher. However, you could do a manual
> patch and see if that works.

And that's what i do not want to do. I want the old version of patcher, because
it shows the bug. And that was interests me :) Not the game, but that bug.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25870|0                           |1
        is obsolete|                            |

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25871|0                           |1
        is obsolete|                            |

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25913|0                           |1
        is obsolete|                            |

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25907|0                           |1
        is obsolete|                            |

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25903|0                           |1
        is obsolete|                            |

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25884|0                           |1
        is obsolete|                            |

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25873|0                           |1
        is obsolete|                            |

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #62 from Nikolay Sivov   2010-04-12 10:16:03 ---
Test with current git please. Commit 352e2ff6eb5116d2ac91db9258ae288733e3a271
should help.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #63 from Wylda   2010-04-14 23:45:41 ---

Confirming, FIXED in wine-1.1.42-310-g0bc218b.

Particular commit (wine-1.1.42-201-g352e2ff):
http://source.winehq.org/git/wine.git/?a=commit;h=352e2ff6eb5116d2ac91db9258...

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #64 from Dmitry Timoshkov   2010-04-14 23:59:36 ---
Reported fixed.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

--- Comment #65 from Eli Wapniarski   2010-04-15 00:34:16 ---
I will be making an attempt to test the fix in about 1/2 to 1 weeks time as I
will have oportunity to reinstall the game on a new comptuer. Hopefully the
installer will contain the old patcher.

[Bug 20598] Elements Do Not Appear in Patcher Dialogue Box in Perfectworld International

http://bugs.winehq.org/show_bug.cgi?id=20598

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #66 from Alexandre Julliard   2010-04-16 13:02:48 ---
Closing bugs fixed in 1.1.43.