[Bug 15394] New: Incorrect menu behaviour when only a item is present (rare)

http://bugs.winehq.org/show_bug.cgi?id=15394

Summary: Incorrect menu behaviour when only a item is present
                    (rare)
           Product: WineHQ Bugzilla
           Version: unspecified
          Platform: Other
        OS/Version: other
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P3
         Component: bugzilla-unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Hi.

If a Windows program has a menu as the following:

-_File - -_Search- -_?-
_Quit              _About

where '_Search' is used to call a dialog window, and if the user press ALT + S
keys, then Windows (since version 3.1 I think) opens directly the related
dialog, instead using WINE you have to press Return to call the function
because ALT + S select only the menu.

Thanks.

[Bug 15394] Incorrect menu behaviour when only a item is present (rare)

http://bugs.winehq.org/show_bug.cgi?id=15394

--- Comment #1 from Austin English   2008-09-24 09:43:23 ---
A testcase would be useful.

[Bug 15394] Incorrect menu behaviour when only a item is present (rare)

http://bugs.winehq.org/show_bug.cgi?id=15394

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|bugzilla-unknown            |user32
            Product|WineHQ Bugzilla             |Wine

--- Comment #2 from Lei Zhang   2008-09-28 19:25:42 ---
The product field is Wine.

[Bug 15394] Incorrect menu behaviour when only a item is present (rare)

http://bugs.winehq.org/show_bug.cgi?id=15394

--- Comment #3 from Austin English   2009-03-30 13:26:40 ---
Is this still an issue in current (1.1.18 or newer) wine?

[Bug 15394] Incorrect menu behaviour when only a item is present (rare)

http://bugs.winehq.org/show_bug.cgi?id=15394

--- Comment #4 from Francesco Cosoleto   2009-03-30 15:27:48 ---
(In reply to comment #3)
> Is this still an issue in current (1.1.18 or newer) wine?

Yes, unchanged.

I am not sure my description is good enough. Is it so?

[Bug 15394] Incorrect menu behaviour when only a item is present (rare)

http://bugs.winehq.org/show_bug.cgi?id=15394

--- Comment #5 from Austin English   2009-03-30 17:03:33 ---
(In reply to comment #4)
> (In reply to comment #3)
> > Is this still an issue in current (1.1.18 or newer) wine?
>
> Yes, unchanged.
>
> I am not sure my description is good enough. Is it so?

A small testcase (source and binary) or a link to a program showing the problem
would help.

[Bug 15394] Incorrect menu behaviour when only a item is present (rare)

http://bugs.winehq.org/show_bug.cgi?id=15394

--- Comment #6 from Francesco Cosoleto   2009-04-01 22:37:10 ---
(In reply to comment #5)
> A small testcase (source and binary) or a link to a program showing the problem
> would help.

Writing a testcase requires a minimal of familiarity with WIN16 API, I have
tried but failed...

Here a link to the program that shows the problem:
http://cosoleto.free.fr/wine_sample.zip

It's dictionary created with "Personal Library Software" (licensed as freeware
some years ago). I have removed all the copyrighted material, so the program is
only a useless skeleton.

To reproduce the problem:
1) Run Devwin.exe
2) Press Alt + R

On Windows, it opens a dialog window.
On Wine, it highlights the "&Ricerca" menu.

Francesco Cosoleto

[Bug 15394] Incorrect menu behaviour when only a item is present (rare)

http://bugs.winehq.org/show_bug.cgi?id=15394

--- Comment #7 from Austin English   2009-04-02 10:50:00 ---
(In reply to comment #6)
> (In reply to comment #5)
> > A small testcase (source and binary) or a link to a program showing the problem
> > would help.
>
> Writing a testcase requires a minimal of familiarity with WIN16 API, I have
> tried but failed...
>
> Here a link to the program that shows the problem:
> http://cosoleto.free.fr/wine_sample.zip

Doesn't work here, says it can't read drive D:.

[Bug 15394] Incorrect menu behaviour when only a item is present (rare)

http://bugs.winehq.org/show_bug.cgi?id=15394

--- Comment #8 from Francesco Cosoleto   2009-04-02 11:29:28 ---
(In reply to comment #7)
> Doesn't work here, says it can't read drive D:.

Sorry, I have forgot to edit the file "pldbs.dat" that should be:

dizi            C:\Devoto-Oli\vocab\dizio

not "D:\App\DEVOTO~1...", nor "C:\DEVOTO~1..." as it isn't working too.

[Bug 15394] Incorrect menu behaviour when only a item is present

http://bugs.winehq.org/show_bug.cgi?id=15394

Francesco Cosoleto  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor
            Summary|Incorrect menu behaviour    |Incorrect menu behaviour
                   |when only a item is present |when only a item is present
                   |(rare)                      |

--- Comment #9 from Francesco Cosoleto   2009-04-05 10:13:13 ---
Reproduced?

[Bug 15394] Incorrect menu behaviour when only a item is present

http://bugs.winehq.org/show_bug.cgi?id=15394

Alexander Scott-Johns  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexander.scott.johns+winebu
                   |                            |[e-mail]

--- Comment #10 from Alexander Scott-Johns   2009-04-06 16:01:57 ---
(In reply to comment #9)
> Reproduced?

I managed to reproduce this bug with a small test program I wrote. The Deal!
menu item in Spider Solitaire is also affected.

Interestingly, if you press Alt and S at the same time, Wine just highlights
Search, but if you type Alt, release it, and then type S, the Search window
activates. In Windows, both of these actions make the Search window activate.

[Bug 15394] Incorrect menu behaviour when only a item is present

http://bugs.winehq.org/show_bug.cgi?id=15394

--- Comment #11 from Alexander Scott-Johns   2009-04-06 16:04:11 ---
Created an attachment (id=20319)
 --> (http://bugs.winehq.org/attachment.cgi?id=20319)
Small menu testing app

Resource for menu:

MAIN_MENU MENU
{
    POPUP "&File" {
        MENUITEM "&Save", CMD_SAVE
        MENUITEM "E&xit\tAlt+F4", CMD_EXIT
    }
    MENUITEM "&Search", CMD_SEARCH
    MENUITEM "&Query", CMD_QUERY
    POPUP "&Help" {
        MENUITEM "&About", CMD_ABOUT
    }
    MENUITEM "&Quit", CMD_QUIT
}

[Bug 15394] Incorrect menu behaviour when only a item is present

http://bugs.winehq.org/show_bug.cgi?id=15394

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, source

[Bug 15394] Incorrect menu behaviour when only a item is present

http://bugs.winehq.org/show_bug.cgi?id=15394

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #12 from Austin English   2010-08-26 12:34:39 ---
(In reply to comment #11)
> Created an attachment (id=20319)

--> (http://bugs.winehq.org/attachment.cgi?id=20319) [details]
> Small menu testing app
>
> Resource for menu:
>
> MAIN_MENU MENU
> {
>     POPUP "&File" {
>         MENUITEM "&Save", CMD_SAVE
>         MENUITEM "E&xit\tAlt+F4", CMD_EXIT
>     }
>     MENUITEM "&Search", CMD_SEARCH
>     MENUITEM "&Query", CMD_QUERY
>     POPUP "&Help" {
>         MENUITEM "&About", CMD_ABOUT
>     }
>     MENUITEM "&Quit", CMD_QUIT
> }

Still present in wine-1.3.1-182-g56b8d5d.

[Bug 15394] Incorrect menu behaviour when only a item is present

http://bugs.winehq.org/show_bug.cgi?id=15394

David  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #13 from David  2011-03-29 09:23:16 CDT ---
Seems to be working on Spider Solitaire (for Windows XP) when you press the
"Deal", which is a single item menu.  I'm using Wine version 1.3.16 as of this
writing.

[Bug 15394] Activating a single item menu using a hotkey doesn't execute the menu item command

http://bugs.winehq.org/show_bug.cgi?id=15394

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Incorrect menu behaviour    |Activating a single item
                   |when only a item is present |menu using a hotkey doesn't
                   |                            |execute the menu item
                   |                            |command

--- Comment #14 from Dmitry Timoshkov  2011-04-06 00:18:03 CDT ---
Changing the summary to be more verbose, and better describe the problem.

[Bug 15394] Activating a single item menu using a hotkey doesn't execute the menu item command

http://bugs.winehq.org/show_bug.cgi?id=15394

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #15 from Jerome Leclanche  2011-04-06 13:06:14 CDT ---
Test committed as 444b781ff39605223786a9aa34ae15c6b3f3151f

[Bug 15394] Activating a single item menu using a hotkey doesn't execute the menu item command

http://bugs.winehq.org/show_bug.cgi?id=15394

--- Comment #16 from Dmitry Timoshkov  2011-04-12 05:09:37 CDT ---
The following patch should fix the problem:
http://www.winehq.org/pipermail/wine-patches/2011-April/100836.html

[Bug 15394] Activating a single item menu using a hotkey doesn't execute the menu item command

http://bugs.winehq.org/show_bug.cgi?id=15394

--- Comment #17 from Austin English  2011-04-12 11:51:28 CDT ---
(In reply to comment #16)
> The following patch should fix the problem:
> http://www.winehq.org/pipermail/wine-patches/2011-April/100836.html

Committed:
http://source.winehq.org/git/wine.git/commitdiff/629f382a80efe35f3f48c41b4a1...

please retest.

[Bug 15394] Activating a single item menu using a hotkey doesn't execute the menu item command

http://bugs.winehq.org/show_bug.cgi?id=15394

--- Comment #18 from Francesco Cosoleto  2011-04-12 18:56:30 CDT ---
I can't run 16 bit applications just now, but this patch works with the small
one uploaded by Alexander Scott-Johns.

In case you wish test with a 16 bit application:

cd $HOME/.wine/drive_c/
wget http://cosoleto.free.fr/wine_sample.zip
unzip wine_sample.zip
cd Devoto-Oli
wine Devwin.exe

then press ALT + R

Thanks for fixing this bug.

[Bug 15394] Activating a single item menu using a hotkey doesn't execute the menu item command

http://bugs.winehq.org/show_bug.cgi?id=15394

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #19 from Dmitry Timoshkov  2011-04-13 00:42:58 CDT ---
Should be fixed now.

[Bug 15394] Activating a single item menu using a hotkey doesn't execute the menu item command

http://bugs.winehq.org/show_bug.cgi?id=15394

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #20 from Alexandre Julliard  2011-04-15 12:51:17 CDT ---
Closing bugs fixed in 1.3.18.

[Bug 15394] Activating a single item menu using a hotkey doesn't execute the menu item command

http://bugs.winehq.org/show_bug.cgi?id=15394

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |629f382a80efe35f3f48c41b4a1
                   |                            |aff0fecce8977