[Bug 48991] New: Riot Vanguard (Riot Games) fails to install due to 'xcopy' unhandled parameter '/G'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48991

Bug ID: 48991
           Summary: Riot Vanguard (Riot Games) fails to install due to
                    'xcopy' unhandled parameter '/G'
           Product: Wine
           Version: 5.6
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: programs
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Hello folks,

as it says. The game client reports the sub-installer failing with invalid exit
code 10040.

Snapshot via Internet Archive:

https://web.archive.org/web/20200420204157/https://valorant.secure.dyn.riotc...

--- snip ---
...
000010.958|   OKAY| Successfully downloaded third-party dependency
'https://riot-client.secure.dyn.riotcdn.net/channels/public/rccontent/vanguar...'
000010.984|   OKAY| Successfully verified third-party dependency installer
'setup.exe'
000024.927| ALWAYS| Removing entries in directory: C:/ProgramData/Riot
Games/Metadata/vanguard
000024.931|  ERROR| Unable to run installation: Process exited with invalid
exit code 10040
--- snip ---

--- snip ---
$ WINEDEBUG=+seh,+relay,+xcopy wine ./setup.exe >>log.txt 2>&1
...
002c:Call KERNEL32.CreateProcessW(00000000,0032ea68
L""C:\users\focht\Temp\7zC0F7402B\uninstall.exe"",00000000,00000000,00000000,00000000,00000000,00000000,0032fdc0,0032fe64)
ret=0040a3c3 
...
002c:Ret  KERNEL32.CreateProcessW() retval=00000001 ret=0040a3c3
...
002e:Call KERNEL32.CreateProcessW(00000000,0136f190
L""C:\users\focht\Temp\7zC0F7402B\vgc.exe"",00000000,00000000,00000000,00000000,00000000,00000000,0022f830,0022f7a8)
ret=00b073a1 
...
002e:Ret  KERNEL32.CreateProcessW() retval=00000001 ret=00b073a1 
...
0030:Call KERNEL32.CreateProcessW(00000000,011b8060
L""C:\windows\system32\cmd.exe" /d /c
""C:\windows\system32\timeout.exe" /NOBREAK /T 0 &&
"C:\windows\system32\xcopy.exe" /I /E /C /G /H /R /Y
"C:\users\focht\Temp\7zC0F7402B\*" "C:\Program Files\Riot
Vanguard""",00000000,00000000,00000000,00000410,00000000,00000000,0022d100,0022d0e0)
ret=7f239280e73f 
...
0030:Ret  KERNEL32.CreateProcessW() retval=00000001 ret=7f239280e73f 
...
0038:Call KERNEL32.CreateProcessW(00222290
L"C:\windows\system32\\xcopy.exe",00ea9590
L""C:\windows\system32\xcopy.exe" /I /E /C /G /H /R /Y
"C:\users\focht\Temp\7zC0F7402B\*" "C:\Program Files\Riot
Vanguard"",00000000,00000000,00000001,7ffb00000000,00000000,00000000,002221c0,00222228)
ret=140012d31 
...
0038:Ret  KERNEL32.CreateProcessW() retval=00000001 ret=140012d31 
...
0063:trace:xcopy:XCOPY_ParseCommandLine Processing Arg: 'L"/E"'
0063:trace:xcopy:XCOPY_ParseCommandLine Processing Arg: 'L"/C"'
0063:trace:xcopy:XCOPY_ParseCommandLine Processing Arg: 'L"/G"'
0063:trace:xcopy:XCOPY_ParseCommandLine Unhandled parameter 'L"/G"'
0063:trace:xcopy:XCOPY_wprintf Writing to console? (1)
0063:trace:xcopy:wmain Supplied parameters:
0063:trace:xcopy:wmain Source      : 'L""'
0063:trace:xcopy:wmain Destination : 'L""'
0063:fixme:xcopy:XCOPY_ProcessSourceParm Unexpected failure expanding source
path (0)
...
--- snip ---

Microsoft docs:

https://docs.microsoft.com/en-us/windows-server/administration/windows-comma...

Better docs:

https://ss64.com/nt/xcopy.html

--- snip ---
/G    Allow the copying of encrypted files to a destination that does not
support encryption.
--- snip ---

$ sha1sum setup.exe 
08deca4c0b46a3481e706926c0217d1c944d22a3  setup.exe

$ du -sh setup.exe 
15M    setup.exe

$ wine --version
wine-5.6-258-gf31a29b8d1

Regards

[Bug 48991] Riot Vanguard (Riot Games) fails to install due to 'xcopy' unhandled parameter '/G'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48991

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://web.archive.org/web
                   |                            |/20200420204157/https://val
                   |                            |orant.secure.dyn.riotcdn.ne
                   |                            |t/channels/public/x/install
                   |                            |er/current/live.live.eu.exe
           Keywords|                            |download, Installer

--- Comment #1 from Anastasius Focht  ---
Hello folks,

adding now proper checksums for the bootstrapper/client. The previous one was
for Vanguard sub-installer. The client will auto-update itself.

$ sha1sum Install\ VALORANT.exe 
92c28e21122d5272deba5d826c161def55934c91  Install VALORANT.exe

$ du -sh Install\ VALORANT.exe 
66M    Install VALORANT.exe

The content of Vanguard installer which can be run standalone after sneaking
the download link from client logs:

--- snip ---
$ 7z l setup.exe

...
Scanning the drive for archives:
1 file, 14791120 bytes (15 MiB)

Listing archive: setup.exe

--
Path = setup.exe
Type = PE
Physical Size = 14791120
CPU = x86
Characteristics = Executable 32-bit
Created = 2020-03-30 22:47:44
Headers Size = 1024
Checksum = 14802522
Name = setup.exe
Image Size = 389120
Section Alignment = 4096
File Alignment = 512
Code Size = 294400
Initialized Data Size = 85504
Uninitialized Data Size = 0
Linker Version = 14.24
OS Version = 6.0
Image Version = 0.0
Subsystem Version = 6.0
Subsystem = Windows GUI
DLL Characteristics = Relocated NX-Compatible TerminalServerAware
Stack Reserve = 1048576
Stack Commit = 4096
Heap Reserve = 1048576
Heap Commit = 4096
Image Base = 4194304
Comment = FileVersion: 1.0.0.0
ProductVersion: 1.0.0.0
CompanyName: Riot Games, Inc.
FileDescription: Vanguard installer.
InternalName: setup.exe
LegalCopyright: Copyright (C) 2020
OriginalFilename: setup.exe
ProductName: Vanguard Installer
----
Path = [0]
Size = 14416240
Packed Size = 14416240
Virtual Size = 14416240
Offset = 367616
--
Path = [0]
Type = 7z
Offset = 111
Physical Size = 14416128
Tail Size = 1
Headers Size = 267
Method = LZMA2:24 BCJ
Solid = +
Blocks = 2

Date      Time    Attr         Size   Compressed  Name
------------------- ----- ------------ ------------  ------------------------
2020-03-14 01:20:09 ....A        21651         6298  vgc.ico
2020-04-18 05:03:08 ....A       152328     14409563  uninstall.exe
2020-04-18 05:04:58 ....A      9620768               vgc.exe
2020-04-18 05:25:33 ....A      3196560               vgk.sys
2020-04-18 05:03:04 ....A      3283840               vgrl.dll
------------------- ----- ------------ ------------  ------------------------
2020-04-18 05:25:33           16275147     14415861  5 files
--- snip ---

Regards

[Bug 48991] Riot Vanguard (Riot Games) fails to install due to 'xcopy' unhandled parameter '/G'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48991

Ker noa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 48991] Riot Vanguard (Riot Games) fails to install due to 'xcopy' unhandled parameter '/G'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48991

--- Comment #2 from Anastasius Focht  ---
Hello folks,

revisiting, still present.

$ wine --version
wine-6.20-61-gababea0fd70

Regards

[Bug 48991] Riot Vanguard (Riot Games) fails to install due to 'xcopy' unhandled parameter '/G'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48991

Tareque Md Hanif  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Tareque Md Hanif  ---
The latest setup.exe doesn't show any issue. The files probably are copied to
the correct location.

❯ ls drive_c/Program\ Files/Riot\ Vanguard/ -la
.rwxr-xr-x 156k tareque 30 Nov  2021 installer.exe
.rwxr-xr-x 3.2M tareque 30 Nov  2021 log-uploader.exe
drwxr-xr-x    - tareque  1 Feb 22:06 Logs
.rwxr-xr-x  10M tareque 30 Nov  2021 vgc.exe
.rw-r--r--  22k tareque 30 Nov  2021 vgc.ico
.rw-r--r-- 8.5M tareque 30 Nov  2021 vgk.sys
.rw-r--r-- 3.3M tareque 30 Nov  2021 vgrl.dll
.rwxr-xr-x 3.2M tareque 30 Nov  2021 vgtray.exe

[Bug 48991] Riot Vanguard (Riot Games) v0.3.2.2 installer fails due to 'xcopy' unhandled parameter '/G'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48991

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Riot Vanguard (Riot Games)  |Riot Vanguard (Riot Games)
                   |fails to install due to     |v0.3.2.2 installer fails
                   |'xcopy' unhandled parameter |due to 'xcopy' unhandled
                   |'/G'                        |parameter '/G'
                URL|https://web.archive.org/web |https://web.archive.org/web
                   |/20200420204157/https://val |/20200421165713/https://rio
                   |orant.secure.dyn.riotcdn.ne |t-client.secure.dyn.riotcdn
                   |t/channels/public/x/install |.net/channels/public/rccont
                   |er/current/live.live.eu.exe |ent/vanguard/0.3.2.2/setup.
                   |                            |exe

--- Comment #4 from Anastasius Focht  ---
Hello Tareque,

--- quote ---
The latest setup.exe doesn't show any issue. The files probably are copied to
the correct location.
--- quote ---

thanks for the update. Indeed, it seems the Riot Vanguard installers use
"builtin" copy for quite a while. It changed around v1.0 or a bit earlier.

Most recent Vanguard installer for testing as of today 2022-02-06:

'drive_c/users/focht/Local\ Settings/Application\ Data/Riot\ Games/Riot\
Client/Logs/Riot\ Client\ Logs/2022-02-06T19-36-41_732_Riot\ Client.log':

--- snip ---
000011.027|   OKAY| agent: ThirdPartyJob: Successfully downloaded third-party
dependency
'https://riot-client.secure.dyn.riotcdn.net/channels/public/rccontent/vanguar...'
--- snip ---

--- snip ---
$ WINEDEBUG=+seh,+relay wine ./setup.exe >>log.txt 2>&1
...
013c:Call KERNEL32.CreateFileW(0032f6fc
L"C:\users\focht\Temp\7z304FF138\vgc.exe",40000000,00000001,00000000,00000002,00000080,00000000)
ret=0040504e
...
013c:Ret  KERNEL32.CreateFileW() retval=00000064 ret=0040504e
...
013c:Call KERNEL32.CreateFileW(0032f6fc
L"C:\users\focht\Temp\7z304FF138\vgk.sys",40000000,00000001,00000000,00000002,00000080,00000000)
ret=0040504e
...
013c:Ret  KERNEL32.CreateFileW() retval=00000064 ret=0040504e
...
013c:Call KERNEL32.CreateProcessW(00000000,0032ea40
L""C:\users\focht\Temp\7z304FF138\installer.exe"",00000000,00000000,00000000,00000000,00000000,00000000,0032fd98,0032fe3c)
ret=0040a3c3
...
013c:Ret  KERNEL32.CreateProcessW() retval=00000001 ret=0040a3c3
...
014c:Call KERNEL32.CreateProcessW(00000000,001a7610
L""C:\users\focht\Temp\7z304FF138\vgc.exe"",00000000,00000000,00000000,ffffffff00000000,00000000,00000000,0011fa90,0011fa00)
ret=013bc1cc
...
014c:Ret  KERNEL32.CreateProcessW() retval=00000001 ret=013bc1cc
...
0154:Call KERNEL32.CopyFileW(001f7550
L"C:\users\focht\Temp\7z304FF138\vgc.exe",001f9f70 L"C:\Program
Files\Riot Vanguard\vgc.exe",00000000) ret=1402d8bb4
...
0154:Ret  KERNEL32.CopyFileW() retval=00000001 ret=1402d8bb4
...
--- snip ---

Created archive.org snapshot just for reference:

https://web.archive.org/web/20220206185118/https://riot-client.secure.dyn.ri...

https://www.virustotal.com/gui/file/590702552e0e5f20e7991284ffe685bb926282be...

$ sha1sum setup.exe 
60e2380436f770b0912c37cd63a8787c91aaef28  setup.exe

$ du -sh setup.exe 
22M    setup.exe

---

Adjusting fields since the problem can be still reproduced with older archived
installers.

https://web.archive.org/web/20200421165713/https://riot-client.secure.dyn.ri...

https://www.virustotal.com/gui/file/4a32d5f82cb72b86f536cfde36c86e5c7a3cd118...

$ sha1sum setup.exe 
a4ea6c3ca3eaf18cf9ea3fa8c0725f94af4c28f2  setup.exe

$ du -sh setup.exe 
15M    setup.exe

$ wine --version
wine-7.1-288-g4364ff8d5c0

Regards