[Bug 52116] New: World of Warships: garbled textures and GL_INVALID_OPERATION errors due to invalid PBO access

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52116

Bug ID: 52116
           Summary: World of Warships: garbled textures and
                    GL_INVALID_OPERATION errors due to invalid PBO access
           Product: Wine
           Version: 6.22
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: bb285f56f9ca843c58ee37328027c9611f2587d0
      Distribution: ---

World of Warships has graphical artifacts: (seemingly random) textures turn
into weird colors and stay that way until game restart. This makes for an over
time increasingly psychedelic game experience. ;)
The console log spits out the following message from time to time (with varying
hexvalues):
0430:err:d3d:wined3d_debug_callback 0x245380: "GL_INVALID_OPERATION in
glCompressedTexSubImage2D(invalid PBO access)".

Reverting commit bb285f56f9ca843c58ee37328027c9611f2587d0 "wined3d: Avoid
stalling the pipeline on 3D blits." fixes both.

re-tested with current git head wine (67d0509f2f5), running Mesa 21.2.5 on
amdgpu.
Please holler if you need more info.

[Bug 52116] World of Warships: garbled textures and GL_INVALID_OPERATION errors due to invalid PBO access

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52116

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression
          Component|-unknown                    |directx-d3d
                URL|                            |https://worldofwarships.eu/

[Bug 52116] World of Warships: garbled textures and GL_INVALID_OPERATION errors due to invalid PBO access

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52116

--- Comment #1 from Jan Sikorski  ---
Created attachment 71170
  --> https://bugs.winehq.org/attachment.cgi?id=71170
Proposed fix

Looks like we don't always unbind buffers after using them, so we need to make
sure nothing is bound to GL_PIXEL_UNPACK_BUFFER before copying data from system
memory. Attached patch should fix the issue.

[Bug 52116] World of Warships: garbled textures and GL_INVALID_OPERATION errors due to invalid PBO access

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52116

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from [e-mail] ---
I get the same issue in Roblox in Direct3D mode (without DXVK)

Luckily I just saw a patch in the mailing list which should fix this ????

[Bug 52116] World of Warships: garbled textures and GL_INVALID_OPERATION errors due to invalid PBO access

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52116

--- Comment #3 from Jan Braun  ---
That patch fixes it for me. Thanks for the fast turnaround!

[Bug 52116] World of Warships: garbled textures and GL_INVALID_OPERATION errors due to invalid PBO access

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52116

Matteo Bruni  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED
      Fixed by SHA1|                            |d2ceed3904b96576ccb370f196b
                   |                            |f6fe6d77b3537

--- Comment #4 from Matteo Bruni  ---
Reported fixed.

[Bug 52116] World of Warships: garbled textures and GL_INVALID_OPERATION errors due to invalid PBO access

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52116

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 7.0-rc1.