[Bug 52175] New: advapi32:lsa fails because "Everyone" is not translated

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52175

Bug ID: 52175
           Summary: advapi32:lsa fails because "Everyone" is not
                    translated
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: advapi32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

advapi32:lsa fails in French and German in Wine:

lsa.c:407: Test failed: expected L"Tout le monde", got L"Everyone"
and
lsa.c:405: Test failed: expected L"Jeder", got L"Everyone"

https://test.winehq.org/data/patterns.html#advapi32:lsa

The reason is that Wine does not translate the "Everyone" group name.

Note that the French failure may be masked by another Wine bug: the string
returned by GetSystemPreferredUILanguages() is in lowercase instead of being in
uppercase like on Windows. This causes the advapi32:lsa to skip the translation
check when running in French in Wine.

[Bug 52175] advapi32:lsa fails because "Everyone" is not translated

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52175

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |source, testcase

[Bug 52175] advapi32:lsa fails because "Everyone" is not translated

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52175

--- Comment #1 from François Gouget  ---
Notes:
* The test was added in e291fb4dc9ee and initially assumed the group name was
never translated. That commit also does not mention whether the test was added
for a specific Windows application.
* This caused failures and I expanded the test to show that the group name is
translated in some locales, specifically French and German.
* Nikolay Sivov suggested removing the test entirely.
* I would prefer to keep it since it shows that Wine does not match Windows.
* But then, since the group name is sometimes translated and sometimes not,
maybe Windows applications cannot assume they know the group name, so that
whether Wine matches Windows or not does not matter much. Then it could make
sense to remove the test entirely (or keep only the name check in English).

[Bug 52175] advapi32:lsa fails because "Everyone" is not translated

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52175

--- Comment #2 from François Gouget  ---
The test is no longer failing because it has been marked as a todo.
But this is either papering over an invalid test, or Wine's localization needs
fixing.