[Bug 53240] New: dinput:device8 - test_sys_mouse() has some rare failures on the TestBot VMs

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53240

Bug ID: 53240
           Summary: dinput:device8 - test_sys_mouse() has some rare
                    failures on the TestBot VMs
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: directx-dinput
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

dinput:device8 - test_sys_mouse() has some rare failures on the TestBot VMs.
They can take two forms:

device8.c:1988: Test failed: 0x700: Acquire returned 0x80070005
device8.c:1997: Test failed: 0x700: WaitForSingleObject returned 0x102
device8.c:2002: Test failed: 0x700: got count 0
device8.c:2006: Test failed: 0x700: WaitForSingleObject returned 0x102
device8.c:2009: Test failed: 0x700: Unacquire returned 0x1
device8.c:2013: Test failed: 0x700: got count 0
device8.c:2016: Test failed: 0x700: Acquire returned 0x80070005
device8.c:2025: Test failed: 0x700: WaitForSingleObject returned 0x102
device8.c:2028: Test failed: 0x700: Unacquire returned 0x1
device8.c:2031: Test failed: 0x700: Acquire returned 0x80070005
device8.c:2035: Test failed: 0x700: got count 0
device8.c:2044: Test failed: 0x700: WaitForSingleObject returned 0x102
device8.c:2050: Test failed: 0x700: WaitForSingleObject returned 0x102
device8.c:2050: Test failed: 0x700: WaitForSingleObject returned 0x102
device8.c:2059: Test failed: 0x700: got count 0

or

device8.c:1988: Test failed: 0x800: Acquire returned 0x80070005
device8.c:1997: Test failed: 0x800: WaitForSingleObject returned 0x102
device8.c:2001: Test failed: 0x800: GetDeviceData returned 0x8007000c
device8.c:2006: Test failed: 0x800: WaitForSingleObject returned 0x102
device8.c:2009: Test failed: 0x800: Unacquire returned 0x1
device8.c:2016: Test failed: 0x800: Acquire returned 0x80070005
device8.c:2025: Test failed: 0x800: WaitForSingleObject returned 0x102
device8.c:2028: Test failed: 0x800: Unacquire returned 0x1
device8.c:2031: Test failed: 0x800: Acquire returned 0x80070005
device8.c:2034: Test failed: 0x800: GetDeviceData returned 0x8007000c
device8.c:2044: Test failed: 0x800: WaitForSingleObject returned 0x102
device8.c:2050: Test failed: 0x800: WaitForSingleObject returned 0x102
device8.c:2050: Test failed: 0x800: WaitForSingleObject returned 0x102
device8.c:2055: Test failed: 0x800: GetDeviceData returned 0x8007000c
device8.c:2058: Test failed: 0x800: GetDeviceData returned 0x8007000c

https://test.winehq.org/data/patterns.html#dinput:device8

So far they have only happened on the Debian 11 VMs and the first known
instance was on 2022-06-14.

[Bug 53240] dinput:device8 - test_sys_mouse() has some rare failures on the TestBot VMs

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53240

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |source, testcase

[Bug 53240] dinput:device8 - test_sys_mouse() has some rare failures on the TestBot VMs

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53240

Rémi Bernon  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Rémi Bernon  ---
I believe that this may be caused by window activation race conditions. The
test creates a temporary window to check for IDirectInputDevice8_Acquire
failure when foreground is lost, and then tries to restore the previous active
window, but that may race with X11 events from the temporary window creation,
which are sometimes processed after the SetActiveWindow call. Maybe getting rid
of the temporary window as soon as possible will help.

[Bug 53240] dinput:device8 - test_sys_mouse() has some rare failures on the TestBot VMs

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53240

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |2020541b4b42c4534335bdc0520
                   |                            |d63ce53d880c5

--- Comment #2 from François Gouget  ---
This got fixed on 2022-07-07 by the commit below:

commit 2020541b4b42c4534335bdc0520d63ce53d880c5
Author: Rémi Bernon 
Date:   Thu Jul 7 08:47:39 2022 +0200

dinput/tests: Avoid window activation race conditions with Wine.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53240
    Signed-off-by: Rémi Bernon

[Bug 53240] dinput:device8 - test_sys_mouse() has some rare failures on the TestBot VMs

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53240

--- Comment #3 from François Gouget  ---
Note: We still have the following message:

device8.c:2037: Test marked flaky: 0x800: GetDeviceData returned 0x8007000c

But was it was marked flaky by the commit below and it does not come with the
rest of this set of failures. So I'm still going to consider this bug as fixed
(also flaky failures are supposed to not fixable).

commit 48f99c41455dd1b7727bcc82e07e24428820465b
Author: Alexandre Julliard 
Date:   Mon Sep 26 19:59:14 2022 +0200

dinput/tests: Mark a mouse input test as flaky.

[Bug 53240] dinput:device8 - test_sys_mouse() has some rare failures on the TestBot VMs

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53240

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 8.0-rc1.