[Bug 31506] New: quartz video window isn't fullscreen in fullscreen apps

http://bugs.winehq.org/show_bug.cgi?id=31506

Bug #: 31506
           Summary: quartz video window isn't fullscreen in fullscreen
                    apps
           Product: Wine
           Version: 1.5.2
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: quartz
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified
   Regression SHA1: 75300a7e32e198368893d06b7d6088850c614fe4

Tested on GTAVC, GTA3 and GTASA: intro videos aren't fullscreen while the game
is. This is a regression:
75300a7e32e198368893d06b7d6088850c614fe4 is the first bad commit
commit 75300a7e32e198368893d06b7d6088850c614fe4
Author: Aric Stewart 
Date:   Fri Mar 30 20:09:14 2012 -0500

quartz: Convert VideoRenderer to use strmbase's BaseControlWindow.

:040000 040000 d31c6a57e8fc2b2e95b356be727998ac48f0dd68
b9179d960b67e582e2872f0a678d2e3c8c683e0e M      dlls

I didn't take any crashes on video loading into account while bisection, only
looked at the window size of the supposedly starting video (black window on
blue background), so good is fullscreen black screen/video and bad is 640x480
one.

This doesn't depend on video card being used, namely, it appears both on Intel
N10 (EEEPC 1015PN) on Ubuntu Lucid and GeForce GTX460 with binary driver on
LFS.

[Bug 31506] quartz video window isn't fullscreen in fullscreen apps

http://bugs.winehq.org/show_bug.cgi?id=31506

Ruslan  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 31506] quartz video window isn't fullscreen in fullscreen apps

http://bugs.winehq.org/show_bug.cgi?id=31506

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 31506] quartz video window isn't fullscreen in fullscreen apps

http://bugs.winehq.org/show_bug.cgi?id=31506

Christian Costa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Christian Costa  2012-10-07 08:05:37 CDT ---
Is the window/screen displayed in the top left corner?

[Bug 31506] quartz video window isn't fullscreen in fullscreen apps

http://bugs.winehq.org/show_bug.cgi?id=31506

--- Comment #2 from Christian Costa  2012-10-07 08:09:24 CDT ---
Created attachment 42006
  --> http://bugs.winehq.org/attachment.cgi?id=42006
dest rect fix

I didn't see anything obvious in the commit but I found something wrong in the
code (independant from the commit). I'm not sure it is related to your problem
but can you try the attached patch?

[Bug 31506] quartz video window isn't fullscreen in fullscreen apps

http://bugs.winehq.org/show_bug.cgi?id=31506

--- Comment #3 from Ruslan  2012-10-07 12:15:06 CDT ---
(In reply to comment #1)
> Is the window/screen displayed in the top left corner?

Game window itself is fullscreen unlike video.
> I'm not sure it is related to your problem but can you try the attached patch?

The patch doesn't change anything.

[Bug 31506] quartz video window isn't fullscreen in fullscreen apps

http://bugs.winehq.org/show_bug.cgi?id=31506

--- Comment #4 from Christian Costa  2012-10-08 04:20:24 CDT ---
Could you attached a log with quartz debug channel enabled (WINEDEBUG=+quartz
wine ...)?

[Bug 31506] quartz video window isn't fullscreen in fullscreen apps

http://bugs.winehq.org/show_bug.cgi?id=31506

--- Comment #5 from Ruslan  2012-10-08 11:39:43 CDT ---
Created attachment 42024
  --> http://bugs.winehq.org/attachment.cgi?id=42024
+quartz log

Here it is

[Bug 31506] quartz video window isn't fullscreen in fullscreen apps

http://bugs.winehq.org/show_bug.cgi?id=31506

--- Comment #6 from Christian Costa  2012-10-09 12:19:04 CDT ---
Created attachment 42039
  --> http://bugs.winehq.org/attachment.cgi?id=42039
fullscreen fix

Could you try this patch and attach the new log with quartz channel enabled?

[Bug 31506] quartz video window isn't fullscreen in fullscreen apps

http://bugs.winehq.org/show_bug.cgi?id=31506

--- Comment #7 from Ruslan  2012-10-09 13:13:54 CDT ---
Created attachment 42040
  --> http://bugs.winehq.org/attachment.cgi?id=42040
New quartz log

Yeah, now it's fullscreen, though when I try to skip the video, it appears to
hang my X until I do "wineserver -k", so the log is only up to that point.

[Bug 31506] quartz video window isn't fullscreen in fullscreen apps

http://bugs.winehq.org/show_bug.cgi?id=31506

--- Comment #8 from Christian Costa  2012-10-09 13:30:52 CDT ---
Created attachment 42043
  --> http://bugs.winehq.org/attachment.cgi?id=42043
with one more trace

Could you test this patch and attach another log?

Could you confirm the hang happens every time. Could you also try to skip the
video without the patch and see if it also hangs?

[Bug 31506] quartz video window isn't fullscreen in fullscreen apps

http://bugs.winehq.org/show_bug.cgi?id=31506

--- Comment #9 from Ruslan  2012-10-09 13:56:21 CDT ---
Created attachment 42045
  --> http://bugs.winehq.org/attachment.cgi?id=42045
One more log

It doesn't hang when video is not fullscreen, but does with both patches.
Though, this might be not because of patch itself, maybe it's just because the
video is larger and this might reveal some driver bug. Xorg shouldn't hang
because of app I guess :)

[Bug 31506] quartz video window isn't fullscreen in fullscreen apps

http://bugs.winehq.org/show_bug.cgi?id=31506

--- Comment #10 from Christian Costa  2012-10-09 14:26:30 CDT ---
The window area size is 1280x1043 instead of 1280x1024. There are extra 19
lines which should correspond to the menu height. Did you see a menu bar or any
decoration when the window was not in fullscreen?

It seems the wine x11 driver does not like this window area size bigger than
the screen. It can be a xorg but this can also come from the wine x11 driver.
It seems Alexandre are doing some work in that area. Maybe it's related to this
changes. Just wait my patch is committed and rebase to latest git and then file
a bug if the crash persists.

[Bug 31506] quartz video window isn't fullscreen in fullscreen apps

http://bugs.winehq.org/show_bug.cgi?id=31506

--- Comment #11 from Ruslan  2012-10-09 14:33:03 CDT ---
(In reply to comment #10)
> Did you see a menu bar or any
> decoration when the window was not in fullscreen?

No, there were no menu nor decoration.
> Just wait my patch is committed and rebase to latest git and then file

a bug if the crash persists.
OK

[Bug 31506] quartz video window isn't fullscreen in fullscreen apps

http://bugs.winehq.org/show_bug.cgi?id=31506

--- Comment #12 from Christian Costa  2012-10-09 14:40:11 CDT ---
(In reply to comment #11)
> (In reply to comment #10)
> > Did you see a menu bar or any
> > decoration when the window was not in fullscreen?
>
> No, there were no menu nor decoration.

Ok I see. The quartz code assume there is a menu. I will try to fix that.

[Bug 31506] quartz video window isn't fullscreen in fullscreen apps

http://bugs.winehq.org/show_bug.cgi?id=31506

--- Comment #13 from Christian Costa  2012-10-09 14:52:01 CDT ---
Created attachment 42047
  --> http://bugs.winehq.org/attachment.cgi?id=42047
fix menu

Does the attached patch fixes the crash? Apply the patch upon the previous one.

[Bug 31506] quartz video window isn't fullscreen in fullscreen apps

http://bugs.winehq.org/show_bug.cgi?id=31506

--- Comment #14 from Christian Costa  2012-10-09 14:54:11 CDT ---
Also attach the new log...

[Bug 31506] quartz video window isn't fullscreen in fullscreen apps

http://bugs.winehq.org/show_bug.cgi?id=31506

--- Comment #15 from Ruslan  2012-10-09 14:55:58 CDT ---
Created attachment 42048
  --> http://bugs.winehq.org/attachment.cgi?id=42048
New log

No, this patch doesn't change anything. The same hang.

[Bug 31506] quartz video window isn't fullscreen in fullscreen apps

http://bugs.winehq.org/show_bug.cgi?id=31506

--- Comment #16 from Christian Costa  2012-10-09 16:49:27 CDT ---
Ok. The size is fixed. I will submit the patch.
File a new for the crash.

[Bug 31506] quartz video window isn't fullscreen in fullscreen apps

http://bugs.winehq.org/show_bug.cgi?id=31506

Julian Rüger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 31506] quartz video window isn't fullscreen in fullscreen apps

http://bugs.winehq.org/show_bug.cgi?id=31506

--- Comment #17 from Christian Costa  2012-10-10 16:55:23 CDT ---
Fixed by 266e79d05f054904162dea62a3a2656b8917c13e. File a new bug for the
crach.

[Bug 31506] quartz video window isn't fullscreen in fullscreen apps

http://bugs.winehq.org/show_bug.cgi?id=31506

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |266e79d05f054904162dea62a3a
                   |                            |2656b8917c13e
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |[e-mail]
         Resolution|                            |FIXED

--- Comment #18 from Bruno Jesus  2012-10-10 19:02:37 CDT ---
(In reply to comment #17)
> Fixed by 266e79d05f054904162dea62a3a2656b8917c13e. File a new bug for the
> crach.

Fixed.

[Bug 31506] quartz video window isn't fullscreen in fullscreen apps

http://bugs.winehq.org/show_bug.cgi?id=31506

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #19 from Alexandre Julliard  2012-10-12 13:34:45 CDT ---
Closing bugs fixed in 1.5.15.