[Bug 15405] New: Problem with wrc 1.0

http://bugs.winehq.org/show_bug.cgi?id=15405

Summary: Problem with wrc 1.0
           Product: Wine
           Version: unspecified
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

I have a .rc file that compiles perfectly with wrc 0.9.40 (and with VisualC++)
but gives a syntax error with wrc 1.0.

wrc   -I.   -fowindows.res windows.rc
windows.rc:102:15: Error: syntax error

Lines 102 and following are

CONSTRDB DIALOG DISCARDABLE  20, 20, 148, 266
STYLE WS_POPUP | WS_CAPTION
CAPTION "Classifier Construction Options"
FONT 9, "MS Sans Serif"
BEGIN
....

Using the .res file produced by wrc 0.9.40 with wine 1.0 seems to work fine.

[Bug 15405] Problem with wrc 1.0

http://bugs.winehq.org/show_bug.cgi?id=15405

--- Comment #1 from Dmitry Timoshkov   2008-09-25 03:58:00 ---
Please perform the regression test as outlined here:
http://wiki.winehq.org/RegressionTesting

[Bug 15405] Problem with wrc 1.0

http://bugs.winehq.org/show_bug.cgi?id=15405

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |programs
           Keywords|                            |regression
            Version|unspecified                 |1.0.0

[Bug 15405] Problem with wrc 1.0

http://bugs.winehq.org/show_bug.cgi?id=15405

--- Comment #2 from Lei Zhang   2008-09-29 17:58:21 ---
Can you make a minimal rc file that has this problem, and attach it to this
bug?

[Bug 15405] Problem with wrc 1.0

http://bugs.winehq.org/show_bug.cgi?id=15405

--- Comment #3 from Ross Quinlan   2008-09-29 18:46:46 ---
Created an attachment (id=16375)
 --> (http://bugs.winehq.org/attachment.cgi?id=16375)
Minimal .rc file that compiles under wrc 0.9.40 but not under 1.0

[Bug 15405] Problem with wrc 1.0

http://bugs.winehq.org/show_bug.cgi?id=15405

--- Comment #4 from Lei Zhang   2008-09-30 04:33:01 ---
The attached .rc file fails for me with Wine 0.9.40.

[Bug 15405] Problem with wrc 1.0

http://bugs.winehq.org/show_bug.cgi?id=15405

--- Comment #5 from Ross Quinlan   2008-09-30 14:56:25 ---
Created an attachment (id=16382)
 --> (http://bugs.winehq.org/attachment.cgi?id=16382)
Transcript of wrc 0.9.40 showing no errors

[Bug 15405] Problem with wrc 1.0

http://bugs.winehq.org/show_bug.cgi?id=15405

Ilya Sandler  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Ilya Sandler   2008-10-15 20:45:17 ---
Hello, I am a newbie as far as windows resource files are concerned, however it
seems that I can reproduce the problem by  trying to compile a dialog sample
from msdn website:

http://msdn.microsoft.com/en-us/library/aa381003(VS.85).aspx
> cat test.rc

#include <windows.h>

ErrorDialog DIALOG  10, 10, 300, 110
STYLE WS_POPUP | WS_BORDER
CAPTION "Error!" 
{
    CTEXT "Select One:", 1, 10, 10, 280, 12
    PUSHBUTTON "&Retry", 2, 75, 30, 60, 12
    PUSHBUTTON "&Abort", 3, 75, 50, 60, 12
    PUSHBUTTON "&Ignore", 4, 75, 80, 60, 12
}
> wrc test.rc

test.rc:3:15: Error: syntax error

This is with 1.0.0-1ubuntu4~hardy1 version of the wine-dev package

[Bug 15405] Problem with wrc 1.0

http://bugs.winehq.org/show_bug.cgi?id=15405

--- Comment #7 from Ilya Sandler   2008-10-15 21:19:51 ---
A bit more information.

The syntax error goes away if I add

#include <winuser.h> (after  include <windows.h>)

Apparently that's where constants like WS_POPUP, WS_BORDER are coming from.

Digging a bit deeper: windows.h includes winresrc.h which has a bunch of
FIXMEs:

/* FIXME: #include <winuser.rh> */
/* FIXME: #include <commctrl.rh> */
/* FIXME: #include <dde.rh> */
/* FIXME: #include <winnt.rh> */

So it still looks like wine's problem

[Bug 15405] winresrc.h is incomplete

http://bugs.winehq.org/show_bug.cgi?id=15405

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |minor
          Component|programs                    |build-env
            Summary|Problem with wrc 1.0        |winresrc.h is incomplete

--- Comment #8 from Dmitry Timoshkov   2008-10-16 06:56:51 ---
Updating subject and component.

[Bug 15405] winresrc.h is incomplete

http://bugs.winehq.org/show_bug.cgi?id=15405

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|regression                  |

--- Comment #9 from Dmitry Timoshkov   2008-10-16 06:57:15 ---
Not a regression.

[Bug 15405] winresrc.h is incomplete

http://bugs.winehq.org/show_bug.cgi?id=15405

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |source, testcase

[Bug 15405] winresrc.h is incomplete

http://bugs.winehq.org/show_bug.cgi?id=15405

Andrey Turkin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from Andrey Turkin   2008-10-17 07:41:55 ---
> Digging a bit deeper: windows.h includes winresrc.h which has a bunch of
> FIXMEs:
>
> /* FIXME: #include <winuser.rh> */
> /* FIXME: #include <commctrl.rh> */
> /* FIXME: #include <dde.rh> */
> /* FIXME: #include <winnt.rh> */
>
> So it still looks like wine's problem

Right, and initial version of winuser.rh just was submitted to GIT; rc file
from initial comment compiles now.

[Bug 15405] winresrc.h is incomplete

http://bugs.winehq.org/show_bug.cgi?id=15405

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #11 from Dmitry Timoshkov   2008-10-17 08:14:16 ---
The bug should be fixe now.

[Bug 15405] winresrc.h is incomplete

http://bugs.winehq.org/show_bug.cgi?id=15405

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #12 from Alexandre Julliard   2008-10-24 11:14:02 ---
Closing bugs fixed in 1.1.7.

[Bug 15405] winresrc.h is incomplete

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=15405

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
      Fixed by SHA1|                            |5c19a62f503ff8c84483a04dea3
                   |                            |6dd078e8354af