[Bug 15177] New: Assassin's Creed 1.2 crashes wine

http://bugs.winehq.org/show_bug.cgi?id=15177

Summary: Assassin's Creed 1.2 crashes wine
           Product: Wine
           Version: CVS/GIT
          Platform: Other
        OS/Version: other
            Status: UNCONFIRMED
          Severity: blocker
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=15921)
 --> (http://bugs.winehq.org/attachment.cgi?id=15921)
Backtrace

Using the latest git Assassin's Creed fails to start using the
AssassinsCreed_Dx9 binary. (backtrace attached)

Steps to reproduce.

1) Install game
2) Launch game which will automatically start the patcher, patching you to
version 1.2

[Bug 15177] Assassin's Creed 1.2 crashes wine

http://bugs.winehq.org/show_bug.cgi?id=15177

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|blocker                     |normal

--- Comment #1 from Vitaliy Margolen   2008-09-08 08:55:20 ---
Not a blocker.
> andrew@blackbox:~/.wine/drive_c/Program Files/Ubisoft/Assassin's Creed$ WINEDEBUG=-all wine AssassinsCreed_Launcher.exe

Please do not use WINEDEBUG when reporting bugs. Especially -all !

Please try native d3dx9_36.dll

Most likely duplicate of bug 14719

[Bug 15177] Assassin's Creed 1.2 crashes wine

http://bugs.winehq.org/show_bug.cgi?id=15177

--- Comment #2 from Andrew Fenn   2008-09-10 02:50:31 ---
I got this working by applying Luis Busquet's patch that implements the
d3dx9_36 functions that are missing for this game (D3DXGetShaderConstantTable,
D3DXGetShaderConstantTableEx).

Is there a reason that D3DXCheckTextureRequirements is a stub when the code is
already implemented in dlls/d3dx9_36/texture.c ? Right now it's sitting in GIT
but not getting compiled and run.

I won't submit a patch because I don't have the time right now but the game
loads without having the use the native d3dx9_36.dll. The game runs now without
crashing wine.

I'll submit a patch later on.

[Bug 15177] Assassin's Creed 1.2 crashes wine

http://bugs.winehq.org/show_bug.cgi?id=15177

--- Comment #3 from Andrew Fenn   2008-09-10 02:58:31 ---
(In reply to comment #1)
> Not a blocker.
> > andrew@blackbox:~/.wine/drive_c/Program Files/Ubisoft/Assassin's Creed$ WINEDEBUG=-all wine AssassinsCreed_Launcher.exe
>
> Please do not use WINEDEBUG when reporting bugs. Especially -all !
>
> Please try native d3dx9_36.dll
>
> Most likely duplicate of bug 14719

This bug is completely different, it was obvious from my backtrace.

See third line:

wine: Unimplemented function d3dx9_36.dll.D3DXCheckTextureRequirements called
at address 0x7ee25f90 (thread 0022), starting debugger...

[Bug 15177] Assassin's Creed 1.2 crashes wine

http://bugs.winehq.org/show_bug.cgi?id=15177

--- Comment #4 from Vitaliy Margolen   2008-09-10 11:16:27 ---
Did you or did you not try native d3dx9_36.dll?

If you want this bug to be about missing function in that above dll, that's
fine. You should clearly say so in the summary.
> Is there a reason that D3DXCheckTextureRequirements is a stub when the code is

already implemented in dlls/d3dx9_36/texture.c ?

Where do you see that file? It's not part of the Wine source tree.

[Bug 15177] Unimplemented functions needed for Assassin's Creed

http://bugs.winehq.org/show_bug.cgi?id=15177

Andrew Fenn  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Assassin's Creed 1.2 crashes|Unimplemented functions
                   |wine                        |needed for Assassin's Creed

--- Comment #5 from Andrew Fenn   2008-09-11 08:05:41 ---
(In reply to comment #4)
> Did you or did you not try native d3dx9_36.dll?

Yes, native works.
> If you want this bug to be about missing function in that above dll, that's
> fine. You should clearly say so in the summary.

Sorry for the misunderstanding, my intention in filing this as a bug was in
fixing the missing functions rather then getting the game to work. I'll change
the title to better reflect the problem.
> Where do you see that file? It's not part of the Wine source tree.

I saw it in my working copy but since you can not see it I am guessing it is
because I had applied a patch.

The patch I am referencing is this one.

http://www.winehq.org/pipermail/wine-patches/2008-April/053547.html

and also required to get the game working without the native dll is an
implementation of D3DXGetShaderConstantTable and D3DXGetShaderConstantTableEx
which I got using a patch by Luis Busquets (attached).

[Bug 15177] Unimplemented functions needed for Assassin's Creed

http://bugs.winehq.org/show_bug.cgi?id=15177

--- Comment #6 from Andrew Fenn   2008-09-11 08:07:18 ---
Created an attachment (id=16014)
 --> (http://bugs.winehq.org/attachment.cgi?id=16014)
Luis Busquet's patch which implements some needed d3dx9_36 functions

[Bug 15177] Unimplemented functions needed for Assassin's Creed

http://bugs.winehq.org/show_bug.cgi?id=15177

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|CVS/GIT                     |unspecified

--- Comment #7 from Austin English   2009-01-20 02:40:19 ---
Removing deprecated CVS/GIT version tag. Please retest in current git. If the
bug is still present in today's wine, but was not present in some earlier
version of wine, please update version field to earliest known version of wine
that had the bug. Thanks!

[Bug 15177] Unimplemented functions needed for Assassin's Creed

http://bugs.winehq.org/show_bug.cgi?id=15177

--- Comment #8 from Andrew Fenn   2009-02-28 09:07:45 ---
I did a clean install of the latest GIT version of wine.

Assassin's Creed is missing the following functions in wine making the game
crash.

d3dx9_36.dll.D3DXCheckTextureRequirements

[Bug 15177] Unimplemented functions needed for Assassin's Creed

http://bugs.winehq.org/show_bug.cgi?id=15177

Jaime Rave  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from Jaime Rave   2009-04-01 19:04:53 ---
The Settlers "Honey For the King" Demo is crashing also on the unimplemented
function:

wine: Call from 0x7b844350 to unimplemented function
d3dx9_36.dll.D3DXCheckTextureRequirements, aborting

Here is the URL of the demo:
http://thesettlers.uk.ubi.com/download-demo.php

[Bug 15177] Unimplemented functions needed for Assassin's Creed

http://bugs.winehq.org/show_bug.cgi?id=15177

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #10 from [e-mail]  2009-05-23 08:02:39 ---
*** This bug has been confirmed by popular vote. ***

[Bug 15177] Unimplemented functions needed for Assassin's Creed

http://bugs.winehq.org/show_bug.cgi?id=15177

NSLW  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
                   |                            |m

--- Comment #11 from NSLW   2009-05-31 02:19:49 ---
The bug is solved for me on Wine-1.1.22 with AC patched to 1.02
I didn't copied neither x_input3 nor d3dx9_36 to system32

[Bug 15177] Unimplemented functions needed for Assassin's Creed

http://bugs.winehq.org/show_bug.cgi?id=15177

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #12 from Dmitry Timoshkov   2009-05-31 06:34:41 ---
Reported fixed.

[Bug 15177] Unimplemented functions needed for Assassin's Creed

http://bugs.winehq.org/show_bug.cgi?id=15177

--- Comment #13 from Andrew Nguyen   2009-05-31 07:00:17 ---
I'm not sure that this bug really is fixed, since D3DXCheckTextureRequirements
is still stubbed in d3dx_36.dll:

dlls/d3dx9_36/d3dx9_36.spec:@ stub D3DXCheckTextureRequirements

[Bug 15177] Unimplemented functions needed for Assassin's Creed

http://bugs.winehq.org/show_bug.cgi?id=15177

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

--- Comment #14 from Dmitry Timoshkov   2009-05-31 07:09:53 ---
Andrew, could you please retest?

[Bug 15177] Unimplemented functions needed for Assassin's Creed

http://bugs.winehq.org/show_bug.cgi?id=15177

--- Comment #15 from NSLW   2009-05-31 07:46:10 ---
(In reply to comment #13)

Sorry. I should read this bug more carefully. The game updated itself DirectX
on the end of installation thus automatically copying d3dx9_36.dll.
If i remove d3dx9_36.dll (Why the hell should I do that?) and try to run AC
then i get

wine: Unimplemented function d3dx9_36.dll.D3DXCheckTextureRequirements called
at address 0x7b840bf9 (thread 0022), starting debugger...

I didn't thought this bug is like: "Let's see what happens when we cripple
"./wine/system32". Does AC will be still running?"

I think the severity should be changed to "Minor" or "Enhancement"

[Bug 15177] Unimplemented functions needed for Assassin's Creed

http://bugs.winehq.org/show_bug.cgi?id=15177

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |minor

[Bug 15177] Unimplemented functions needed for Assassin's Creed

http://bugs.winehq.org/show_bug.cgi?id=15177

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #16 from Juan Lang   2009-08-12 12:01:22 ---
In that case, this really is fixed.  d3dx9_nn.dll should be installed by the
application, and we provide an implementation for broken installers that don't
provide the needed functions.  Since Assassin's Creed does the correct thing
and installs its own d3dx9_36.dll, it's working.  Other applications may well
depend on this function in Wine's version of d3dx9_36.dll, but they merit their
own bugs.

[Bug 15177] Unimplemented functions needed for Assassin's Creed

http://bugs.winehq.org/show_bug.cgi?id=15177

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #17 from Juan Lang   2009-08-12 12:02:35 ---
And closing.

[Bug 15177] Unimplemented functions needed for Assassin's Creed

http://bugs.winehq.org/show_bug.cgi?id=15177

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |RESOLVED

--- Comment #18 from Dmitry Timoshkov   2009-08-13 02:25:29 ---
The bug will be closed as a part of the release process.

[Bug 15177] Unimplemented functions needed for Assassin's Creed

http://bugs.winehq.org/show_bug.cgi?id=15177

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #19 from Alexandre Julliard   2009-08-21 12:36:04 ---
Closing bugs fixed in 1.1.28.