[Bug 46245] New: Ingame vsync setting does not work

https://bugs.winehq.org/show_bug.cgi?id=46245

Bug ID: 46245
           Summary: Ingame vsync setting does not work
           Product: vkd3d
           Version: 1.1
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P2
         Component: vkd3d
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Disabling vsync ingame (tested with World of Warcraft) does not work. Vsync is
always on.

Can force this to "always off" with:

diff --git a/dlls/dxgi/swapchain.c b/dlls/dxgi/swapchain.c
index 4dfa068..3f82cfa 100644
--- a/dlls/dxgi/swapchain.c
+++ b/dlls/dxgi/swapchain.c
@@ -1491,7 +1491,7 @@
     vk_swapchain_desc.pQueueFamilyIndices = NULL;
     vk_swapchain_desc.preTransform = surface_caps.currentTransform;
     vk_swapchain_desc.compositeAlpha = VK_COMPOSITE_ALPHA_OPAQUE_BIT_KHR;
-    vk_swapchain_desc.presentMode = VK_PRESENT_MODE_FIFO_KHR;
+    vk_swapchain_desc.presentMode = VK_PRESENT_MODE_IMMEDIATE_KHR;
     vk_swapchain_desc.clipped = VK_TRUE;
     vk_swapchain_desc.oldSwapchain = swapchain->vk_swapchain;
     if ((vr = vk_funcs->p_vkCreateSwapchainKHR(vk_device, &vk_swapchain_desc,
NULL, &vk_swapchain)) < 0)

But i guess that is just as awful as having it on all the time.

If possible - make some logic to follow the ingame setting? :)

[Bug 46245] Ingame vsync setting does not work

https://bugs.winehq.org/show_bug.cgi?id=46245

Józef Kucia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.1                         |4.0-rc1
          Component|vkd3d                       |directx-d3d
            Product|vkd3d                       |Wine
           Assignee|[e-mail]        |[e-mail]
                 CC|                            |[e-mail]
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #1 from Józef Kucia  ---
I've got DXGI patches for D3D12 swapchain swap intervals. I'll work on
upstreaming them after 4.0.

[Bug 46245] Ingame vsync setting does not work

https://bugs.winehq.org/show_bug.cgi?id=46245

Józef Kucia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|4.0-rc1                     |3.16

[Bug 46245] Ingame vsync setting does not work

https://bugs.winehq.org/show_bug.cgi?id=46245

--- Comment #2 from Sveinar Søpler  ---
If it's not too much trouble Józef, and you want to.. could you post those
patches here for me to play around with? :)

Just for me to test until they are upstreamed to 4.1 (?) when that time comes
:)

Appreciate your hard work on vkd3d :)

[Bug 46245] Ingame vsync setting does not work

https://bugs.winehq.org/show_bug.cgi?id=46245

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 46245] Ingame vsync setting does not work

https://bugs.winehq.org/show_bug.cgi?id=46245

--- Comment #3 from Sveinar Søpler  ---
(In reply to Józef Kucia from comment #1)
> I've got DXGI patches for D3D12 swapchain swap intervals. I'll work on
> upstreaming them after 4.0.

Would be sweet with this for 4.3, if you already have a working patchset :)

[Bug 46245] Ingame vsync setting does not work

https://bugs.winehq.org/show_bug.cgi?id=46245

pattietreutel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 46245] V-sync setting does not work (Direct3D 12)

https://bugs.winehq.org/show_bug.cgi?id=46245

Józef Kucia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Ingame vsync setting does   |V-sync setting does not
                   |not work                    |work (Direct3D 12)

[Bug 46245] V-sync setting does not work (Direct3D 12)

https://bugs.winehq.org/show_bug.cgi?id=46245

Józef Kucia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]      |[e-mail]
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |0510bca6964a103c5d38d1f5b5e
                   |                            |b2a2a72d6a2b9
         Resolution|---                         |FIXED

--- Comment #4 from Józef Kucia  ---
Should be fixed by the patch series ending with
https://source.winehq.org/git/wine.git/?a=commit;h=0510bca6964a103c5d38d1f5b...

[Bug 46245] V-sync setting does not work (Direct3D 12)

https://bugs.winehq.org/show_bug.cgi?id=46245

--- Comment #5 from Sveinar Søpler  ---
(In reply to Józef Kucia from comment #4)
> Should be fixed by the patch series ending with
> https://source.winehq.org/git/wine.git/?a=commit;
> h=0510bca6964a103c5d38d1f5b5eb2a2a72d6a2b9

Seems to work fine switching between vsync on/off in WoW.

Thanks! :)

[Bug 46245] V-sync setting does not work (Direct3D 12)

https://bugs.winehq.org/show_bug.cgi?id=46245

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  ---
Closing bugs fixed in 4.3.