http://bugs.winehq.org/show_bug.cgi?id=14978
Summary: Video Display Resolution switch back broken Product: Wine Version: 1.1.3 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: geist1@sms.at
In 1.1.3 wine doesnt switch back the correct resolution of teh desktop anymore.
E.g. if a game uses 800X600, and the desktop is set to 1024X768, then the resolution will be switched to 800X600 for the game, but when one quits the game the resolution should be switched back to 1024X768, this will not happen anymore.
http://bugs.winehq.org/show_bug.cgi?id=14978
--- Comment #1 from Dmitry Timoshkov dmitry@codeweavers.com 2008-08-24 09:29:10 --- Is that a regression? Which last Wine version is known to work? If that's a regression please perform a regression test as outlined here: http://wiki.winehq.org/RegressionTesting
http://bugs.winehq.org/show_bug.cgi?id=14978
--- Comment #2 from Lei Zhang thestig@google.com 2008-09-03 18:18:59 --- Also, what games are affected?
http://bugs.winehq.org/show_bug.cgi?id=14978
--- Comment #3 from Reinhard Berger geist1@sms.at 2008-09-04 02:44:36 --- Last worked correctly with wine 1.1.2
Did not work anymore with wine 1.1.3.
Affected games should be all (tested so far only Stronghold Crusader)
I'll try to do a regression test today.
http://bugs.winehq.org/show_bug.cgi?id=14978
--- Comment #4 from Reinhard Berger geist1@sms.at 2008-09-04 03:23:25 --- I've done a regression test now, but i am unable to find out the patch in wine that created the problem.
git bisect start git bisect good wine-1.1.2 git bisect bad wine-1.1.3
I started with : Bisecting: 167 revisions left to test after this
and reched the end with Bisecting: 0 revisions left to test after this
There was no step between where i could say "good"
Thereforce i can not give any deatails
The last git bisect bad command gives me :
Date: Fri Jul 25 11:16:54 2008 -0700
shlwapi: Use CharNextA to iterate through characters in PathAddBackslashA. Fixes problems with MBCS paths.
:040000 040000 98c6fa7008a200d657fbc7b3e178ed819df7470f 8e641bd55bc1d6eee5b64c241c6118306ed65e5d M dll
I don't think that this is the problem, it is more that git isn't able to identify the patch wich was used.
http://bugs.winehq.org/show_bug.cgi?id=14978
--- Comment #5 from James Hawkins truiken@gmail.com 2008-09-04 04:01:22 --- (In reply to comment #4)
I started with : Bisecting: 167 revisions left to test after this
and reched the end with Bisecting: 0 revisions left to test after this
Please read the regression testing page more carefully; you have one more build left:
"If you see:
Bisecting: 0 revisions left to test after this
THEN YOU ARE NOT DONE YET! "
http://bugs.winehq.org/show_bug.cgi?id=14978
--- Comment #6 from Reinhard Berger geist1@sms.at 2008-09-04 04:18:05 --- I've readed the regession page carefuly, there stays : If you see: Bisecting: 0 revisions left to test after this
THEN YOU ARE NOT DONE YET! Once that patch is identified ...
That means for the following :
After i see the 0 revisions left, i should do another start of the application.
I've done this, but it still fails (bug is still present) then issued the command "git bisect bad"
This will display me the following things :
87c3df1578803f63ce68096c07c42c3af279077c is first bad commit commit 87c3df1578803f63ce68096c07c42c3af279077c Author: Juan Lang juan.lang@gmail.com Date: Fri Jul 25 11:16:54 2008 -0700
shlwapi: Use CharNextA to iterate through characters in PathAddBackslashA. Fixes problems with MBCS paths.
:040000 040000 98c6fa7008a200d657fbc7b3e178ed819df7470f 8e641bd55bc1d6eee5b64c241c6118306ed65e5d M dlls
But i'm pretty sure that this is not the reason.
I am unable to find the patch wich is responsable for that bug, since i can't tell GIT after all that pacthes a "good" command.
Something else i could do ?
http://bugs.winehq.org/show_bug.cgi?id=14978
--- Comment #7 from James Hawkins truiken@gmail.com 2008-09-04 04:22:03 --- Have you checked out 1.1.2 in git and made sure that works? You can also try reverting the commit in question and see if it works then, even though it seems unlikely.
http://bugs.winehq.org/show_bug.cgi?id=14978
--- Comment #8 from Reinhard Berger geist1@sms.at 2008-09-04 08:46:47 --- well, i've done again a regress test now from scratch.
I still wonder, why i get version 1.1.2 when i entered 1.1.1 at first good version ?
Anyway, this time it is completly diffrent.
Before i got always "bad" gits, this time i always get "good" ones, means the bug doesnt appear, but before the bug always appeart.
runnning now the steps down with git, it comes to a line like this :
geist@GST:~/Test/wine-git$ git bisect good de92617b3ec1501a2a56f6262d9653f502a5b331 is first bad commit commit de92617b3ec1501a2a56f6262d9653f502a5b331 Author: Alexandre Julliard julliard@winehq.org Date: Fri Aug 22 17:16:26 2008 +0200
Release 1.1.3.
:100644 100644 9b14216d945fc84716491e6fd145729a70b86d0c b692da069835e21f030e32323fc86dce98bef531 M ANNOUNCE :100644 100644 1c0a52802e105b9d8f4609ab38343d309aeabb81 ede4ec6e8477a48509842aff0c9bfc9c28c443dc M VERSION :100755 100755 4345d9501b3519a19e2d5e3f59639354a74b9ca2 66e0fd5f1d6f0956ad789cd924d31c8c3c911890 M configure
Acording to the wiki page, i have done a git bisect reset Switched to branch "master"
Now i should enter the version 1.1.3 as the first good one, i've done then :
git bisect good wine-1.1.3 git bisect bad wine-1.1.3
and now ? should i re-compile wine again ? or what should i do now ?
Trying to call another time "git bisect good" doesnt give out any messages anymore.
http://bugs.winehq.org/show_bug.cgi?id=14978
--- Comment #9 from Vitaliy Margolen vitaliy@kievinfo.com 2008-09-04 12:07:58 --- (In reply to comment #8)
git bisect good wine-1.1.3 git bisect bad wine-1.1.3
That's wrong.
http://bugs.winehq.org/show_bug.cgi?id=14978
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
http://bugs.winehq.org/show_bug.cgi?id=14978
--- Comment #10 from Reinhard Berger geist1@sms.at 2008-09-07 12:08:59 --- Finaly regression test worked.
This is the result (compared 3 times to be sure it's the same) Bisecting: 83 revisions left to test after this [e178ddd9e1e16d1a3f52492799692e289eefcf8c] wined3d: Use a swapchain for GDI surfaces.
http://bugs.winehq.org/show_bug.cgi?id=14978
--- Comment #11 from Lei Zhang thestig@google.com 2008-09-07 12:45:14 --- (In reply to comment #10)
Finaly regression test worked.
This is the result (compared 3 times to be sure it's the same) Bisecting: 83 revisions left to test after this [e178ddd9e1e16d1a3f52492799692e289eefcf8c] wined3d: Use a swapchain for GDI surfaces.
Umm, you have to keep going, it says you have 83 revisions left to test.
http://bugs.winehq.org/show_bug.cgi?id=14978
--- Comment #12 from Reinhard Berger geist1@sms.at 2008-09-08 03:49:47 --- finished now the regression test :
geist@GST:~/Test/wine-git$ git bisect good e178ddd9e1e16d1a3f52492799692e289eefcf8c is first bad commit commit e178ddd9e1e16d1a3f52492799692e289eefcf8c Author: Stefan Dösinger stefan@codeweavers.com Date: Tue Aug 5 14:23:00 2008 -0500
wined3d: Use a swapchain for GDI surfaces.
This is a long-needed cleanup aimed at removing the ddraw_primary, ddraw_window, ddraw_width and ddraw_height members from IWineD3DDeviceImpl, which just do not belong there. Destination window and screen handling is supposed to be done by swapchains.
:040000 040000 da09ecee6e65fe4149d996ec279e9e997e2dcf2e cd47edc30230bb50f87896c3a7220b7a628683e5 M dlls :040000 040000 803067b0704c69746d6dbbf0f9d081a284eddef4 405e4687c093ec5c082507ce0195a7958799b4bf M include
http://bugs.winehq.org/show_bug.cgi?id=14978
Lei Zhang thestig@google.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |DUPLICATE
--- Comment #13 from Lei Zhang thestig@google.com 2008-09-08 16:03:47 --- Thanks, duplicate of bug 14995.
*** This bug has been marked as a duplicate of bug 14995 ***
http://bugs.winehq.org/show_bug.cgi?id=14978
Lei Zhang thestig@google.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #14 from Lei Zhang thestig@google.com 2008-09-08 16:03:56 --- closing dup.
-
wine-bugs＠winehq.org