[Bug 54868] New: Compile error in dlls/wined3d/surface.c:246:61: error: incompatible function pointer types

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54868

Bug ID: 54868
           Summary: Compile error in dlls/wined3d/surface.c:246:61: error:
                    incompatible function pointer types
           Product: Wine
           Version: 8.6
          Hardware: aarch64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: d3d
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Wine 8.6

Specific to the ARM 64-bit build with Clang. x86/x86-64 with GCC compile
without error.

clang -c -o dlls/wined3d/aarch64-windows/surface.o dlls/wined3d/surface.c
-Idlls/wined3d -Iinclude -Iinclude/msvcrt \
  -Ilibs/vkd3d/include -D_UCRT -D__WINESRC__ -D__WINE_PE_BUILD -Wall -target
aarch64-windows \
  -fuse-ld=lld -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body
-Wignored-qualifiers \
  -Winit-self -Wno-pragma-pack -Wstrict-prototypes -Wtype-limits
-Wunused-but-set-parameter -Wvla \
  -Wwrite-strings -Wpointer-arith -Wabsolute-value -g -O2
dlls/wined3d/surface.c:246:61: error: incompatible function pointer types
initializing 'void (*)(const BYTE *, BYTE *, unsigned int, unsigned int,
unsigned int, unsigned int)' (aka 'void (*)(const unsigned char *, unsigned
char *, unsigned int, unsigned int, unsigned int, unsigned int)') with an
expression of type 'void (const BYTE *, BYTE *, DWORD, DWORD, unsigned int,
unsigned int)' (aka 'void (const unsigned char *, unsigned char *, unsigned
long, unsigned long, unsigned int, unsigned int)')
[-Wincompatible-function-pointer-types]
    {WINED3DFMT_B8G8R8X8_UNORM, WINED3DFMT_L8_UNORM,       
convert_x8r8g8b8_l8},
                                                            ^~~~~~~~~~~~~~~~~~~
1 error generated.
make: *** [Makefile:131217: dlls/wined3d/aarch64-windows/surface.o] Error 1

[Bug 54868] Compile error in dlls/wined3d/surface.c:246:61: error: incompatible function pointer types

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54868

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|Wine                        |Wine-staging
          Component|d3d                         |-unknown
                 CC|                            |[e-mail]
                   |                            |, [e-mail]

--- Comment #1 from Alexandre Julliard  ---
That's from a wine-staging patch.

[Bug 54868] Compile error in dlls/wined3d/surface.c:246:61: error: incompatible function pointer types

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54868

--- Comment #2 from Michael Cronenworth  ---
Sorry, Alexandre. Thanks.

This update to the wine-staging patch is enough to fix it.

--
patches/wined3d-WINED3DFMT_B8G8R8X8_UNORM/0001-wined3d-Implement-WINED3DFMT_B8G8R8X8_UNORM-to-WINED.patch
   2023-04-16 12:59:31.000000000 -0500
+++ new.patch    2023-04-19 16:14:39.193610089 -0500
@@ -18,7 +18,7 @@
  }

+static void convert_x8r8g8b8_l8(const BYTE *src, BYTE *dst,
-+        DWORD pitch_in, DWORD pitch_out, unsigned int w, unsigned int h)
++        unsigned int pitch_in, unsigned int pitch_out, unsigned int w,
unsigned int h)
 +{
 +    unsigned int x, y;
 +

[Bug 54868] Compile error in dlls/wined3d/surface.c:246:61: error: incompatible function pointer types

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54868

Neko-san  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 54868] Compile error in dlls/wined3d/surface.c:246:61: error: incompatible function pointer types

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54868

Michael Cronenworth  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #3 from Michael Cronenworth  ---
The patch set has been removed. Closing.

[Bug 54868] Compile error in dlls/wined3d/surface.c:246:61: error: incompatible function pointer types

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54868

--- Comment #4 from Austin English  ---
Closing.

[Bug 54868] Compile error in dlls/wined3d/surface.c:246:61: error: incompatible function pointer types

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54868

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Austin English  ---
Actually closing.