[Bug 17977] New: Sacred hangs after applying commit ef2d70418383f03c6bf701caeb67129acc6d2453

http://bugs.winehq.org/show_bug.cgi?id=17977

Summary: Sacred hangs after applying commit
                    ef2d70418383f03c6bf701caeb67129acc6d2453
           Product: Wine
           Version: unspecified
          Platform: PC
        OS/Version: other
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=20336)
 --> (http://bugs.winehq.org/attachment.cgi?id=20336)
Wine crash log

I've been following wine git for some time now.
Some time after Wine 1.1.18 Sacred started crashing or hanging when selecting
New Campaign (or Ancaria Campaign/Underworld Campaign). 
I tried the usual work-arounds as changing OffscreenRenderingMode &
DirectDrawRenderer but it still crashes 100% of the time.
This was with Sacred Underworld 2.28 and with the Sacred Demo (available from
Fileplanet and others).

After running a git bisect I end up with:

git bisect bad
ef2d70418383f03c6bf701caeb67129acc6d2453 is first bad commit
commit ef2d70418383f03c6bf701caeb67129acc6d2453
Author: Henri Verbeet 
Date:   Mon Mar 30 11:24:54 2009 +0200

wined3d: Store the format_desc itself in struct
wined3d_stream_info_element.

:040000 040000 9973a6e52500c6d2d9d98aefcc26204f2c4a25a7
26e859c1d10750b2c2b529568e0b72a742dea5da M    dlls

I'm not sure which WINEDEBUG options that might be interesting for further
debugging.

Attaching crash log.
I tried to CC Henri Verbeet but bugs.winehq.org didn't quite like that.

[Bug 17977] Sacred hangs after applying commit ef2d70418383f03c6bf701caeb67129acc6d2453

http://bugs.winehq.org/show_bug.cgi?id=17977

--- Comment #1 from H. Verbeet   2009-04-08 08:21:55 ---
Created an attachment (id=20337)
 --> (http://bugs.winehq.org/attachment.cgi?id=20337)
patch

Could you give this a try?

[Bug 17977] Sacred hangs after applying commit ef2d70418383f03c6bf701caeb67129acc6d2453

http://bugs.winehq.org/show_bug.cgi?id=17977

--- Comment #2 from Mikael Åkersund   2009-04-08 09:03:43 ---
(In reply to comment #1)
> Created an attachment (id=20337)

--> (http://bugs.winehq.org/attachment.cgi?id=20337) [details]
> patch
>
> Could you give this a try?

Works wonders. 
The game works flawlessly now.
Should the bug be closed, or do we wait until the patch is in GIT?

[Bug 17977] Sacred hangs after applying commit ef2d70418383f03c6bf701caeb67129acc6d2453

http://bugs.winehq.org/show_bug.cgi?id=17977

--- Comment #3 from H. Verbeet   2009-04-08 09:11:41 ---
You mark the bug as fixed once the patch is in git. The bug will be closed once
a version of Wine with the patch in it is released.

[Bug 17977] Sacred hangs when selecting New Campaign

http://bugs.winehq.org/show_bug.cgi?id=17977

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |directx-d3d
           Keywords|                            |regression
            Summary|Sacred hangs after applying |Sacred hangs when selecting
                   |commit                      |New Campaign
                   |ef2d70418383f03c6bf701caeb67|
                   |129acc6d2453                |
            Version|unspecified                 |1.1.18

[Bug 17977] Sacred hangs when selecting New Campaign

http://bugs.winehq.org/show_bug.cgi?id=17977

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 17977] Sacred hangs when selecting New Campaign

http://bugs.winehq.org/show_bug.cgi?id=17977

--- Comment #4 from H. Verbeet   2009-04-09 11:54:14 ---
Should be fixed by 877e252681b4d75abc2392704479ab78f332670d.

[Bug 17977] Sacred hangs when selecting New Campaign

http://bugs.winehq.org/show_bug.cgi?id=17977

--- Comment #5 from Mikael Åkersund   2009-04-09 12:37:58 ---
Just tried the latest git and the bug is now fixed.

[Bug 17977] Sacred hangs when selecting New Campaign

http://bugs.winehq.org/show_bug.cgi?id=17977

Mikael Åkersund  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Mikael Åkersund   2009-04-09 12:42:01 ---
Marking this bug as fixed since a patch is in git.

[Bug 17977] Sacred hangs when selecting New Campaign

http://bugs.winehq.org/show_bug.cgi?id=17977

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard   2009-04-10 11:25:31 ---
Closing bugs fixed in 1.1.19.