[Bug 36742] New: Windows 7 USB/DVD download tool shows transparent controls (missing 'BrushTypeTextureFill' support)

https://bugs.winehq.org/show_bug.cgi?id=36742

Bug ID: 36742
           Summary: Windows 7 USB/DVD download tool shows transparent
                    controls (missing 'BrushTypeTextureFill' support)
           Product: Wine
           Version: 1.7.20
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: gdiplus
          Assignee: [e-mail]
          Reporter: [e-mail]

Hello folks,

as the summary says.

Prerequisite: 'winetricks -q dotnet20'

Download and install 'Image Mastering API 2.0' (work around bug 6194 and bug
16876)

http://www.microsoft.com/en-us/download/details.aspx?id=17073

'Windows 7 USB/DVD download tool' download:

http://www.microsoftstore.com/store/msusa/html/pbPage.Help_Win7_usbdvd_dwnTo...

Unpack the installer manually and install the .msi (work around bug 36646)

--- snip ---
$ pwd
/home/focht/.wine/drive_c/users/focht/Local Settings/Application
Data/Apps/Windows 7 USB DVD Download Tool

$ WINEDEBUG=+tid,+seh,+loaddll,+process,+text wine
./Windows7-USB-DVD-Download-Tool.exe >>log.txt 2>&1
...
fixme:gdiplus:create_gdi_logbrush unhandled brush type 2
fixme:gdiplus:get_gdi_brush_color unhandled brush type 2
fixme:gdiplus:get_gdi_brush_color unhandled brush type 2
fixme:gdiplus:get_gdi_brush_color unhandled brush type 2
fixme:gdiplus:create_gdi_logbrush unhandled brush type 2
...
--- snip ---

'winetricks -q gdiplus' works around.

$ sha1sum Windows7-USB-DVD-tool.exe 
ed1108a525066d1f850023cb5bfa05fc4ed21983  Windows7-USB-DVD-tool.exe

$ du -sh Windows7-USB-DVD-tool.exe 
2.6M    Windows7-USB-DVD-tool.exe

$ wine --version
wine-1.7.20

Regards

[Bug 36742] Windows 7 USB/DVD download tool shows transparent controls (missing 'BrushTypeTextureFill' support)

https://bugs.winehq.org/show_bug.cgi?id=36742

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |dotnet, download
                URL|                            |http://www.microsoftstore.c
                   |                            |om/store/msusa/html/pbPage.
                   |                            |Help_Win7_usbdvd_dwnTool

[Bug 36742] Windows 7 USB/DVD download tool shows transparent controls (missing 'BrushTypeTextureFill' support)

https://bugs.winehq.org/show_bug.cgi?id=36742

--- Comment #1 from Anastasius Focht  ---
Created attachment 48792
  --> https://bugs.winehq.org/attachment.cgi?id=48792
convert bug36742-gdiplus-builtin.png bug36742-gdiplus-native.png -gravity west
-background none -append bug36742.png

[Bug 36742] Windows 7 USB/DVD download tool shows transparent controls (missing 'BrushTypeTextureFill' support)

http://bugs.winehq.org/show_bug.cgi?id=36742

Vincent Povirk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Vincent Povirk  ---
It's not possible to create a gdi brush that accurately represents a texture
fill. We should fix whatever's calling create_gdi_logbrush/create_gdi_brush so
that it doesn't need to do that.

What exported function is causing this FIXME?

[Bug 36742] Windows 7 USB/DVD download tool shows transparent controls (missing 'BrushTypeTextureFill' support)

http://bugs.winehq.org/show_bug.cgi?id=36742

--- Comment #3 from Anastasius Focht  ---
Hello Vincent,

--- quote ---
We should fix whatever's calling create_gdi_logbrush/create_gdi_brush so that
it doesn't need to do that.

What exported function is causing this FIXME?
--- quote ---

Debugger:

--- snip ---
Stopped on breakpoint 2 at 0x7e066a66 create_gdi_logbrush+0xa0
[/home/focht/projects/wine/wine.repo/src/dlls/gdiplus/graphics.c:194] in
gdiplus
194                FIXME("unhandled brush type %d\n", brush->bt);

Wine-dbg>bt
Backtrace:

=>0 0x7e066a66 create_gdi_logbrush+0xa0(brush=0x2c56610, lb=0x33df58)
[/home/focht/projects/wine/wine.repo/src/dlls/gdiplus/graphics.c:194] in
gdiplus (0x0033ded8)

1 0x7e066e2a prepare_dc+0x2d5(graphics=0x2c4df60, pen=0x2c56548)
[/home/focht/projects/wine/wine.repo/src/dlls/gdiplus/graphics.c:273] in
gdiplus (0x0033df98)

2 0x7e0710fc GdipDrawPath+0x117(graphics=<couldn't compute location>,
pen=<couldn't compute location>, path=<couldn't compute location>)
[/home/focht/projects/wine/wine.repo/src/dlls/gdiplus/graphics.c:3287] in
gdiplus (0x0033dff8)

3 0x7e071536 GdipDrawRectangle+0x12c(graphics=<couldn't compute location>,
pen=<couldn't compute location>, x=<couldn't compute location>, y=<couldn't
compute location>, width=<couldn't compute location>, height=<couldn't compute
location>)
[/home/focht/projects/wine/wine.repo/src/dlls/gdiplus/graphics.c:3361] in
gdiplus (0x0033e078)

4 0x7e07161d GdipDrawRectangleI+0xc2(graphics=<couldn't compute location>,
pen=<couldn't compute location>, x=<couldn't compute location>, y=<couldn't
compute location>, width=<couldn't compute location>, height=<couldn't compute
location>)
[/home/focht/projects/wine/wine.repo/src/dlls/gdiplus/graphics.c:3372] in
gdiplus (0x0033e0e8)

5 0x049b2661 (0x0033e124)
  6 0x7adfdb76 in system.drawing.ni (+0x1db75) (0x0094fdf4)
  7 0x00000000 (0x7ae778e8)
  8 0x00000024 (0x021c0000)
--- snip ---

$ wine --version
wine-1.7.20-122-gd2d62cf

Regards

[Bug 36742] Windows 7 USB/DVD download tool shows transparent controls ( missing 'BrushTypeTextureFill' support)

https://bugs.winehq.org/show_bug.cgi?id=36742

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |0914f626af73b6fb10826178d67
                   |                            |36a873113fc84

--- Comment #4 from Anastasius Focht  ---
Hello folks,

revisiting, this was fixed some time ago by commits:

*
https://source.winehq.org/git/wine.git/commitdiff/399fd55f5c4e7668b286f92cf4...
*
https://source.winehq.org/git/wine.git/commitdiff/0914f626af73b6fb10826178d6...

Thanks Vincent

--- snip ---
$ rm -rf ~/.wine
$ export WINEARCH=win32

$ winetricks -q dotnet20

# work around bug #6194
$ mkdir -p
~/.wine/drive_c/windows/system32/catroot/{F750E6C3-38EE-11D1-85E5-00C04FC295EE}

$ wget https://github.com/Winetricks/winetricks/raw/master/files/winetest.cat
-O
~/.wine/drive_c/windows/system32/catroot/{F750E6C3-38EE-11D1-85E5-00C04FC295EE}/oem0.cat

# work around bug #35041
$ taskset -c 0 wine ./WindowsXP-KB932716-v2-x86-ENU.exe
# work around bug #16876
^C

# work around bug #36646
$ wine msiexec -i Wudt.msi

$ wine ./Windows7-USB-DVD-Download-Tool.exe
--- snip ---

Original download(s) seem to be broken but I have a copy in my git-annex for
reproduce.

--- snip ---
$ git annex get *
get Windows7-USB-DVD-tool.exe (from backup...) 
SHA1E-s2721168--ed1108a525066d1f850023cb5bfa05fc4ed21983.exe
      2,721,168 100%  116.54MB/s    0:00:00 (xfr#1, to-chk=0/1)
(checksum...) ok
get WindowsXP-KB932716-v2-x86-ENU.exe (from backup...) 
SHA1E-s774184--9f8f8369716f6100ea04b6549aaf8e2a22fb0042.exe
        774,184 100%  117.84MB/s    0:00:00 (xfr#1, to-chk=0/1)
(checksum...) ok
get Wudt.msi (from backup...) 
SHA1E-s2878976--463b4798752072a0af6dbcd7b98f6d6b1b813b14.msi
      2,878,976 100%  108.57MB/s    0:00:00 (xfr#1, to-chk=0/1)
(checksum...) ok
(recording state in git...)
--- snip ---

$ wine --version
wine-3.13

Regards

[Bug 36742] Windows 7 USB/DVD download tool shows transparent controls ( missing 'BrushTypeTextureFill' support)

https://bugs.winehq.org/show_bug.cgi?id=36742

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 3.14.

[Bug 36742] Windows 7 USB/DVD download tool shows transparent controls (missing 'BrushTypeTextureFill' support)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=36742

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://www.microsoftstore.c |https://web.archive.org/web
                   |om/store/msusa/html/pbPage. |/20140214210531/http://imag
                   |Help_Win7_usbdvd_dwnTool    |es2.store.microsoft.com/pro
                   |                            |d/clustera/framework/w7udt/
                   |                            |1.0/en-us/Windows7-USB-DVD-
                   |                            |tool.exe