[Bug 16727] New: r1gl fails to request wgl features such as multi sampling

http://bugs.winehq.org/show_bug.cgi?id=16727

Summary: r1gl fails to request wgl features such as multi
                    sampling
           Product: Wine
           Version: 1.1.11
          Platform: PC-x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: opengl
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

using the Quake 2 client r1q2 with its r1gl renderer i get the following errors
when r1gl is trying to request multi sampling

the source for both the client and renderer is linked here

http://www.r1ch.net/stuff/r1q2/src/r1q2-b7904-src.zip

r1gl is in the opengl folder.

[Bug 16727] r1gl fails to request wgl features such as multi sampling

http://bugs.winehq.org/show_bug.cgi?id=16727

--- Comment #1 from Lemonzest   2009-01-02 11:37:38 ---
Created an attachment (id=18399)
 --> (http://bugs.winehq.org/attachment.cgi?id=18399)
+wgl trace

[Bug 16727] r1gl fails to request wgl features such as multi sampling

http://bugs.winehq.org/show_bug.cgi?id=16727

--- Comment #2 from Lemonzest   2009-01-02 11:37:59 ---
Created an attachment (id=18400)
 --> (http://bugs.winehq.org/attachment.cgi?id=18400)
glxinfo

[Bug 16727] r1gl fails to request wgl features such as multi sampling

http://bugs.winehq.org/show_bug.cgi?id=16727

--- Comment #3 from Lemonzest   2009-01-02 11:52:50 ---
Created an attachment (id=18401)
 --> (http://bugs.winehq.org/attachment.cgi?id=18401)
+wgl trace from World of warcraft in opengl mode, where multi sample request is
successful

[Bug 16727] r1gl fails to request wgl features such as multi sampling

http://bugs.winehq.org/show_bug.cgi?id=16727

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 16727] r1gl fails to request wgl features such as multi sampling

http://bugs.winehq.org/show_bug.cgi?id=16727

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |source

[Bug 16727] r1gl fails to request wgl features such as multi sampling

http://bugs.winehq.org/show_bug.cgi?id=16727

Roderick Colenbrander  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Roderick Colenbrander   2009-05-16 04:43:09 ---
(In reply to comment #3)
> Created an attachment (id=18401)

--> (http://bugs.winehq.org/attachment.cgi?id=18401) [details]
> +wgl trace from World of warcraft in opengl mode, where multi sample request is
> successful

Commenting the following two lines in dlls/winex11.drv/opengl.c should fix the
issue I think:
  PUSH2(oGLXAttr, GLX_RENDER_TYPE, pixelattrib);
  TRACE("pAttr[?] = GLX_RENDER_TYPE: %#x\n", pixelattrib);
To:
//  PUSH2(oGLXAttr, GLX_RENDER_TYPE, pixelattrib);
//  TRACE("pAttr[?] = GLX_RENDER_TYPE: %#x\n", pixelattrib);

This is some code which I added a long time ago to fix other issues but perhaps
it is either not correct or there is a bug in the ati drivers. I need to write
some tests.

Roderick

[Bug 16727] r1gl fails to request wgl features such as multi sampling

http://bugs.winehq.org/show_bug.cgi?id=16727

--- Comment #5 from Roderick Colenbrander   2009-11-14 11:18:50 ---
Could you check if this issue still occurs? I have recently changed this code
and I think the issue should be over now.

Roderick

[Bug 16727] r1gl fails to request wgl features such as multi sampling

http://bugs.winehq.org/show_bug.cgi?id=16727

Roderick Colenbrander  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Roderick Colenbrander   2009-11-15 16:20:54 ---
I did some further testing (not in the apps reported here) and I'm convinced
that the issue is over. If the issue is still around re-open the bug.

[Bug 16727] r1gl fails to request wgl features such as multi sampling

http://bugs.winehq.org/show_bug.cgi?id=16727

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard   2009-12-04 12:15:50 ---
Closing bugs fixed in 1.1.34.