[Bug 23949] New: MPQEdit: Error messages appear under the active window

http://bugs.winehq.org/show_bug.cgi?id=23949

Summary: MPQEdit: Error messages appear under the active window
           Product: Wine
           Version: 1.3.0
          Platform: x86
               URL: http://zezula.net/download/mpqediten32_beta.zip
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=30066)
 --> (http://bugs.winehq.org/attachment.cgi?id=30066)
Screenshot under windows

(afaik this affects a few other programs)

Download MPQEdit and run it with wine mpedit c:\

See attachment. The error message that's supposed to appear in front appears in
the back, which is excessively confusing.

[Bug 23949] MPQEdit: Error messages appear under the active window

http://bugs.winehq.org/show_bug.cgi?id=23949

--- Comment #1 from Jerome Leclanche   2010-08-09 05:42:21 ---

(01:22:19 PM) zezula: ah. Well, the error box is created by another thread than
the main UI thread. That is probably the problem. Seems like WINE cant have
that situation well
(01:22:40 PM) zezula: The entire threads versus windows stuff in total mess in
Windows
(01:23:00 PM) zezula: it somehow works properly, but I can imagine that WINE
might have troubles with it
(01:23:36 PM) zezula: the thing is, that MPQ Editor creates a window (i.e.
message box with the error message) from thread B, and makes it a child of the
progress window, which has been created by thread A

[Bug 23949] MPQEdit: Error messages appear under the active window

http://bugs.winehq.org/show_bug.cgi?id=23949

--- Comment #2 from Dmitry Timoshkov   2010-08-09 08:42:03 ---
Does the patch referenced in the bug 23940 help?

[Bug 23949] MPQEdit: Error messages appear under the active window

http://bugs.winehq.org/show_bug.cgi?id=23949

--- Comment #3 from Jerome Leclanche   2010-08-09 08:49:28 ---
(In reply to comment #2)
> Does the patch referenced in the bug 23940 help?

No change with that patch, no.

[Bug 23949] MPQEdit: Error messages appear under the active window

http://bugs.winehq.org/show_bug.cgi?id=23949

--- Comment #4 from Jerome Leclanche   2010-08-10 03:47:56 ---
Created an attachment (id=30082)
 --> (http://bugs.winehq.org/attachment.cgi?id=30082)
Not-so-test case

(09:34:33 AM) zezula: well, all error codes are generated by the same code:

// Open the archive
            if(!SFileOpenArchive(szMpqName, 0, dwFlags, &hMpq))
            {
                nError = MessageBoxError(hWorkerDlg, IDS_E_CANT_OPEN_MPQ,
GetLastError(), szMpqName);
                break;
            }

The author was kind enough to write a testcase, unfortunately it didn't display
that behaviour. Still, here is the code and exe if anyone is interested and
feels like using it to try and reproduce the issue.

Note that only some error messages appear under the active window; eg opening a
folder or non-existing file. Opening a bad-format file doesn't generate an
error.

[Bug 23949] MPQEdit: Error messages appear under the active window

http://bugs.winehq.org/show_bug.cgi?id=23949

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
          Component|-unknown                    |user32

[Bug 23949] MPQEdit: Error messages appear under the active window

http://bugs.winehq.org/show_bug.cgi?id=23949

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|user32                      |-unknown

--- Comment #5 from Dmitry Timoshkov   2010-08-17 02:07:57 ---
Probably a WM bug.

[Bug 23949] MPQEdit: Error messages appear under the active window

http://bugs.winehq.org/show_bug.cgi?id=23949

--- Comment #6 from Jerome Leclanche   2010-08-17 02:14:40 ---
I can't repro anymore for some weird reason ... Marking INVALID, I'll reopen if
i can get it to repro again.

Dmitry, I can't confirm this anymore but I'm positive I tested this in metacity
with no luck.

[Bug 23949] MPQEdit: Error messages appear under the active window

http://bugs.winehq.org/show_bug.cgi?id=23949

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |INVALID

--- Comment #7 from Jerome Leclanche   2010-08-17 02:14:58 ---
Invalid.

[Bug 23949] MPQEdit: Error messages appear under the active window

http://bugs.winehq.org/show_bug.cgi?id=23949

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Jerome Leclanche   2010-08-17 02:15:06 ---
Closing..