[Bug 36564] New: 'Candytron' demo: certain objects are black with GLSL enabled

http://bugs.winehq.org/show_bug.cgi?id=36564

Bug ID: 36564
           Summary: 'Candytron' demo: certain objects are black with GLSL
                    enabled
           Product: Wine
           Version: 1.6-rc1
          Hardware: x86
               URL: http://www.pouet.net/prod.php?which=9424
                OS: Linux
            Status: NEW
          Keywords: download, regression
          Severity: trivial
          Priority: P2
         Component: directx-d3d
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: 2014141a253a791fc9c79aae3c8ef3c35b73e658

Created attachment 48657
  --> http://bugs.winehq.org/attachment.cgi?id=48657
screenshot (comparison)

Some of the rectangles that appear in the demo nearly at 00:30 and at 01:10 are
black. They should appear as glowing green rectangles as can be seen in the
attached screenshot.
Terminal output doesn't reveal anything interesting.
Disabling GLSL is a workaround.

This is a regression from Wine 1.6-rc1:

2014141a253a791fc9c79aae3c8ef3c35b73e658 is the first bad commit
commit 2014141a253a791fc9c79aae3c8ef3c35b73e658
Author: Henri Verbeet 
Date:   Wed May 29 09:45:35 2013 +0200

wined3d: Add support for GLSL based fixed function vertex shaders.

:040000 040000 d1b4b75f643d4851d4f51454aa47740261f7857f
c46794f61b1952b1e78746272d838574c0948010 M    dlls

Fedora 20
Nvidia 250 gfx card / Nvidia binary drivers 337.19
wine-1.7.19-70-gd6a59f7

[Bug 36564] 'Candytron' demo: certain objects are black with GLSL enabled

https://bugs.winehq.org/show_bug.cgi?id=36564

--- Comment #1 from Béla Gyebrószki  ---
Still present in wine-1.7.43-25-g0d91274

Nvidia binary drivers 340.76

[Bug 36564] 'Candytron' demo: certain objects are black with GLSL enabled

https://bugs.winehq.org/show_bug.cgi?id=36564

--- Comment #2 from Béla Gyebrószki  ---
Still present in 1.8-rc1.
Disabling GLSL works around the problem with the binary drivers (340.96), but
not with Nouveau.

[Bug 36564] 'Candytron' demo: certain objects are black with GLSL enabled

https://bugs.winehq.org/show_bug.cgi?id=36564

Sergey Isakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Sergey Isakov  ---
I confirm the bug in MacOSX with Radeon, wine-1.9.
Those bricks are black no matter GLSL enabled or no.
I see some dark green shadow on them?

[Bug 36564] 'Candytron' demo: certain objects are black with GLSL enabled

https://bugs.winehq.org/show_bug.cgi?id=36564

--- Comment #4 from Sergey Isakov  ---
Enabling GLSL gives me additional errors in log
~~~
fixme:d3d_shader:print_glsl_info_log Info log received from GLSL shader #3:
fixme:d3d_shader:print_glsl_info_log     WARNING: Could not find vertex shader
attribute 'vs_in7' to match BindAttributeLocation request.
fixme:d3d_shader:print_glsl_info_log Info log received from GLSL shader #6:
fixme:d3d_shader:print_glsl_info_log     WARNING: Could not find vertex shader
attribute 'vs_in7' to match BindAttributeLocation request.
fixme:d3d_shader:print_glsl_info_log Info log received from GLSL shader #10:
fixme:d3d_shader:print_glsl_info_log     WARNING: Could not find vertex shader
attribute 'vs_in7' to match BindAttributeLocation request.
~~

Also I see girl face is brighter then with GLSL disabled.

[Bug 36564] 'Candytron' demo: certain objects are black with GLSL enabled

https://bugs.winehq.org/show_bug.cgi?id=36564

--- Comment #5 from Sergey Isakov  ---
The bug is wrong.
I just tested the game in real Windows 7 Sp1. Nvidia Geforce 7300LE.
Those bricks looked the same as in Wine, they are black with slight green
shadows.

[Bug 36564] 'Candytron' demo: certain objects are black with GLSL enabled

https://bugs.winehq.org/show_bug.cgi?id=36564

--- Comment #6 from Béla Gyebrószki  ---
(In reply to Sergey Isakov from comment #5)
> The bug is wrong.
> I just tested the game in real Windows 7 Sp1. Nvidia Geforce 7300LE.
> Those bricks looked the same as in Wine, they are black with slight green
> shadows.

Probably invalid then. I can't test it under real Windows.

Henri Verbeet, what's your opinion on this bug, is it worth keeping it alive?

wine-1.9.15-197-g9ef65cf
OpenGL vendor string: NVIDIA Corporation
OpenGL renderer string: GeForce GT 730/PCIe/SSE2
OpenGL core profile version string: 4.5.0 NVIDIA 367.35
OpenGL core profile shading language version string: 4.50 NVIDIA

[Bug 36564] 'Candytron' demo: certain objects are black with GLSL enabled

https://bugs.winehq.org/show_bug.cgi?id=36564

--- Comment #7 from Henri Verbeet  ---
(In reply to Béla Gyebrószki from comment #6)
> (In reply to Sergey Isakov from comment #5)
> > The bug is wrong.
> > I just tested the game in real Windows 7 Sp1. Nvidia Geforce 7300LE.
> > Those bricks looked the same as in Wine, they are black with slight green
> > shadows.
>
> Probably invalid then. I can't test it under real Windows.
>
> Henri Verbeet, what's your opinion on this bug, is it worth keeping it alive?

I'm not sure, it does sounds like a legitimate regression. I suspect it might
be related to the issue with multiplications of infinities by zeroes, perhaps
in the fixed function lighting code, but I can't reproduce the issue here (AMD
CAYMAN, Mesa). I do have a different issue that looks like what's described in
bug 22785, but that doesn't help for this bug, of course.

[Bug 36564] 'Candytron' demo: certain objects are black with GLSL enabled

https://bugs.winehq.org/show_bug.cgi?id=36564

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from [e-mail] ---
This bug happens in Subterrain.

The game is a top down game and when GLSL is set to "glsl=disabled" via
winetricks, the shadows that are behind the character have this sort of smokey
effect. With GLSL enabled, they are solid black.

I will post comparison screenshots as soon as I get home from work.

[Bug 36564] 'Candytron' demo: certain objects are black with GLSL enabled

https://bugs.winehq.org/show_bug.cgi?id=36564

--- Comment #9 from [e-mail] ---
Created attachment 55232
  --> https://bugs.winehq.org/attachment.cgi?id=55232
Subterrain with GLSL disabled

This screenshot shows the smoky effect behind the player's character (the red
arrows are by me). That smoky effect becomes solid black with GLSL enabled.

[Bug 36564] 'Candytron' demo: certain objects are black with GLSL enabled

https://bugs.winehq.org/show_bug.cgi?id=36564

--- Comment #10 from Sergey Isakov  ---
> ... but I can't reproduce the issue
> here (AMD CAYMAN, Mesa). I do have a different issue that looks like what's
> described in bug 22785, but that doesn't help for this bug, of course.

Resume my observations.

Nvidia Geforce 7300LE
Wine any version
Windows 7 SP1 full update, full library set (Directx, .Net, VC2015....)
- No glowing

AMD Radeon HD6670
Wine recent
- Yes glowing

[Bug 36564] 'Candytron' demo: certain objects are black with GLSL enabled

https://bugs.winehq.org/show_bug.cgi?id=36564

joaopa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from joaopa  ---
Still a bug in current wine? (3.11)

[Bug 36564] 'Candytron' demo: certain objects are black with GLSL enabled

https://bugs.winehq.org/show_bug.cgi?id=36564

--- Comment #12 from Béla Gyebrószki  ---
(In reply to joaopa from comment #11)
> Still a bug in current wine? (3.11)

Yep.

wine-3.11-150-g80205232d3
OpenGL vendor string: NVIDIA Corporation
OpenGL renderer string: GeForce GT 730/PCIe/SSE2
OpenGL core profile version string: 4.6.0 NVIDIA 396.24

[Bug 36564] 'Candytron' demo: certain objects are black with GLSL enabled

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=36564

--- Comment #13 from joaopa  ---
Does the bug still occur with wine-5.0-rc1?

[Bug 36564] 'Candytron' demo: certain objects are black with GLSL enabled

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=36564

Oleg Kuznetsov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #14 from Oleg Kuznetsov  ---
(In reply to joaopa from comment #13)
> Does the bug still occur with wine-5.0-rc1?

I see the black cubes on wine-5.0 (AMD Radeon 7790 / Mesa 18.3.4), but I think
that this ticket is actually a duplicate of bug 22785

[Bug 36564] 'Candytron' demo: certain objects are black with GLSL enabled

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=36564

--- Comment #15 from joaopa  ---
Bug still occurs with wine-6.21.

[Bug 36564] 'Candytron' demo: certain objects are black with GLSL enabled

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=36564

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://www.pouet.net/prod.p |https://web.archive.org/web
                   |hp?which=9424               |/20180811011536if_/http://a
                   |                            |rchive.scene.org/pub/demos/
                   |                            |groups/farbrausch/fr-030_ca
                   |                            |ndytron_final.zip

--- Comment #16 from Gijs Vermeulen  ---
Adding stable download.

$ sha1sum fr-030_candytron_final.zip
1f2f465fa4abd1482ecfe45f13d96efc66ef53cf  fr-030_candytron_final.zip

$ du -sh fr-030_candytron_final.zip
72K    fr-030_candytron_final.zip

[Bug 36564] 'Candytron' demo: certain objects are black with GLSL enabled

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=36564

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #17 from Zebediah Figura  ---
Created attachment 71398
  --> https://bugs.winehq.org/attachment.cgi?id=71398
catch zero normals

The normals for the relevant objects are zero, which results in NaN when we try
to normalize them. The attached patch seems to fix them. I'm not sure how we
want to handle this in general, though.

[Bug 36564] 'Candytron' demo: certain objects are black with GLSL enabled

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=36564

Petrichor Park  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #18 from Petrichor Park  ---
I have a merge request going that fixes this:

https://gitlab.winehq.org/wine/wine/-/merge_requests/3419

[Bug 36564] 'Candytron' demo: certain objects are black with GLSL enabled

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=36564

Zeb Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |b79c4e7de60d63aec257764d20c
                   |                            |fe69f9943c81b
             Status|NEW                         |RESOLVED

--- Comment #19 from Zeb Figura  ---
Fixed by
https://source.winehq.org/git/wine.git/commitdiff/b79c4e7de60d63aec257764d20cfe69f9943c81b.

[Bug 36564] 'Candytron' demo: certain objects are black with GLSL enabled

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=36564

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #20 from Alexandre Julliard  ---
Closing bugs fixed in 8.14.