[Bug 49591] New: Multiple GOG installers display the error message "Out of Global Vars range"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49591

Bug ID: 49591
           Summary: Multiple GOG installers display the error message "Out
                    of Global Vars range"
           Product: Wine
           Version: 5.12
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

(This isn't a new issue, but I couldn't find any existing bug reports about
this)

This doesn't prevent the installers from working, as it only pops up at the end
of the installation, so it's not a major issue.

The smallest installer for a free game I could find (so far) that can reproduce
this issue is Stargunner: https://www.gog.com/game/stargunner . There are other
smaller installers (such as Ultima 4), but they don't contain this issue (at
least not when I tested them).

Looking at the GOG log (C:/users/.../Temp/Setup Log ...), these lines look
relevant:

--- snip ---
CurStepChanged raised an exception.
Exception message:
Message box (OK):
Runtime Error (at 73:1379):
--- snip ---
Current Page: Finished
Exception message:
Message box (OK):
Runtime Error (at 211:814):

Out of Global Vars range.
--- snip ---
Exception message:
Message box (OK):
Invalid Opcode.
--- snip ---

Looking at the wine log:

--- snip ---
1384816.651:00cc:00d0:trace:nls:MultiByteToWideChar cp 1252 "Out of Global Vars
range" -> L"Out of Global Vars range", ret = 24
1384816.651:00cc:00d0:Ret  KERNEL32.MultiByteToWideChar() retval=00000018
ret=00405449
1384816.651:00cc:00d0:Call
KERNEL32.RaiseException(0eedfade,00000001,00000007,0031dca8) ret=004a0c4b
1384816.652:00cc:00d0:trace:seh:raise_exception code=eedfade flags=1
addr=0x7b00f787 ip=7b00f787 tid=00d0
--- snip ---

I'm not quite sure what is the cause of the issue yet. There are multiple other
eedfade (pascal) exceptions, but I don't believe they are related (one is due
to trying to access c:\gog games\Stargunner\goglog.ini, which doesn't exist,
another is due to trying to access a non-existing CLSID in HKEY_CLASSES_ROOT)

[Bug 49591] Multiple GOG installers display the error message "Out of Global Vars range"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49591

--- Comment #1 from qsniyg  ---
I've done a bit more digging. After disassembling their innosetup code (using
https://github.com/Wack0/IFPSTools, note that it prints out non-utf8
characters, so use an editor like emacs to be able to view the file), it's
possible to trace where it fails:

Functions[212] = exported void CURSTEPCHANGED(in TSETUPSTEP Arg1)
        ...
        call REMOVEDEADSHORTCUTS

...

Functions[72] = exported void REMOVEDEADSHORTCUTS(in UnicodeString Arg1)
        ...
        call GETSHELLLINKTARGET

...

Functions[73] = exported BOOLEAN GETSHELLLINKTARGET(in UnicodeString Arg1,out
UnicodeString Arg2)
        ...
        pushtype String ; StackCount = 9
        assign Var9, ( String "GetLink" )
        pushtype BOOLEAN ; StackCount = 10
        assign Var10, ( U8 0 )
        pushtype IDISPATCH ; StackCount = 11
        assign Var11, Var4
        pushvar Var5 ; StackCount = 12
        call IDISPATCHINVOKE

In the wine log, we can see:

1384814.814:00cc:00d0:fixme:shell:FolderItemImpl_get_GetLink
(0xca0a68,0x31cec0)
...
1384814.814:00cc:00d0:warn:ole:ITypeInfo_fnInvoke Format is: "invoked function
failed with error 0x%08x\n"

[Bug 49591] Multiple GOG installers display the error message "Out of Global Vars range"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49591

Anya  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 49591] Multiple GOG installers display the error message "Out of Global Vars range"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49591

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 49591] Multiple GOG installers display the error message "Out of Global Vars range"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49591

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 49591] Multiple GOG installers display the error message "Out of Global Vars range"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49591

--- Comment #2 from [e-mail] ---
Yeah, this errors are extremely annoying, especially in small installers (for
DLC, for example. You don't even noticed that anything happened, but there an
error message already). One of reasons i want to move my games collection to
steam. I guess, it can be especially tough for new users (you're trying to
install you favorite game, get an error for no reason and have no idea that it
actually worked). Please fix it, wine team!

[Bug 49591] Multiple GOG installers display the error message "Out of Global Vars range"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49591

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |shell32

--- Comment #3 from Nikolay Sivov  ---
Looks like we don't have scriptable shelllink object too, setting component.

[Bug 49591] Multiple GOG installers display the error message "Out of Global Vars range"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49591

--- Comment #4 from qsniyg  ---
(In reply to Nikolay Sivov from comment #3)
> Looks like we don't have scriptable shelllink object too, setting component.

Currently working on this, will hopefully send an initial patch today :)

[Bug 49591] Multiple GOG installers display the error message "Out of Global Vars range"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49591

qsniyg  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from qsniyg  ---
Fixed by
https://source.winehq.org/git/wine.git/commit/4c99e3ef341a6b4eda67dffa13a868...

Note that this may not fix all "Out of Global Vars range" issues, as it appears
to be a generic crash message.

However it fixes the issue with Stargunner, as well as a number of other GOG
installers I've tested.

[Bug 49591] Multiple GOG installers display the error message "Out of Global Vars range"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49591

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |4c99e3ef341a6b4eda67dffa13a
                   |                            |86829fa343bbb

[Bug 49591] Multiple GOG installers display the error message "Out of Global Vars range"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49591

--- Comment #6 from [e-mail] ---
Thanks!

[Bug 49591] Multiple GOG installers display the error message "Out of Global Vars range"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49591

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  ---
Closing bugs fixed in 5.18.

[Bug 49591] Multiple GOG installers display the error message "Out of Global Vars range"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49591

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |5.0.x

[Bug 49591] Multiple GOG installers display the error message "Out of Global Vars range"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49591

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|5.0.x                       |---

--- Comment #8 from Michael Stefaniuc  ---
Removing the 5.0.x milestone from bug fixes included in 5.0.4.