[Bug 21046] New: cmd does not handle all operators in 'if' command

http://bugs.winehq.org/show_bug.cgi?id=21046

Summary: cmd does not handle all operators in 'if' command
           Product: Wine
           Version: 1.1.34
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: programs
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

bug 15359 mentions that firefox's build scripts use commands like
  IF %ERRORLEVEL% EQU 0
wine's cmd only supports == and != operators;
windows' cmd also supports equ, neq, lss, leq, gtr, geq.

[Bug 21046] cmd does not handle all operators in 'if' command

http://bugs.winehq.org/show_bug.cgi?id=21046

--- Comment #1 from Austin English   2009-12-23 13:31:14 ---
!= is not supported:

C:\Documents and Settings\austin\Desktop>if %ERRORLEVEL% != 0 echo foo
!= was unexpected at this time.

The rest are though. Also, see:
http://ss64.com/nt/if.html

[Bug 21046] cmd does not handle all operators in 'if' command

http://bugs.winehq.org/show_bug.cgi?id=21046

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
                 CC|                            |[e-mail]

[Bug 21046] cmd does not handle all operators in 'if' command

http://bugs.winehq.org/show_bug.cgi?id=21046

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|programs                    |cmd

[Bug 21046] cmd does not handle all operators in 'if' command

http://bugs.winehq.org/show_bug.cgi?id=21046

Jason Edmeades  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Jason Edmeades   2010-01-06 18:26:40 ---
Adding myself to the cmd bugs

[Bug 21046] cmd does not handle all operators in 'if' command

http://bugs.winehq.org/show_bug.cgi?id=21046

--- Comment #3 from Dan Kegel   2010-07-19 23:24:03 ---
Some patches were posted earlier this year as part of a college project:
http://www.winehq.org/pipermail/wine-patches/2010-March/085912.html
http://www.winehq.org/pipermail/wine-patches/2010-March/085913.html
http://www.winehq.org/pipermail/wine-patches/2010-March/085923.html
but the author seems to have lost interest when the term ended.

[Bug 21046] cmd does not handle all operators in 'if' command

http://bugs.winehq.org/show_bug.cgi?id=21046

Frédéric Delanoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch, source
                 CC|                            |[e-mail]

[Bug 21046] cmd does not handle all operators in 'if' command

http://bugs.winehq.org/show_bug.cgi?id=21046

--- Comment #4 from Frédéric Delanoy  2011-11-08 14:17:31 CST ---
Created attachment 37384
  --> http://bugs.winehq.org/attachment.cgi?id=37384
operators implementation + tests

Tentative implementation with unit tests.
Apparently needs "more thought" (or maybe a preliminary re-implementation of
whole cmd parsing code)
Volunteers are welcome.

[Bug 21046] cmd does not handle all operators in 'if' command

http://bugs.winehq.org/show_bug.cgi?id=21046

Frédéric Delanoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |90c6f57fa9d9c9caf1b469ae82e
                   |                            |d13bccb9625ef
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Frédéric Delanoy  2012-10-26 12:14:37 CDT ---
Fixed by a series of patches ending with
90c6f57fa9d9c9caf1b469ae82ed13bccb9625ef

[Bug 21046] cmd does not handle all operators in 'if' command

http://bugs.winehq.org/show_bug.cgi?id=21046

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  2012-10-26 13:29:41 CDT ---
Closing bugs fixed in 1.5.16.