[Bug 28029] New: Gunz launcher runs explorer instead of the game's launcher

http://bugs.winehq.org/show_bug.cgi?id=28029

Summary: Gunz launcher runs explorer instead of the game's
                    launcher
           Product: Wine
           Version: 1.3.26
          Platform: x86
               URL: http://www.joystiq.com/game/gunz/download/gunz-install
                    -client
        OS/Version: Linux
            Status: NEW
          Keywords: download, regression
          Severity: normal
          Priority: P2
         Component: programs
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
            Blocks: 27187
   Regression SHA1: f2ac486e21c64b664dea527e2621e3c1d830c2cc

In 1.3.26, running the game just gives me wine explorer. Navigating to the
game's folder and running it just spawns another explorer process. This
regression is introduced by:
f2ac486e21c64b664dea527e2621e3c1d830c2cc is the first bad commit
commit f2ac486e21c64b664dea527e2621e3c1d830c2cc
Author: Jay Yang 
Date:   Sat Jun 11 17:42:17 2011 -0400

explorer: Implement the explorer using IExplorerBrowser.

:100755 100755 245662417f5b96af4b08fb7fba94da7bfbb36c46
92586f2956db58a1fe22968f6da2bcae852558e7 M    configure
:100644 100644 2ae64f76ee7ad8188ec8b0fa23b75827fe68bd1a
2e20f247eaea13e8c1734272d0b544925aa83702 M    configure.ac
:040000 040000 9e5f008abcd649512b8e8a88c4dda0cd9fcdbc12
87e53bded817fbadde69b6960ff8837e2756c7f5 M    po
:040000 040000 fefa521ab7aae08b5eaa8189196be6e5723c89c1
f0c19b54fbe02ee23a408b31947aa7efec434c9c M    programs

See also bug 27187.

[Bug 28029] Gunz launcher runs explorer instead of the game's launcher

http://bugs.winehq.org/show_bug.cgi?id=28029

--- Comment #1 from Austin English  2011-08-08 17:07:32 CDT ---
Terminal output is short:
austin@aw25 ~/.wine/drive_c/ijji/ENGLISH/Gunz $ wine GunzLauncher.exe 
fixme:ieframe:PersistStreamInit_Load (0x132a80)->(0x33d4f8)
fixme:ieframe:OleControl_FreezeEvents (0x132a80)->(1)
fixme:ieframe:OleControl_FreezeEvents (0x132a80)->(0)
fixme:nstc:NSTC2_fnSetControlStyle2 mask & style (0x00000004) contains
unsupported style(s): 0x00000004
fixme:shell:IShellBrowser_fnSendControlMsg stub, 0x127b88 (2, 1026, a003, 0,
0x33f4c4)
fixme:shell:IShellBrowser_fnSendControlMsg stub, 0x127b88 (2, 1026, a004, 1,
0x33f4c4)
fixme:shell:IShellBrowser_fnSendControlMsg stub, 0x127b88 (2, 1025, a003, 1,
0x33f4c4)
fixme:shell:IShellBrowser_fnSendControlMsg stub, 0x127b88 (2, 1025, a004, 1,
0x33f4c4)
fixme:shell:IExtractIconW_fnExtract (0x130178) (file=0x7bcbef03 index=-35 (nil)
0x33f4b4 size=00000014) semi-stub
fixme:shell:IExtractIconW_fnExtract (0x1333e8) (file=0x7bcbebe8 index=-16 (nil)
0x33f4b4 size=00000014) semi-stub
fixme:shell:IExtractIconW_fnExtract (0x132e30) (file=0x7bcbec0e index=-235
(nil) 0x33f4b4 size=00000014) semi-stub
fixme:shell:IExtractIconW_fnExtract (0x1347a0) (file=0x7bcbec5f index=-33 (nil)
0x33f4b4 size=00000014) semi-stub
fixme:shell:IExtractIconW_fnExtract (0x133420) (file=0x7bcbec86 index=-9 (nil)
0x33f4b4 size=00000014) semi-stub
fixme:shell:IExtractIconW_fnExtract (0x132e10) (file=0x7bcbecac index=-4 (nil)
0x33f4b4 size=00000014) semi-stub

[Bug 28029] Gunz launcher runs explorer instead of the game's launcher

http://bugs.winehq.org/show_bug.cgi?id=28029

Jay Yang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Jay Yang  2011-08-08 20:57:17 CDT ---
I get this with 
WINEDEBUG=trace+process wine GunzLancher.exe

...
trace:process:create_process_impl app (null) cmdline L"explorer.exe
"http://gunz.ijji.com/?from=desktop%5C""
...

So it's asking explorer to open "http://gunz.ijji.com/?from=desktop" which is
clearly a web url. Windows responds to this by opening the website and that is
exactly the behavior I see on windows. I tested this using the installation
provided by the installer in the URL in the bug.

We should probably have explorer open the web browser in such cases seeing as
that's what windows does. I'm not certain what the best way to determine what
should be opened in a web browser is. We could look for things matching
[a-zA-Z]*:.* and send those request to a web browser.

[Bug 28029] Gunz launcher runs explorer instead of the game's launcher

http://bugs.winehq.org/show_bug.cgi?id=28029

Owen Rudge  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Owen Rudge  2011-08-09 05:20:13 CDT ---
(In reply to comment #2)
> So it's asking explorer to open "http://gunz.ijji.com/?from=desktop" which is
> clearly a web url. Windows responds to this by opening the website and that is
> exactly the behavior I see on windows. I tested this using the installation
> provided by the installer in the URL in the bug.
>
> We should probably have explorer open the web browser in such cases seeing as
> that's what windows does. I'm not certain what the best way to determine what
> should be opened in a web browser is. We could look for things matching
> [a-zA-Z]*:.* and send those request to a web browser.

For what it's worth, it looks as though explorer.exe simply tries to open
whatever it is passed on its command line (on Windows), not just URLs.
"explorer c:\windows\notepad.exe" will open Notepad. You perhaps want to test
if the argument is a valid filesystem path that leads to a directory/network
share, and open it in Explorer if so; otherwise pass it to ShellExecute.

[Bug 28029] Gunz launcher runs explorer instead of the game's launcher

http://bugs.winehq.org/show_bug.cgi?id=28029

--- Comment #4 from Owen Rudge  2011-08-09 05:21:26 CDT ---
And if ShellExecute fails, Explorer (on Windows 7 at least) just seems to open
the My Documents folder.

[Bug 28029] Gunz launcher runs explorer instead of the game's launcher

http://bugs.winehq.org/show_bug.cgi?id=28029

--- Comment #5 from Austin English  2011-08-31 13:33:38 CDT ---
http://source.winehq.org/git/wine.git/commitdiff/c268c40fdf0ecf904769ad2e7fb...
looks relevant, so I tried it in git:

austin@aw21 ~/.wine/drive_c/ijji/ENGLISH/Gunz $ wine --version
wine-1.3.27-152-g1103cb9

But still fails:
austin@aw21 ~/.wine/drive_c/ijji/ENGLISH/Gunz $ wine GunzLauncher.exe 
fixme:ieframe:PersistStreamInit_Load (0x1325b0)->(0x33d6f8)
fixme:ieframe:OleControl_FreezeEvents (0x1325b0)->(1)
fixme:ieframe:OleControl_FreezeEvents (0x1325b0)->(0)
wine: cannot find L"C:\windows\system32\?from=desktop".exe"
fixme:nstc:NSTC2_fnSetControlStyle2 mask & style (0x00000004) contains
unsupported style(s): 0x00000004
fixme:shell:IShellBrowser_fnSendControlMsg stub, 0x121e88 (2, 1026, a003, 0,
0x33f564)
fixme:shell:IShellBrowser_fnSendControlMsg stub, 0x121e88 (2, 1026, a004, 1,
0x33f564)
fixme:shell:IShellBrowser_fnSendControlMsg stub, 0x121e88 (2, 1025, a003, 1,
0x33f564)
fixme:shell:IShellBrowser_fnSendControlMsg stub, 0x121e88 (2, 1025, a004, 1,
0x33f564)
fixme:shell:IExtractIconW_fnExtract (0x12ff50) (file=0x7efff4c3 index=-35 (nil)
0x33f254 size=00000014) semi-stub
fixme:shell:IExtractIconW_fnExtract (0x133f78) (file=0x7efff1a8 index=-16 (nil)
0x33f254 size=00000014) semi-stub
fixme:shell:IExtractIconW_fnExtract (0x1338e8) (file=0x7efff1ce index=-235
(nil) 0x33f254 size=00000014) semi-stub
fixme:shell:IExtractIconW_fnExtract (0x1354d0) (file=0x7efff21f index=-33 (nil)
0x33f254 size=00000014) semi-stub
fixme:shell:IExtractIconW_fnExtract (0x135dd8) (file=0x7efff246 index=-9 (nil)
0x33f254 size=00000014) semi-stub
fixme:shell:IExtractIconW_fnExtract (0x133f38) (file=0x7efff26c index=-4 (nil)
0x33f254 size=00000014) semi-stub
fixme:shell:IExtractIconW_fnExtract (0x135db8) (file=0x7efff292 index=-4 (nil)
0x33f254 size=00000014) semi-stub

looking for '?from=desktop".exe"' doesn't look good..

[Bug 28029] Gunz launcher runs explorer instead of the game's launcher

http://bugs.winehq.org/show_bug.cgi?id=28029

--- Comment #6 from Nikolay Sivov  2012-01-29 15:54:28 CST ---
So it does:

---
002f:Call KERNEL32.WinExec(0043d78c "explorer.exe
"http://gunz.ijji.com/?from=desktop%5C%22%22,00000005) ret=00406832
---

after that parse_command_line() misinterprets argument string - it skips first
two slashes looking for known command switch, doesn't find it and what is left
is a part after '?':

---
0031:Call shell32.ShellExecuteW(00000000,00000000,0033f740
L"?from=desktop"",00000000,00000000,0000000a) ret=7ecacb10
---

that's a helper that should be fixed.

[Bug 28029] Gunz launcher runs explorer instead of the game's launcher

http://bugs.winehq.org/show_bug.cgi?id=28029

--- Comment #7 from Jay Yang  2012-01-29 16:14:56 CST ---
I sent a patch earlier this year with a fix, but it had some issues so I'm
currently rewriting it. I should be able to send a fixed version this week.

The last version of the patch is here if anyone is interested.
http://www.winehq.org/pipermail/wine-patches/2012-January/110435.html

[Bug 28029] Gunz launcher runs explorer instead of the game's launcher

http://bugs.winehq.org/show_bug.cgi?id=28029

--- Comment #8 from Nikolay Sivov  2012-01-29 16:25:45 CST ---
(In reply to comment #7)
> I sent a patch earlier this year with a fix, but it had some issues so I'm
> currently rewriting it. I should be able to send a fixed version this week.
>
> The last version of the patch is here if anyone is interested.
> http://www.winehq.org/pipermail/wine-patches/2012-January/110435.html

Good to know, thanks. There's something I don't like in it, mostly formatting,
but I'll wait for the next version to comment.

[Bug 28029] Gunz launcher runs explorer instead of the game's launcher

http://bugs.winehq.org/show_bug.cgi?id=28029

Frédéric Delanoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from Frédéric Delanoy  2013-06-30 13:48:40 CDT ---
Still in wine-1.6-rc4

[Bug 28029] Gunz launcher runs explorer instead of the game's launcher

http://bugs.winehq.org/show_bug.cgi?id=28029

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
                 CC|                            |[e-mail]

[Bug 28029] Gunz launcher runs explorer instead of the game's launcher

https://bugs.winehq.org/show_bug.cgi?id=28029

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://www.joystiq.com/game |http://cdn-files2.playeratt
                   |/gunz/download/gunz-install |ack.com/file/240168764700-8
                   |-client                     |0354901438400-5089765218720
                   |                            |0-40925725722/GunzInstaller
                   |                            |.exe
                 CC|                            |[e-mail]

--- Comment #10 from Anastasius Focht  ---
Hello folks,

still present.
Adjusting download to a valid one.

$ sha1sum GunzInstaller.exe 
du 2a0184fd0983be073c2f1af97534154066f2dcad  GunzInstaller.exe

$ du -sh GunzInstaller.exe 
211M    GunzInstaller.exe

$ wine --version
wine-1.7.19-56-gee13e10

Regards

[Bug 28029] Gunz launcher runs explorer instead of the game's launcher

https://bugs.winehq.org/show_bug.cgi?id=28029

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |9db3444e4070025162a87cce49c
                   |                            |a7fe9ef44ce56
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from Alexandre Julliard  ---
It should be fixed by 9db3444e4070025162a87cce49ca7fe9ef44ce56.

[Bug 28029] Gunz launcher runs explorer instead of the game's launcher

https://bugs.winehq.org/show_bug.cgi?id=28029

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #12 from Alexandre Julliard  ---
Closing bugs fixed in 1.8-rc2.