[Bug 54164] New: MSI Disk Usage not displaying drives

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54164

Bug ID: 54164
           Summary: MSI Disk Usage not displaying drives
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: other
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: msi
          Assignee: [e-mail]
          Reporter: [e-mail]

Created attachment 73689
  --> https://bugs.winehq.org/attachment.cgi?id=73689
Fix (tested patch)

Disk Costing shows an empty list for Terragen 3.4 msi installer

Problem comes from msi_dialog_vcl_add_columns function

This function exits if a width block is not a valid number

/* the width must be a positive number
         * if a width is invalid, all remaining columns are hidden
         */
this works fine in most cases BUT it should "continue" rather than exist to
manage case where the 1st field is used to specify "font" to be used

(see Orca extract from Terragen.msi table)

{ VSI_MS_Sans_Serif13.0_0_0} {116} {80} {80} {80}

[Bug 54164] MSI Disk Usage not displaying drives

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54164

Kyle_Katarn  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://jira.reactos.org/br
                   |                            |owse/CORE-18749

[Bug 54164] MSI Disk Usage not displaying drives

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54164

--- Comment #1 from Kyle_Katarn  ---
Created attachment 73811
  --> https://bugs.winehq.org/attachment.cgi?id=73811
Better fix

[Bug 54164] MSI Disk Usage not displaying drives

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54164

--- Comment #2 from Kyle_Katarn  ---
https://learn.microsoft.com/en-us/windows/win32/msi/volumecostlist-control

The contents of the Text field of the Control table are never displayed by the
VolumeCostList control. Instead this field specifies the style of text to be
displayed by the control and contains a description of the control used by
screen review utilities. To set the font and font style of a text string,
prefix the string of displayed characters with {\style} or {&style}.

The "better fix" patch : Only skip first item (prefix) if it commands a Style
(starts with \ or & in braces). In this case, also log a FIXME message to
remind that further implementation is required to support styles.