[Bug 38475] New: Unused variable in glsl_shader.c

https://bugs.winehq.org/show_bug.cgi?id=38475

Bug ID: 38475
           Summary: Unused variable in glsl_shader.c
           Product: Wine
           Version: 1.7.41
          Hardware: x86
                OS: Mac OS X
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-d3d
          Assignee: [e-mail]
          Reporter: [e-mail]

if (shader->limits->constant_float + extra_constants_needed
                    + 1 < gl_info->limits.glsl_ps_float_constants)
            {
                shader_addline(buffer, "uniform vec4 ycorrection;\n");
                extra_constants_needed++;
            }
----
What is the sense to do extra_constants_needed++ if this variable is no more
used?
May be some part of codes missed here?

[Bug 38475] Unused variable in glsl_shader.c

https://bugs.winehq.org/show_bug.cgi?id=38475

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]

[Bug 38475] Unused variable in glsl_shader.c

https://bugs.winehq.org/show_bug.cgi?id=38475

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]

--- Comment #1 from [e-mail] ---
Is this still valid?

I searched a string "if (shader->limits->constant_float +
extra_constants_needed"

and the only place I could find it was

http://source.winehq.org/git/wine.git/?a=search&h=HEAD&st=grep&s...

and there is only a fixme after that line.

[Bug 38475] Unused variable in glsl_shader.c

https://bugs.winehq.org/show_bug.cgi?id=38475

--- Comment #2 from Sergey Isakov  ---
Code changed so the bug can be closed as FIXED.

[Bug 38475] Unused variable in glsl_shader.c

https://bugs.winehq.org/show_bug.cgi?id=38475

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
           Keywords|                            |source
      Fixed by SHA1|                            |f08896aa738fcf99fd03292002b
                   |                            |ffdf3adad9311
         Resolution|---                         |FIXED

--- Comment #3 from Bruno Jesus  ---
(In reply to Sergey Isakov from comment #2)
> Code changed so the bug can be closed as FIXED.

Fixed.

[Bug 38475] Unused variable in glsl_shader.c

https://bugs.winehq.org/show_bug.cgi?id=38475

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 1.9.15.