[Bug 44265] New: Options dialog triggers exception upon close in Windows Media Player 6.4

https://bugs.winehq.org/show_bug.cgi?id=44265

Bug ID: 44265
           Summary: Options dialog triggers exception upon close in
                    Windows Media Player 6.4
           Product: Wine
           Version: 3.0-rc4
          Hardware: x86
               URL: http://download.microsoft.com/download/winmediaplayer/
                    Update/6.4/W9XNT4/EN-US/mpfull.exe
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: Ubuntu

Created attachment 60076
  --> https://bugs.winehq.org/attachment.cgi?id=60076
Backtrace of Options dialog exception upon close (after hardware acceleration
change)

Options dialog (View > Options) triggers an exception when closed in Windows
Media Player 6.4 regardless of button clicked (Close, OK, window close; Apply
is always disabled).  Tested on two systems.

Xubuntu  16.04.3 x86_64, AMD Phenom 9550, GeForce GTX 750Ti with Nvidia 384.90
driver.
wine-devel 3.0~rc4~xenial from dl.winehq.org

Xubuntu  17.04 x86, Intel Pentium D 3.46GHz, GeForce 8600 GT with Nvidia
340.102 driver.
wine-devel 3.0~rc4~zesty from dl.winehq.org

[Bug 44265] Options dialog triggers exception upon close in Windows Media Player 6.4

https://bugs.winehq.org/show_bug.cgi?id=44265

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 44265] Options dialog triggers exception upon close in Windows Media Player 6.4

https://bugs.winehq.org/show_bug.cgi?id=44265

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |oleaut32
                 CC|                            |[e-mail]
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #1 from Fabian Maurer  ---
Confirming. Native oleaut32 fixes the issue.

[Bug 44265] Options dialog triggers exception upon close in Windows Media Player 6.4

https://bugs.winehq.org/show_bug.cgi?id=44265

--- Comment #2 from Nikolay Sivov  ---
Created attachment 60086
  --> https://bugs.winehq.org/attachment.cgi?id=60086
patch

This looks like a bug in some application component IPropertyPage -
SetPageSite(NULL) releases our site instance, but doesn't reset its pointer, so
later on Release() site is released again. This needs a simple interactive test
to confirm that SetPageSite(NULL) is never called.

[Bug 44265] Options dialog triggers exception upon close in Windows Media Player 6.4

https://bugs.winehq.org/show_bug.cgi?id=44265

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 44265] Options dialog triggers exception upon close in Windows Media Player 6.4

https://bugs.winehq.org/show_bug.cgi?id=44265

--- Comment #3 from Nikolay Sivov  ---
Created attachment 60551
  --> https://bugs.winehq.org/attachment.cgi?id=60551
test patch

This adds some stub objects to test property page site interactions. Should be
applied to wine itself, not a standalone program.

[Bug 44265] Options dialog triggers exception upon close in Windows Media Player 6.4

https://bugs.winehq.org/show_bug.cgi?id=44265

--- Comment #4 from Nikolay Sivov  ---
Patch sent,
https://www.winehq.org/pipermail/wine-devel/2018-February/123096.html.

[Bug 44265] Options dialog triggers exception upon close in Windows Media Player 6.4

https://bugs.winehq.org/show_bug.cgi?id=44265

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |1ac1c78f0552f983b512cfebbf3
                   |                            |f3207a3dbf709
             Status|NEW                         |RESOLVED

--- Comment #5 from Nikolay Sivov  ---
This is fixed with
https://source.winehq.org/git/wine.git/?a=commit;h=1ac1c78f0552f983b512cfebb....

[Bug 44265] Options dialog triggers exception upon close in Windows Media Player 6.4

https://bugs.winehq.org/show_bug.cgi?id=44265

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  ---
Closing bugs fixed in 3.3.

[Bug 44265] Options dialog triggers exception upon close in Windows Media Player 6.4

https://bugs.winehq.org/show_bug.cgi?id=44265

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |3.0.x

[Bug 44265] Options dialog triggers exception upon close in Windows Media Player 6.4

https://bugs.winehq.org/show_bug.cgi?id=44265

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.0.x                       |---

--- Comment #7 from Michael Stefaniuc  ---
Removing the 3.0.x milestone from bugs included in 3.0.1.