[Bug 48208] New: Detect missing entry point errors

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48208

Bug ID: 48208
           Summary: Detect missing entry point errors
           Product: Wine-Testbot
           Version: unspecified
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

When a Windows test executable cannot run because of a missing test executable
the TestBot remains stuck until the 2 minutes timeout. This is because Windows
puts up an error dialog waiting for user input. In such a case the test report
is almost empty and the issue is not obvious until one looks at the screenshot.
The TestBot should detect such a situation and warn the user.

One simple approach would be for the TestBot to detect that the test report
only contains the TestLauncher's start and done lines and indicates a timeout.
In such a case it could add a message to the .err file suggesting to check the
screenshot. This would only be a heuristic though.

A better approach would be for the TestLauncher to detect the error dialog.
Ideally, instead of waiting for the child process for the full 2 minutes it
would periodically check for the presence of this dialog, which would also
speed up the task run. This approach could also be used by WineTest.exe, though
presumably missing entry points would have been detected before making it into
the Wine source.

[Bug 48208] Detect missing entry point errors

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48208

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |48061

--- Comment #1 from François Gouget  ---
The first line should read "because of a missing dll" of course. Also note that
quite often it's not a dll the test executable links with that's missing, but
one that a dll it links with needs.

This is the source of a lot of the "WineTest: get_subtests()" errors (bug
48061).

[Bug 48208] Detect missing entry point errors

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48208

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |48062

[Bug 48208] Detect missing entry point errors

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48208

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32216

[Bug 48208] Detect missing entry point errors

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48208

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

[Bug 48208] Detect missing entry point errors

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48208

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |48430

[Bug 48208] Detect missing entry point errors

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48208

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]        |[e-mail]

[Bug 48208] Detect missing entry point errors

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48208

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #2 from François Gouget  ---
This case is now detected by TestLauncher and reported as a skip (see bug
31609). For instance:

rtworkq:rtworkq start - -
rtworkq.c:0: Tests skipped: missing entry point (details below)
| rtworkq_test.exe - Entry Point Not Found
| The procedure entry point CoGetApartmentType could not be located in the
dynamic link library ole32.dll.
09f0:rtworkq: 0 tests executed (0 marked as todo, 0 failures), 1 skipped.
rtworkq:rtworkq:09f0 done (0) in 0s

The two lines starting with "|" are extracted from the Windows critical error
dialog.

WineTest.exe instead arranges for CreateProcess() to fail so it does not get
the error information from the Windows critical error dialog (see bug 45032).
But it also skips the test and does not get stuck.

That means no extra log parsing or heuristic is needed to identify the missing
entry points, missing ordinals, and indirectly missing dlls. So I think this
issue is fixed.

[Bug 48208] Detect missing entry point errors

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48208

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from François Gouget  ---
Closing.