[Bug 54489] New: vbscript Abs on BSTR returns invalid value

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54489

Bug ID: 54489
           Summary: vbscript Abs on BSTR returns invalid value
           Product: Wine
           Version: 7.21
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: vbscript
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

While porting Visual Pinball to cross platform, I found some code where Abs was
returning an invalid value when the source value was a string:

Dim x
x = "30000"
Debug.Print "x" & "=" & abs(x)

Outputs:

Script.Print 'x=3.08221696253945E-314'

After further research, it turns out the issue is in VarAbs in oleaut32.c:

I've submitted an MR to handle this:

https://gitlab.winehq.org/wine/wine/-/merge_requests/2175

[Bug 54489] VarAbs() does not handle BSTR arguments correctly

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54489

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|vbscript Abs on BSTR        |VarAbs() does not handle
                   |returns invalid value       |BSTR arguments correctly
          Component|vbscript                    |oleaut32

[Bug 54489] VarAbs() does not handle BSTR arguments correctly

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54489

--- Comment #1 from Nikolay Sivov  ---
Is this now fixed after
https://source.winehq.org/git/wine.git/commit/72b86f967e0282be60b3507194ba01...

[Bug 54489] VarAbs() does not handle BSTR arguments correctly

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54489

Robert Wilhelm  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |[e-mail]
      Fixed by SHA1|                            |72b86f967e0282be60b3507194b
                   |                            |a01a7e1cf66b5
         Resolution|---                         |FIXED

--- Comment #2 from Robert Wilhelm  ---
This is fixed now by Jason's MR. Thanks!

[Bug 54489] VarAbs() does not handle BSTR arguments correctly

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54489

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alexandre Julliard  ---
Closing bugs fixed in 8.2.

[Bug 54489] VarAbs() does not handle BSTR arguments correctly

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54489

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |8.0.x

[Bug 54489] VarAbs() does not handle BSTR arguments correctly

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54489

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|8.0.x                       |---

--- Comment #4 from Michael Stefaniuc  ---
Removing the 8.0.x milestone from bug fixes included in 8.0.1.