[Bug 54184] New: [regression] Multiple applications fail http requests when WinHttpSendRequest() doesn't contain full request data.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54184

Bug ID: 54184
           Summary: [regression] Multiple applications fail http requests
                    when WinHttpSendRequest() doesn't contain full request
                    data.
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: winhttp
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Split off from Bug 54055 (see Comments 1, 3, 4 there).

The problem is introduced by this commit:

commit aa8f97e8294b0618de0e8a45ff2adef0c4e516da
Author: Paul Gofman 
Date:   Mon Dec 5 19:33:18 2022 -0600

winhttp: Receive server reply in send_request().

For the requests which involve additional data to be sent the application might
use WinHttpWriteData() before WinHttpReceiveResponse() to pass the additional
request data instead of providing the optional data to WinHttpSendRequest(). In
that case server reply can't be read in send_request().

[Bug 54184] [regression] Multiple applications fail http requests when WinHttpSendRequest() doesn't contain full request data.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54184

Paul Gofman  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |aa8f97e8294b0618de0e8a45ff2
                   |                            |adef0c4e516da

[Bug 54184] [regression] Multiple applications fail http requests when WinHttpSendRequest() doesn't contain full request data.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54184

Paul Gofman  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 54184] [regression] Multiple applications fail http requests when WinHttpSendRequest() doesn't contain full request data.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54184

--- Comment #1 from Paul Gofman  ---
I created a MR with the fix:
https://gitlab.winehq.org/wine/wine/-/merge_requests/1851

[Bug 54184] [regression] Multiple applications fail http requests when WinHttpSendRequest() doesn't contain full request data.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54184

Jactry Zeng  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 54184] [regression] Multiple applications fail http requests when WinHttpSendRequest() doesn't contain full request data.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54184

--- Comment #2 from Paul Gofman  ---
This should be fixed by 3f51fcf8ac40296265f0bf88ed51e0778f6b266a which is now
in Wine 8.0-rc2.

[Bug 54184] [regression] Multiple applications fail http requests when WinHttpSendRequest() doesn't contain full request data.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54184

Paul Gofman  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |3f51fcf8ac40296265f0bf88ed5
                   |                            |1e0778f6b266a

--- Comment #3 from Paul Gofman  ---
Fixed by 3f51fcf8ac40296265f0bf88ed51e0778f6b266a.

[Bug 54184] Multiple applications fail http requests when WinHttpSendRequest() doesn't contain full request data

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54184

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |8.0-rc1
            Summary|[regression] Multiple       |Multiple applications fail
                   |applications fail http      |http requests when
                   |requests when               |WinHttpSendRequest()
                   |WinHttpSendRequest()        |doesn't contain full
                   |doesn't contain full        |request data
                   |request data.               |

[Bug 54184] Multiple applications fail http requests when WinHttpSendRequest() doesn't contain full request data

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54184

--- Comment #4 from optimax  ---
I confirm that the issue is fixed with 8.0 rc2.
Thank you very much for taking the time to investigate.

[Bug 54184] Multiple applications fail http requests when WinHttpSendRequest() doesn't contain full request data

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54184

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 8.0-rc3.