[Bug 54995] New: msys2: git clone fails with 'Socket operation on non-socket'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54995

Bug ID: 54995
           Summary: msys2: git clone fails with 'Socket operation on
                    non-socket'
           Product: Wine
           Version: 8.8
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: winsock
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

git clone --mirror git://sourceware.org/git/newlib-cygwin.git msys2-runtime
Cloning into bare repository '.../msys2-runtime'
010c:fixme:winsock:addrinfo_flags_to_unix unhandled flags 0x80000
fatal: packet write failed: Socket operation on non-socket

[Bug 54995] msys2: git clone fails with 'Socket operation on non-socket'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54995

--- Comment #1 from Bernhard Übelacker  ---
Created attachment 74547
  --> https://bugs.winehq.org/attachment.cgi?id=74547
Workaround: Disable check for local socket handles.

Hello, it looks like git uses dup/DuplicateHandle to duplicate a socket handle.

ws2_32 contains a process local socket_list,
maybe to avoid wineserver roundtrips.

Unfortunately due to DuplicateHandle the duplicate is not found in sock_list,
therefore ws2_32 returns early a failure.

Attached workaround makes git work. It just disables these checks for
the process local socket_list, therefore doing the wineserver calls.

Unfortunately I don't see an easy way to notify ws2_32
from ntdll/DuplicateHandle.

[Bug 54995] msys2: git clone fails with 'Socket operation on non-socket'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54995

Zeb Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Zeb Figura  ---
It's possible that we aren't supposed to check the socket list in some of those
functions. I added those checks, but looking back, I don't remember why I did.

[Bug 54995] msys2: git clone fails with 'Socket operation on non-socket'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54995

--- Comment #3 from Bernhard Übelacker  ---
It looks like I did not add the actual call to socket_list_find
in the attachement ...

(rr) bt
#0  socket_list_find () at ...dlls/ws2_32/socket.c:406
#1  WS2_sendto () at ...dlls/ws2_32/socket.c:1003
#2  WSASendTo () at ...dlls/ws2_32/socket.c:3093
#3  fhandler_socket_wsock::send_internal () at
...winsup/cygwin/fhandler/socket_inet.cc:1431
...

To workaround this issue it might be already enough to remove
the check from WS2_sendto. Hope that helps.

[Bug 54995] msys2: git clone fails with 'Socket operation on non-socket'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54995

Joel Holdsworth  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 54995] msys2: git clone fails with 'Socket operation on non-socket'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54995

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Fabian Maurer  ---
Any news on this? Currently I can't install MSYS2, probably because of bug
52105.

[Bug 54995] msys2-64/cygwin64: git clone fails with 'Socket operation on non-socket'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54995

Bernhard Übelacker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|msys2: git clone fails with |msys2-64/cygwin64: git
                   |'Socket operation on        |clone fails with 'Socket
                   |non-socket'                 |operation on non-socket'
           Keywords|                            |download, source

--- Comment #5 from Bernhard Übelacker  ---
(In reply to Fabian Maurer from comment #4)
> Any news on this? Currently I can't install MSYS2, probably because of bug
> 52105.

This is still visible with wine-9.12 for msys2-64 and cygwin64.
Attached workaround makes the git command succeed.

[Bug 54995] msys2-64/cygwin64: git clone fails with 'Socket operation on non-socket'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54995

Bernhard Übelacker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74547|0                           |1
        is obsolete|                            |

--- Comment #6 from Bernhard Übelacker  ---
Created attachment 76701
  --> https://bugs.winehq.org/attachment.cgi?id=76701
Workaround: Disable check for local socket handles. (rebased wine-9.12)

[Bug 54995] msys2-64/cygwin64: git clone fails with 'Socket operation on non-socket'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54995

--- Comment #7 from Bernhard Übelacker  ---
Forgot to mention, this test was done with
a wine tree including patches related to following bugs:
  52105
  55138
  53574