[Bug 33249] New: accept_invalid_certs not working

http://bugs.winehq.org/show_bug.cgi?id=33249

Bug #: 33249
           Summary: accept_invalid_certs not working
           Product: Wine
           Version: unspecified
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: wininet
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Hey guys,

I stumbled upon this tutorial for crossover:

https://www.codeweavers.com/support/tickets/browse/?ticket_id=879094#ticket8...

I experience the same problems with outlook and wish wininet to accept invalid
certs. Is it possible? Entering the registry key as for crossover did not work
out :(

Best regards

[Bug 33249] accept_invalid_certs not working

http://bugs.winehq.org/show_bug.cgi?id=33249

--- Comment #1 from [e-mail] 2013-03-20 07:50:13 CDT ---
wireshark gives me 192    7.547564    *.*.*.45    *.*.*.55    TLSv1.1    73   
Alert (Level: Fatal, Description: Certificate Unknown)

[Bug 33249] accept_invalid_certs not working

http://bugs.winehq.org/show_bug.cgi?id=33249

--- Comment #2 from Austin English  2013-03-20 13:17:49 CDT ---
(In reply to comment #0)
> Hey guys,
>
> I stumbled upon this tutorial for crossover:
>
> https://www.codeweavers.com/support/tickets/browse/?ticket_id=879094#ticket8...
>
> I experience the same problems with outlook and wish wininet to accept invalid
> certs. Is it possible? Entering the registry key as for crossover did not work
> out :(
>
> Best regards

That workaround is Crossover specific.

[Bug 33249] accept_invalid_certs not working

http://bugs.winehq.org/show_bug.cgi?id=33249

--- Comment #3 from [e-mail] 2013-03-20 14:01:59 CDT ---
Is there a way to get something similar into it? It may be also helpful if you
spot me some sourcefiles i should look into.

[Bug 33249] accept_invalid_certs not working

http://bugs.winehq.org/show_bug.cgi?id=33249

--- Comment #4 from Austin English  2013-03-20 14:28:36 CDT ---
(In reply to comment #3)
> Is there a way to get something similar into it? It may be also helpful if you
> spot me some sourcefiles i should look into.

http://www.codeweavers.com/products/faq/source/

You can run a diff against the wine source.

diff -ur wine-git/dlls/wininet/netconnection.c
wine/dlls/wininet/netconnection.c
--- wine-git/dlls/wininet/netconnection.c       2013-03-13 16:03:27.521109103
-0700
+++ wine/dlls/wininet/netconnection.c   2013-02-28 11:41:52.000000000 -0800
@@ -78,6 +78,7 @@
 #include "wine/library.h"
 #include "windef.h"
 #include "winbase.h"
+#include "winreg.h"
 #include "wininet.h"
 #include "winerror.h"

@@ -417,6 +418,23 @@
         CertFreeCertificateContext(endCert);
         CertCloseStore(store, 0);
     }
+    if (!ret) /* CrossOver hack tracked by bug 6776 */
+    {
+        HKEY hkey;
+        DWORD type, value, size = sizeof(value);
+
+        /* @@ Wine registry key: HKCU\Software\Wine\wininet */
+        if (!RegOpenKeyA( HKEY_CURRENT_USER, "Software\Wine\wininet", &hkey
))
+        {
+            if (!RegQueryValueExA( hkey, "accept_invalid_certs", 0, &type,
(BYTE *)&value, &size ) &&
+                type == REG_DWORD && value)
+            {
+                WARN("certificate is invalid, accepting it anyway\n");
+                ret = TRUE;
+            }
+            RegCloseKey( hkey );
+        }
+    }
     return ret;
 }

[Bug 33249] accept_invalid_certs not working

http://bugs.winehq.org/show_bug.cgi?id=33249

--- Comment #5 from [e-mail] 2013-03-20 15:07:48 CDT ---
Very nice! Can't it be merged into wine?

[Bug 33249] accept_invalid_certs not working

http://bugs.winehq.org/show_bug.cgi?id=33249

--- Comment #6 from Nikolay Sivov  2013-03-20 15:13:30 CDT ---
No, that what "hack" means. It's a workaround for not properly working cert
code.

[Bug 33249] accept_invalid_certs not working

http://bugs.winehq.org/show_bug.cgi?id=33249

--- Comment #7 from [e-mail] 2013-03-20 16:09:35 CDT ---
Okay, i understand that. Is there a way for me to compile only one library and
not the whole wine. I'd like to have this patch, but to stay on an upstream
version.

[Bug 33249] accept_invalid_certs not working

http://bugs.winehq.org/show_bug.cgi?id=33249

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |WONTFIX

--- Comment #8 from [e-mail] 2013-03-21 07:03:44 CDT ---
okay, thanks for explanations

[Bug 33249] accept_invalid_certs not working

http://bugs.winehq.org/show_bug.cgi?id=33249

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Nikolay Sivov  2013-03-21 07:12:01 CDT ---
Closing.

[Bug 33249] accept_invalid_certs not working

http://bugs.winehq.org/show_bug.cgi?id=33249

--- Comment #10 from Austin English  2013-03-21 13:01:40 CDT ---
(In reply to comment #7)
> Okay, i understand that. Is there a way for me to compile only one library and
> not the whole wine. I'd like to have this patch, but to stay on an upstream
> version.

No, you'll have to patch Wine and rebuild the entire program. See
http://wiki.winehq.org/Patching