[Bug 40267] New: ChoosePixelFormat and SetPixelFormat always fail on X11 with invalid format error

https://bugs.winehq.org/show_bug.cgi?id=40267

Bug ID: 40267
           Summary: ChoosePixelFormat and SetPixelFormat always fail on
                    X11 with invalid format error
           Product: Wine
           Version: unspecified
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: opengl
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 53892
  --> https://bugs.winehq.org/attachment.cgi?id=53892
Anomalous ChoosePixelFormat and SetPixelFormat error

Attempting to run a T3 emulator with wine 1.9.5-1 on Arch always produces two
error popup boxes saying "ChoosePixelFormat failed" and "SetPixelFormat
failed".

After the ChoosePixelFormat error, the following is logged:
fixme:event:wait_for_withdrawn_state window 0x10072/e00004 wait timed out
err:wgl:set_pixel_format Invalid format 0

Then after the SetPixelFormat error, the following is logged:
fixme:event:wait_for_withdrawn_state window 0x20072/e00006 wait timed out

I've attached a complete log with WINEDEBUG=trace+wgl that yields ore
information. From the log, the PIXELFORMATDESCRIPTOR clearly has a valid
format, despite Wine's "Invalid format 0" error.

Despite these popup errors, the program paints a mostly correct window. But it
detects the errors through error code checking, and they are sufficient to
prevent the program from functioning at all.

[Bug 40267] ChoosePixelFormat and SetPixelFormat always fail on X11 with invalid format error

https://bugs.winehq.org/show_bug.cgi?id=40267

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from [e-mail] ---
Can you try this patch?

--- a/dlls/opengl32/wgl.c    
+++ a/dlls/opengl32/wgl.c    
@@ -443,7 +443,7 @@ INT WINAPI wglChoosePixelFormat(HDC hdc, const
PIXELFORMATDESCRIPTOR* ppfd)
     {
         if (!wglDescribePixelFormat( hdc, i, sizeof(format), &format ))
continue;

-        if (ppfd->iPixelType != format.iPixelType)
+        if ((ppfd->iPixelType == PFD_TYPE_COLORINDEX ? PFD_TYPE_COLORINDEX :
PFD_TYPE_RGBA) != format.iPixelType)
         {
             TRACE( "pixel type mismatch for iPixelFormat=%d\n", i );
             continue;

If it works for you then this bug is most likely a dupe of bug 14640.

[Bug 40267] ChoosePixelFormat and SetPixelFormat always fail on X11 with invalid format error

https://bugs.winehq.org/show_bug.cgi?id=40267

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEEDINFO
     Ever confirmed|0                           |1

--- Comment #2 from Bruno Jesus  ---
Is this still an issue in wine 2.0-rc3 (or newer)? What is the application
name?

[Bug 40267] ChoosePixelFormat and SetPixelFormat always fail on X11 with invalid format error

https://bugs.winehq.org/show_bug.cgi?id=40267

--- Comment #3 from [e-mail] ---
It's the USI T3 emulator, an industrial program. I'll have to check.

[Bug 40267] USI T3 emulator crashes, ChoosePixelFormat and SetPixelFormat fail on X11 with invalid format error

https://bugs.winehq.org/show_bug.cgi?id=40267

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |1.9.5
                 CC|                            |[e-mail]
            Summary|ChoosePixelFormat and       |USI T3 emulator crashes,
                   |SetPixelFormat always fail  |ChoosePixelFormat and
                   |on X11 with invalid format  |SetPixelFormat fail on X11
                   |error                       |with invalid format error

[Bug 40267] USI T3 emulator reports "ChoosePixelFormat failed" and " SetPixelFormat failed" (err:wgl:set_pixel_format Invalid format 0)

https://bugs.winehq.org/show_bug.cgi?id=40267

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|USI T3 emulator crashes,    |USI T3 emulator reports
                   |ChoosePixelFormat and       |"ChoosePixelFormat failed"
                   |SetPixelFormat fail on X11  |and "SetPixelFormat failed"
                   |with invalid format error   |(err:wgl:set_pixel_format
                   |                            |Invalid format 0)
             Status|NEEDINFO                    |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #4 from Anastasius Focht  ---
Hello folks,

since OP didn't provide an answer, assuming dupe of bug 14640

Regards

*** This bug has been marked as a duplicate of bug 14640 ***

[Bug 40267] USI T3 emulator reports "ChoosePixelFormat failed" and " SetPixelFormat failed" (err:wgl:set_pixel_format Invalid format 0)

https://bugs.winehq.org/show_bug.cgi?id=40267

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alistair Leslie-Hughes  ---
Closing Duplicate.