[Bug 31008] New: WinUAE "Browse for folder" works incorrectly

http://bugs.winehq.org/show_bug.cgi?id=31008

Bug #: 31008
           Summary: WinUAE "Browse for folder" works incorrectly
           Product: Wine
           Version: 1.5.7
          Platform: x86
               URL: http://www.winuae.net/
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: comdlg32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Install / run.

Click "paths" and click "..."

It should show "Browse for folder" dialog, but it shows "Open file" dialog.

-> It doesn't work

fixme:commdlg:IServiceProvider_fnQueryService Interface
{e07010ec-bc17-44c0-97b0-46c7c95b9edc} requested from unknown service
{e07010ec-bc17-44c0-97b0-46c7c95b9edc}

Workaround native comdlg32.dll

[Bug 31008] WinUAE "Browse for folder" works incorrectly

http://bugs.winehq.org/show_bug.cgi?id=31008

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 31008] WinUAE "Browse for folder" works incorrectly

http://bugs.winehq.org/show_bug.cgi?id=31008

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |source

[Bug 31008] WinUAE "Browse for folder" works incorrectly

http://bugs.winehq.org/show_bug.cgi?id=31008

--- Comment #1 from Nikolay Sivov  2012-06-25 23:04:55 CDT ---
(In reply to comment #0)
> Install / run.
>
> Click "paths" and click "..."
>
> It should show "Browse for folder" dialog, but it shows "Open file" dialog.

It depends actually. Application detects what is supported and what you expect
is the last thing in fallback path.

Could you try this on Vista or Win7? I expect a difference:

---
    pSHCreateItemFromParsingName = (SHCREATEITEMFROMPARSINGNAME)GetProcAddress
(
        GetModuleHandle (_T("shell32.dll")), "SHCreateItemFromParsingName");
    if (pSHCreateItemFromParsingName)
        hr = CoCreateInstance (mode > 0 ? __uuidof(FileSaveDialog) :
__uuidof(FileOpenDialog), 
        NULL, 
        CLSCTX_INPROC_SERVER, 
        mode > 0 ? IID_IFileSaveDialog : IID_IFileOpenDialog, (LPVOID*)&pfd);
    if (FAILED (hr)) {
        if (mode > 0)
            return GetSaveFileName (opn);
        else if (mode == 0)
            return GetOpenFileName (opn);
        else
            return DirectorySelection2 (opn);
    }
---

In case of these buttons 'mode' is -1 so it goes with FileOpenDialog and
IID_IFileOpenDialog which is what you see. The dialog you expect created from
DirectorySelection2().

The question now is - does open dialog look the same it looks in Win7?
> Workaround native comdlg32.dll

The reason is most likely is that native module is too old.

[Bug 31008] WinUAE "Browse for folder" works incorrectly

http://bugs.winehq.org/show_bug.cgi?id=31008

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
          Component|comdlg32                    |-unknown
     Ever Confirmed|0                           |1

--- Comment #2 from Nikolay Sivov  2012-06-25 23:05:09 CDT ---
Confirming.

[Bug 31008] WinUAE "Browse for folder" works incorrectly

http://bugs.winehq.org/show_bug.cgi?id=31008

--- Comment #3 from [e-mail] 2012-06-26 01:01:58 CDT ---
Created attachment 40719
  --> http://bugs.winehq.org/attachment.cgi?id=40719
Dialog in Win7

It shows "Select folder" dialog in Win7

[Bug 31008] WinUAE "Browse for folder" works incorrectly

http://bugs.winehq.org/show_bug.cgi?id=31008

Mark K  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 31008] WinUAE "Browse for folder" works incorrectly

http://bugs.winehq.org/show_bug.cgi?id=31008

--- Comment #4 from [e-mail] ---
Still in Wine wine-1.7.21-61-gf9f3b21

Workaround: wine regsvr32 /u comdlg32.dll

[Bug 31008] WinUAE "Browse for folder" works incorrectly

https://bugs.winehq.org/show_bug.cgi?id=31008

David Hedberg  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from David Hedberg  ---
This should now work natively in latest git.

[Bug 31008] WinUAE "Browse for folder" works incorrectly

https://bugs.winehq.org/show_bug.cgi?id=31008

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |3cf2fb3a9c83a1326e4c5a623f2
                   |                            |d85e0aad76876
             Status|NEW                         |RESOLVED
          Component|-unknown                    |comdlg32
         Resolution|---                         |FIXED

--- Comment #6 from [e-mail] ---
Thanks

[Bug 31008] WinUAE "Browse for folder" works incorrectly

https://bugs.winehq.org/show_bug.cgi?id=31008

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.24.

[Bug 31008] WinUAE "Browse for folder" works incorrectly

https://bugs.winehq.org/show_bug.cgi?id=31008

--- Comment #8 from Mark K  ---
*** Bug 32393 has been marked as a duplicate of this bug. ***