[Bug 11950] New: TheBat! 3.99. 1 show white squares not icons under wine after 0.9.56

http://bugs.winehq.org/show_bug.cgi?id=11950

Summary: TheBat! 3.99.1 show white squares not icons under wine
                    after 0.9.56
           Product: Wine
           Version: 0.9.56.
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: trivial
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=11269)
 --> (http://bugs.winehq.org/attachment.cgi?id=11269)
thebat under 0.9.57 - bad icons

TheBat ver.3.99.1, works fine under wine 0.9.46-55. Some little problem
(doesn't work "send" buttom in composer, doesn't connect to gmail using SSL)
but usable.

After 0.9.56 all icons transform to white squares. Tried 0.9.57 - same effect.
Go back at 0.9.55.

[Bug 11950] TheBat! 3.99.1 show white squares not icons under wine after 0. 9.56

http://bugs.winehq.org/show_bug.cgi?id=11950

--- Comment #1 from Lei Zhang   2008-03-09 12:52:38 ---
Is TheBat! 3.99 downloadable anywhere? The product page only has version 4. [1]

Please run a regression test between 0.9.46 and 0.9.56:

http://wiki.winehq.org/RegressionTesting

[1] http://www.ritlabs.com/en/products/thebat/download.php

[Bug 11950] TheBat! 3.99.1 show white squares not icons under wine after 0. 9.56

http://bugs.winehq.org/show_bug.cgi?id=11950

--- Comment #2 from Nikolay   2008-03-09 14:42:55 ---
http://rapidshare.com/files/27770853/The.Bat.Professional.Edition.v3.99.1.Cr...
This is cracked version, but we still can not to use included crack. On
official page I found link to 3.99.30, but that version not usable - it tried
to use windows registry not standart way.

Regression test need just between version 0.9.55 and 0.9.56 - before 0.9.56
thebat works fine. I'll try to do that test, but I'm not a profi :)

[Bug 11950] TheBat! 3.99.1 show white squares not icons under wine after 0. 9.56

http://bugs.winehq.org/show_bug.cgi?id=11950

--- Comment #3 from Nikolay   2008-03-09 14:44:58 ---
one more link, may be not cracked version:
http://rapidshare.com/files/27229071/The_Bat__3.99.1_Professional_Edition_-_...

[Bug 11950] TheBat! 3.99.1 show white squares not icons under wine after 0. 9.56

http://bugs.winehq.org/show_bug.cgi?id=11950

Giuseppe Bilotta  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Giuseppe Bilotta   2008-03-09 16:22:41 ---
I have The Bat! and can confirm the bug. I'm currently running git bisect
between 0.9.55 and 0.9.56 to look for the culprit commit. My machine is a
little slow in compiling, so I only managed to get three bisections done so
far, still 56 commits (i.e. 4 bisections) to go.

By the way, the severity of this bug is not 'trivial': missing icons make one
component (namely the dispatch center) unsable because it's impossible to tell
which mails have been selected for download, which for erasure and which for
opening.

See you on #winehackers to discuss the bug and hopefully the solution as soon
as I nail the commit :)

[Bug 11950] TheBat! 3.99.1 show white squares not icons under wine after 0. 9.56

http://bugs.winehq.org/show_bug.cgi?id=11950

--- Comment #5 from Giuseppe Bilotta   2008-03-09 18:18:32 ---
Found the culprit:

428ada3c8a12dbeaba42d13f445e67e488fea94a is first bad commit
commit 428ada3c8a12dbeaba42d13f445e67e488fea94a
Author: Rob Shearman 
Date:   Thu Feb 21 16:44:59 2008 +0000

winex11.drv: Optimise getting the bits of a DIB after calling SetDIBits.

Sync the application's bits in SetDIBits if the input bits are in
    exactly the same format and the size of the image is small enough not to
    cause a performance hit (in case the application doesn't get ever access
    the bits directly).

:040000 040000 16b8b4dce7d5ce533d696fcd0b60269ee50fc0be
2ca46e6905c5925a69e3c018f6fb49052a9ac673 M      dlls

[Bug 11950] TheBat! 3.99.1 show white squares not icons under wine after 0. 9.56

http://bugs.winehq.org/show_bug.cgi?id=11950

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #6 from Lei Zhang   2008-03-09 19:41:22 ---
Confirming.

Please don't post links to possibly illegal software.

[Bug 11950] TheBat! 3.99.1 show white squares not icons under wine after 0. 9.56

http://bugs.winehq.org/show_bug.cgi?id=11950

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Dmitry Timoshkov   2008-03-09 23:55:10 ---
Adding Rob to the cc: list.

[Bug 11950] TheBat! 3.99.1 show white squares not icons under wine after 0. 9.56

http://bugs.winehq.org/show_bug.cgi?id=11950

--- Comment #8 from Nikolay   2008-03-29 16:00:42 ---
Still present with 0.9.58

[Bug 11950] TheBat! 3.99.1 show white squares not icons under wine after 0. 9.56

http://bugs.winehq.org/show_bug.cgi?id=11950

Bernd Demuth  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from Bernd Demuth   2008-04-05 00:56:21 ---
I can confirm this bug too. Its still in 0.9.59-1.1

[Bug 11950] TheBat! 3.99.1 show white squares not icons under wine after 0. 9.56

http://bugs.winehq.org/show_bug.cgi?id=11950

--- Comment #10 from Giuseppe Bilotta   2008-04-08 12:45:02 ---
Still preset in latest git.

The bug severity is NOT trivial, because some Bat! features such as the
dispatcher REQUIRE visible icons (to see checked/unchecked options).

[Bug 11950] TheBat! 3.99.1 show white squares not icons under wine after 0. 9.56

http://bugs.winehq.org/show_bug.cgi?id=11950

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|trivial                     |minor

[Bug 11950] TheBat! 3.99.1 show white squares not icons under wine after 0. 9.56

http://bugs.winehq.org/show_bug.cgi?id=11950

--- Comment #11 from Giuseppe Bilotta   2008-04-20 08:21:47 ---
Still present in 0.9.60

[Bug 11950] TheBat! 3.99.1 show white squares not icons under wine after 0. 9.56

http://bugs.winehq.org/show_bug.cgi?id=11950

Joerg Schiermeier  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |newsletter@Schiermeier-
                   |                            |Software.de

--- Comment #12 from Joerg Schiermeier   2008-05-10 07:49:23 ---
Still present in Wine 1.0-rc1 :-(

[Bug 11950] TheBat! 3.99.1 show white squares not icons under wine after 0. 9.56

http://bugs.winehq.org/show_bug.cgi?id=11950

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://www.ritlabs.com/downl
                   |                            |oad/files3/the_bat/thebat_pr
                   |                            |o_3-99-29.msi
           Severity|minor                       |normal
           Keywords|                            |download, regression

--- Comment #13 from Lei Zhang   2008-05-19 18:20:34 ---
FYI, if you just comment out the optimization, the icons works fine.

Joerg sent me a legal download link. Thanks!

[Bug 11950] TheBat! 3.99.1 show white squares not icons under wine after 0. 9.56

http://bugs.winehq.org/show_bug.cgi?id=11950

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #14 from Lei Zhang   2008-05-19 18:21:15 ---
*** Bug 13022 has been marked as a duplicate of this bug. ***

[Bug 11950] TheBat! 3.99.1 show white squares not icons under wine after 0. 9.56

http://bugs.winehq.org/show_bug.cgi?id=11950

--- Comment #15 from Bernd Demuth   2008-05-20 14:24:49 ---
(In reply to comment #13)
> FYI, if you just comment out the optimization, the icons works fine.
>
> Joerg sent me a legal download link. Thanks!

Hi Ley,

where do I have to comment out this option?
Best regards

Bernd

[Bug 11950] TheBat! 3.99.1 show white squares not icons under wine after 0. 9.56

http://bugs.winehq.org/show_bug.cgi?id=11950

--- Comment #16 from Nikolay   2008-05-21 13:20:03 ---
You mean optimisation flags while compiling wine? I've tried to use 
CFLAGS="-O0" CXXFLAGS="-O0" sudo emerge wine
(on Gentoo distr) but have some effect, switched bact to 0.9.55

[Bug 11950] TheBat! 3.99.1 show white squares not icons under wine after 0. 9.56

http://bugs.winehq.org/show_bug.cgi?id=11950

--- Comment #17 from Lei Zhang   2008-05-21 13:28:06 ---
No, comment out the block of code that is the patch that caused the regression
(see comment 5)

[Bug 11950] TheBat! 3.99.1 show white squares not icons under wine after 0. 9.56

http://bugs.winehq.org/show_bug.cgi?id=11950

--- Comment #18 from Nikolay   2008-05-21 13:52:55 ---
Sorry, can You explain, how I can do this? Possibly via e-mail (if in this
topic is no time for stupid questions)? :)

[Bug 11950] TheBat! 3.99.1 show white squares not icons under wine after 0. 9.56

http://bugs.winehq.org/show_bug.cgi?id=11950

--- Comment #19 from Austin English   2008-05-21 14:34:34 ---
Created an attachment (id=13223)
 --> (http://bugs.winehq.org/attachment.cgi?id=13223)
revert patch

(In reply to comment #18)
> Sorry, can You explain, how I can do this? Possibly via e-mail (if in this
> topic is no time for stupid questions)? :)

Apply this patch and rebuild.

[Bug 11950] TheBat! 3.99.1 show white squares not icons under wine after 0. 9.56

http://bugs.winehq.org/show_bug.cgi?id=11950

--- Comment #20 from Nikolay   2008-05-23 11:30:09 ---
(In reply to comment #19)
> Created an attachment (id=13223)

--> (http://bugs.winehq.org/attachment.cgi?id=13223) [details]
> revert patch
>
> (In reply to comment #18)
> > Sorry, can You explain, how I can do this? Possibly via e-mail (if in this
> > topic is no time for stupid questions)? :)
>
> Apply this patch and rebuild.

Unfortunately, this don't work... I've tried 1.0RC1 and GIT version on Gentoo.
Making this:

nicolay@localhost ~ $ ebuild
/usr/portage/app-emulation/wine/wine-1.0_rc1.ebuild unpack
...cut...
> > > Unpacking wine-1.0-rc1.tar.bz2 to /var/tmp/portage/app-emulation/wine-1.0_rc1/work

* Applying wine-gentoo-no-ssp.patch ...                                       
                                                                      [ ok ]
> > > Source unpacked.

nicolay@localhost ~ $ cd
/var/tmp/portage/app-emulation/wine-1.0_rc1/work/wine-1.0-rc1/d
dlls/          documentation/
nicolay@localhost ~ $ cd
/var/tmp/portage/app-emulation/wine-1.0_rc1/work/wine-1.0-rc1/dlls/us
user32/  userenv/ usp10/
nicolay@localhost ~ $ cd
/var/tmp/portage/app-emulation/wine-1.0_rc1/work/wine-1.0-rc1/dlls/user32/
nicolay@localhost
/var/tmp/portage/app-emulation/wine-1.0_rc1/work/wine-1.0-rc1/dlls/user32 $
patch -R -i ~/test.diff
patching file scroll.c
patching file class.c
Hunk #1 FAILED at 570.
1 out of 1 hunk FAILED -- saving rejects to file class.c.rej
patching file winproc.c
nicolay@localhost
/var/tmp/portage/app-emulation/wine-1.0_rc1/work/wine-1.0-rc1/dlls/user32 $
nicolay@localhost
/var/tmp/portage/app-emulation/wine-1.0_rc1/work/wine-1.0-rc1/dlls/user32 $
sudo ebuild /usr/portage/app-emulation/wine/wine-1.0_rc1.ebuild compile
nicolay@localhost
/var/tmp/portage/app-emulation/wine-1.0_rc1/work/wine-1.0-rc1/dlls/user32 $
sudo ebuild /usr/portage/app-emulation/wine/wine-1.0_rc1.ebuild install

And icons still blank

[Bug 11950] TheBat! 3.99.1 show white squares not icons under wine after 0. 9.56

http://bugs.winehq.org/show_bug.cgi?id=11950

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13223|0                           |1
        is obsolete|                            |

--- Comment #21 from Austin English   2008-05-23 12:54:40 ---
Created an attachment (id=13278)
 --> (http://bugs.winehq.org/attachment.cgi?id=13278)
revert patch

You're right, I reverted the wrong commit. Try this one.

[Bug 11950] TheBat! 3.99.1 show white squares not icons under wine after 0. 9.56

http://bugs.winehq.org/show_bug.cgi?id=11950

--- Comment #22 from Nikolay   2008-05-23 16:14:00 ---
Thanks a lot!!! With last revert patch and wine-1.0-rc1 TheBat 3.99.1 works
perfectly.

[Bug 11950] TheBat! 3.99.1 show white squares not icons under wine after 0. 9.56

http://bugs.winehq.org/show_bug.cgi?id=11950

AlexNR  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #23 from AlexNR   2008-05-24 09:21:46 ---
Any chance to get it working in mainline without recompiling?

[Bug 11950] TheBat! 3.99.1 show white squares not icons under wine after 0.9.56

http://bugs.winehq.org/show_bug.cgi?id=11950

Joerg Schiermeier  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #24 from Joerg Schiermeier   2008-05-31 17:03:27 ---
Result of the Regression Testing (2008-05-31):
==============================================
428ada3c8a12dbeaba42d13f445e67e488fea94a is first bad commit
commit 428ada3c8a12dbeaba42d13f445e67e488fea94a
Author: Rob Shearman 
Date:   Thu Feb 21 16:44:59 2008 +0000

winex11.drv: Optimise getting the bits of a DIB after calling SetDIBits.

Sync the application's bits in SetDIBits if the input bits are in
    exactly the same format and the size of the image is small enough not to
    cause a performance hit (in case the application doesn't get ever access
    the bits directly).

:040000 040000 16b8b4dce7d5ce533d696fcd0b60269ee50fc0be
2ca46e6905c5925a69e3c018f6fb49052a9ac673 M     dlls
----------------------------------------------
The Bat! v3.99.24

wine v0.9.55 - was working - the buttons are coloured and with icons
wine v0.9.56 - isn't working - the buttons are white squares

Please could somebody verify this regression test I just finish? 
This mistake also happens in 'wine v1.0-rc3'.

Sincerely
Joerg Schiermeier

[Bug 11950] TheBat! 3.99.1 show white squares not icons under wine after 0.9.56

http://bugs.winehq.org/show_bug.cgi?id=11950

--- Comment #25 from Bernd Demuth   2008-06-02 12:34:09 ---
Hi,

I confirm the "bug" is still present in V1.0rc3.

I'm interesting in a solution without recompile too.

If recompile is the only way please offer a script / easy solution for newbies
(recompile wine) and not this kind of mistery stuff below. I'm willing to learn
but there must be an easier way for users to make this work, sorry for that.

Best Regards

Bernd

[Bug 11950] TheBat! 3.99.1 show white squares not icons under wine after 0.9.56

http://bugs.winehq.org/show_bug.cgi?id=11950

--- Comment #26 from Joerg Schiermeier   2008-06-14 07:25:02 ---
Hello to everybody!

I'm sorry to tell you that this mistake still apears also in the latest rc of
wine. This is 'wine v1.0-rc5'. I check this some minutes ago.

Could somebody please confirm my result?

Sincerely
Joerg Schiermeier

[Bug 11950] TheBat! 3.99.1 show white squares not icons under wine after 0.9.56

http://bugs.winehq.org/show_bug.cgi?id=11950

--- Comment #27 from Joerg Schiermeier   2008-06-17 17:32:45 ---
... and again:
==============

Hello to everybody!

I'm sorry to tell you that this mistake still appears also in the latest
version of wine. This is 'wine v1.0.0' which was just released.
I checked this some minutes ago.

Could somebody please confirm my result (or better: fix it :-)?

Sincerely
Joerg Schiermeier

--- Comment #28 from Nikolay   2008-06-22 06:55:56 ---
Still present with wine-1.0 :(

[Bug 11950] TheBat! 3.99.1 show white squares not icons under wine after 0.9.56

http://bugs.winehq.org/show_bug.cgi?id=11950

--- Comment #29 from Mathias Kosch   2008-07-15 22:01:29 ---
Created an attachment (id=14834)
 --> (http://bugs.winehq.org/attachment.cgi?id=14834)
Corrects a mistake in displaying images

This patch applies to wine 1.1.1.

[Bug 11950] TheBat! 3.99.1 show white squares not icons under wine after 0.9.56

http://bugs.winehq.org/show_bug.cgi?id=11950

Mathias Kosch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #30 from Mathias Kosch   2008-07-15 22:02:18 ---
I took a look at the source code of wine 1.1.1 and found the mistake inside
"winex11.drv".

Inside the optimization code is a mistake in the following line:
> dbits = (LPBYTE)bits + (dstwidthb * (lines-1));

Instead it shoud be:
> dbits = (LPBYTE)dbits + (dstwidthb * (lines-1));

After correcting this and recompiling "The Bat!" now shows all the icons
properly.
I also provided a patch against wine 1.1.1.

[Bug 11950] TheBat! 3.99.1 show white squares not icons under wine after 0.9.56

http://bugs.winehq.org/show_bug.cgi?id=11950

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |1.0.1

--- Comment #31 from Alexandre Julliard   2008-07-18 06:47:18 ---
Fixed by f296f27e96d71d713f6a13eb1b7dfb5f5c5deab4.

[Bug 11950] TheBat! 3.99.1 show white squares not icons under wine after 0.9.56

http://bugs.winehq.org/show_bug.cgi?id=11950

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #32 from Alexandre Julliard   2008-07-25 12:59:43 ---
Closing bugs fixed in 1.1.2.