https://bugs.winehq.org/show_bug.cgi?id=39544
Bug ID: 39544 Summary: Microsoft Office 2007 installer fails with 'ITERATE_Actions Execution halted, action L"ProcessBranding" returned 1603' Product: Wine Version: 1.7.54 Hardware: x86-64 OS: Linux Status: NEW Severity: normal Priority: P2 Component: msi Assignee: wine-bugs@winehq.org Reporter: focht@gmx.net Distribution: ---
Hello folks,
during re-testing of bug 36527 I found the Microsoft Office 2007 installer no longer working. Probably affects more installers but I didn't specifically test further.
Looking at the relay trace I immediately guessed the culprit (sorry Dmitry) and indeed reverting commit 42caac841e1755570ba25c2ce95948fc28f31372 on top of the current master HEAD makes the installer work again.
--- snip --- msi: Correctly parse double quotes in the token value.
author Dmitry Timoshkov dmitry@baikal.ru Tue, 6 Oct 2015 10:10:35 +0000 (18:10 +0800) committer Alexandre Julliard julliard@winehq.org Tue, 6 Oct 2015 13:59:38 +0000 (22:59 +0900) commit 42caac841e1755570ba25c2ce95948fc28f31372 tree f7bdfd4dfaf08dd894479b566ca94cb61cd091fa tree | snapshot parent 1b3087e79f70c48f3e697d9ba16fa936bace0e55 commit | diff msi: Correctly parse double quotes in the token value.
This fixes an installer that passes to InstallProduct a command line like PROPERTY1="Installing ""Product name"" version 8.0" PROPERTY2=1 PROPERTY3=1 In this case properties PROPERTY2 and PROPERTY3 were not recognized and that led to an installation failure when a custom action didn't see them as set.
Signed-off-by: Dmitry Timoshkov dmitry@baikal.ru --- snip ---
https://source.winehq.org/git/wine.git/commitdiff/42caac841e1755570ba25c2ce9...
Relevant part of trace log:
--- snip --- ... 002e:trace:msi:msi_parse_command_line Found commandline property L"ARPENTRY_UNINSTALLSTRING" = L""C:\Program Files\Common Files\Microsoft Shared\OFFICE12\Office Setup Controller\setup.exe" /uninstall ENTERPRISE /dll OSETUP.DLL ARPENTRY_URLUPDATEINFO=" BRANDING_XML=C:\users\focht\Temp\Setup00000047\BRANDING.XML" 002e:trace:msi:msi_set_property 0x1503a08 L"ARPENTRY_UNINSTALLSTRING" L""C:\Program Files\Common Files\Microsoft Shared\OFFICE12\Office Setup Controller\setup.exe" /uninstall ENTERPRISE /dll OSETUP.DLL ARPENTRY_URLUPDATEINFO=" BRANDING_XML=C:\users\focht\Temp\Setup00000047\BRANDING.XML" -1 ... 002e:trace:msi:ACTION_CustomAction Handling custom action L"ProcessBranding" (1 L"OCFXCA" L"ProcessBranding") 002e:trace:msi:HANDLE_CustomType1 Calling function L"ProcessBranding" from L"C:\users\focht\Temp\msie9a.tmp" ... 0043:trace:msi:ACTION_CallDllFunction calling L"ProcessBranding" ... 0043:Call msi.MsiRecordSetStringW(00000003,00000000,0272e458 L"ProcessBranding: OMSICA : Initializing CustomAction [ProcessBranding]") ret=12b7a963 ... 0043:Call msi.MsiGetPropertyW(00000002,02681428 L"BRANDING_XML",0272bc20,1308df54) ret=12b7a2ec 0043:trace:msi:MSI_GetProperty 2 L"BRANDING_XML" 0x272bc20 0x1308df54 ... 0043:trace:msi:MSI_GetProperty 1 L"BRANDING_XML" (nil) 0x1308dc5c ... 0043:Ret msi.MsiGetPropertyW() retval=00000000 ret=12b7a2ec
0043:Call msi.MsiRecordSetStringW(00000005,00000000,0272b918 L"ProcessBranding: Fatal error: BRANDING_XML property is not set. Exiting custom action. Not failing install for now.") ret=12b7a963 ... 0043:Call KERNEL32.RaiseException(e06d7363,00000001,00000003,1308dfa0) ret=12b70555 0043:trace:seh:raise_exception code=e06d7363 flags=1 addr=0x7b846105 ip=7b846105 tid=0043 0043:trace:seh:raise_exception info[0]=19930520 0043:trace:seh:raise_exception info[1]=1308e1e4 0043:trace:seh:raise_exception info[2]=12b8d758 0043:trace:seh:raise_exception eax=7b832d05 ebx=f7513000 ecx=0000000c edx=1308dee4 esi=1308df8c edi=1308df50 0043:trace:seh:raise_exception ebp=1308df28 esp=1308dec4 cs=0023 ds=002b es=002b fs=0063 gs=006b flags=00200202 0043:trace:seh:call_stack_handlers calling handler at 0x12b8b539 code=e06d7363 flags=1 0043:Call KERNEL32.GetLastError() ret=12b70f1c 0043:Ret KERNEL32.GetLastError() retval=000000cb ret=12b70f1c ... 0043:Call msi.MsiRecordSetStringW(00000005,00000000,0272ecc8 L"ProcessBranding: Error: branding.xml path is empty Type: InvalidMetadataFile. ") ret=12b7a963 ... 0043:trace:msi:DllThread custom action (43) returned 1603 ... 002e:err:msi:ITERATE_Actions Execution halted, action L"ProcessBranding" returned 1603 ... 002e:Call KERNEL32.lstrlenA(014fbb68 "Error: Failed to install product: C:\MSOCache\All Users\{90120000-0030-0000-0000-0000000FF1CE}-C\EnterpriseWW.msi ErrorCode: 1603(0x643). \r\n") ret=006dbfec --- snip ---
I dumped the full command line from a debugger with 64 characters per line to fit here/preserve whitespace/breaks.
--- snip --- $ ADDLOCAL=CAGOffice10Intl_1031,MsoInstalledPackagesScopedIntl_103 $+80 1,MSTagPluginNamesFilesIntl_1031,VBAHelpFilesIntl_1031,GraphicsF $+100 iltersJPEGFilesIntl_1031,Gimme_OnDemandData,CAGCat10Intl_1031,MS $+180 TagPluginDateFilesIntl_1031,MetricConverterIntl_1031,OISFilesInt $+200 l_1031,XDOCSEditorFilesIntl_1031,ProductNonBootFilesIntl_1031,Gr $+280 aphicsFiltersPNGFilesIntl_1031,CAGFilesIntl_1031,GraphicsFilters $+300 EPSFilesIntl_1031,GraphHelpFilesIntl_1031,SetupXmlFiles,Graphics $+380 FiltersCGMFilesIntl_1031,AceFilesIntl_1031,SetLanguageFilesIntl_ $+400 1031,GRAPHFilesIntl_1031,GraphicsFiltersGIFFilesIntl_1031,SetupC $+480 ontrollerFiles,MsInfoFilesIntl_1031,EquationEditorFilesIntl_1031 $+500 ,AlwaysInstalledIntl_1031,WebDiscussFilesIntl_1031,QueryFilesInt $+580 l_1031,ProductFilesIntl_1031,MSSOAP3Intl_1031,OfficeVBAHelpIntlH $+600 iddenIntl_1031,LISTFilesIntl_1031,ClviewFilesIntl_1031,WebDriveF $+680 ilesIntl_1031,OSetupControllerIntl_1031,WISPHiddenIntl_1031,AceR $+700 eplIntl_1031,OfficeDigitalSFilesIntl_1031,TOOLSFilesIntl_1031,TC $+780 RecoverFilesIntl_1031,VisioPreviewerIntl_1031,TCWP6FilesIntl_103 $+800 1,GraphicsFiltersPICTFilesIntl_1031,TCWP5FilesIntl_1031,VBAFiles $+880 Intl_1031,HTMLSourceEditingIntl_1031,SetLanguageHelpFilesIntl_10 $+900 31,GraphicsFiltersWPGFilesIntl_1031 REMOVE=MSPHELPIntl_1031,WebD $+980 ebuggingIntl_1031 ADVERTISE=MSOfficeDocumentImagingIntl_1031 ARP $+A00 ENTRY_HELPTELEPHONE="" ARPENTRY_NOREMOVE="#0" ARPENTRY_CONTACT=" $+A80 " ARPENTRY_HELPLINK="" ARPENTRY_NOREPAIR="#1" ARPENTRY_SHELLUITR $+B00 ANSFORMLANGUAGE="de-DE" ARPENTRY_SKUCOMPONENTS="[~]C:\Program Fi $+B80 les\Common Files\Microsoft Shared\OFFICE12\Office Setup Controll $+C00 er\InfoPath.de-de\setup.xml[~]C:\Program Files\Common Files\Micr $+C80 osoft Shared\OFFICE12\Office Setup Controller\OneNote.de-de\setu $+D00 p.xml[~]C:\Program Files\Common Files\Microsoft Shared\OFFICE12\ $+D80 Office Setup Controller\Proofing.de-de\setup.xml[~]C:\Program Fi $+E00 les\Common Files\Microsoft Shared\OFFICE12\Office Setup Controll $+E80 er\Word.de-de\setup.xml[~]C:\Program Files\Common Files\Microsof $+F00 t Shared\OFFICE12\Office Setup Controller\Groove.de-de\setup.xml $+F80 [~]C:\Program Files\Common Files\Microsoft Shared\OFFICE12\Offic $+1000 e Setup Controller\Outlook.de-de\setup.xml[~]C:\Program Files\Co $+1080 mmon Files\Microsoft Shared\OFFICE12\Office Setup Controller\Pub $+1100 lisher.de-de\setup.xml[~]C:\Program Files\Common Files\Microsoft $+1180 Shared\OFFICE12\Office Setup Controller\ENTERPRISE\setup.xml[~] $+1200 C:\Program Files\Common Files\Microsoft Shared\OFFICE12\Office S $+1280 etup Controller\Office.de-de\setup.xml[~]C:\Program Files\Common $+1300 Files\Microsoft Shared\OFFICE12\Office Setup Controller\Rosebud $+1380 .de-de\setup.xml[~]C:\Program Files\Common Files\Microsoft Share $+1400 d\OFFICE12\Office Setup Controller\Access.de-de\setup.xml[~]C:\P $+1480 rogram Files\Common Files\Microsoft Shared\OFFICE12\Office Setup $+1500 Controller\Excel.de-de\setup.xml[~]C:\Program Files\Common File $+1580 s\Microsoft Shared\OFFICE12\Office Setup Controller\PowerPoint.d $+1600 e-de\setup.xml[~]" ARPENTRY_URLINFOABOUT="" ARPENTRY_CACHELOCATI $+1680 ON="C:\MSOCache\All Users" ACCEPTEDEULA="1" ARPENTRY_DISPLAYICON $+1700 ="C:\Program Files\Common Files\Microsoft Shared\OFFICE12\Office $+1780 Setup Controller\OSETUP.DLL,1" ARPENTRY_MODIFYPATH="""C:\Progra $+1800 m Files\Common Files\Microsoft Shared\OFFICE12\Office Setup Cont $+1880 roller\setup.exe"" /modify ENTERPRISE /dll OSETUP.DLL" ARPENTRY_ $+1900 NOELEVATEONMODIFY="#1" ARPENTRY_PACKAGEIDS="[~]OfficeMUI.de-de[~ $+1980 ]ExcelMUI.de-de[~]OutlookMUI.de-de[~]PowerPointMUI.de-de[~]Roseb $+1A00 udMUI.de-de[~]GrooveMUI.de-de[~]InfoPathMUI.de-de[~]Proof.it-it[ $+1A80 ~]Proof.de-de[~]Proof.fr-fr[~]Proof.en-us[~]Proofing.de-de[~]Pub $+1B00 lisherMUI.de-de[~]WordMUI.de-de[~]AccessMUI.de-de[~]OneNoteMUI.d $+1B80 e-de[~]EnterpriseWW[~]" ARPENTRY_PRODUCTCODES="[~]{90120000-006E $+1C00 -0407-0000-0000000FF1CE}[~]{90120000-0016-0407-0000-0000000FF1CE $+1C80 }[~]{90120000-001A-0407-0000-0000000FF1CE}[~]{90120000-0018-0407 $+1D00 -0000-0000000FF1CE}[~]{90120000-0010-0407-0000-0000000FF1CE}[~]{ $+1D80 90120000-00BA-0407-0000-0000000FF1CE}[~]{90120000-0044-0407-0000 $+1E00 -0000000FF1CE}[~]{90120000-001F-0410-0000-0000000FF1CE}[~]{90120 $+1E80 000-001F-0407-0000-0000000FF1CE}[~]{90120000-001F-040C-0000-0000 $+1F00 000FF1CE}[~]{90120000-001F-0409-0000-0000000FF1CE}[~]{90120000-0 $+1F80 02C-0407-0000-0000000FF1CE}[~]{90120000-0019-0407-0000-0000000FF $+2000 1CE}[~]{90120000-001B-0407-0000-0000000FF1CE}[~]{90120000-0015-0 $+2080 407-0000-0000000FF1CE}[~]{90120000-00A1-0407-0000-0000000FF1CE}[ $+2100 ~]{90120000-0030-0000-0000-0000000FF1CE}[~]" INSTALLLOCATION="C: $+2180 \Program Files\Microsoft Office" REMOVEPREVIOUS="" REMOVESAMEVER $+2200 SION="" SETUPEXE_DOARPWRITE="1" SETUPEXEINSTALLUICULTURE="de-DE" $+2280 WATSONSQM="AUTOREPORT" ARPENTRY_INSTALLLOCATION="C:\Program Fil $+2300 es\Microsoft Office" ARPENTRY_UNINSTALLSTRING="""C:\Program File $+2380 s\Common Files\Microsoft Shared\OFFICE12\Office Setup Controller $+2400 \setup.exe"" /uninstall ENTERPRISE /dll OSETUP.DLL" ARPENTRY_URL $+2480 UPDATEINFO="" BRANDING_XML="C:\users\focht\Temp\Setup0000002d\BR $+2500 ANDING.XML" ARPENTRY_DISPLAYVERSION="12.0.4518.1014" ARPENTRY_DI $+2580 SPLAYNAME="Microsoft Office Enterprise 2007" ARPENTRY_NOMODIFY=" $+2600 #0" REBOOT=ReallySuppress LAUNCHEDBYSETUPEXE=1 MSIRESTARTMANAGER $+2680 CONTROL="Disable" SETUPEXEINSTALLUILANGUAGE=1031 SETUPINTLDLLDIR $+2700 ECTORY="C:\users\focht\Temp\Setup0000002d" ARPSYSTEMCOMPONENT=1 $+2780 ALLUSERS="1" PIDKEY=foobar --- snip ---
(unrelated) tidbit: There is an msi log message, stating: "... Exiting custom action. Not failing install for now.". Of course the overall install is bound to fail since the CA returns a 1603. Not sure if it's just misleading here.
$ wine --version wine-1.7.54-59-g8f44307
Regards
https://bugs.winehq.org/show_bug.cgi?id=39544
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Installer, regression Regression SHA1| |42caac841e1755570ba25c2ce95 | |948fc28f31372
https://bugs.winehq.org/show_bug.cgi?id=39544
Dmitry Timoshkov dmitry@baikal.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dmitry@baikal.ru
--- Comment #1 from Dmitry Timoshkov dmitry@baikal.ru --- Thanks for the report.
Looks like my patch broke parsing of empty properties like ARPENTRY_HELPTELEPHONE="" and similar in the following command line snippet: ... ARPENTRY_HELPTELEPHONE="" ARPENTRY_NOREMOVE="#0" ARPENTRY_CONTACT="" ARPENTRY_HELPLINK="" ARPENTRY_NOREPAIR="#1" ...
https://bugs.winehq.org/show_bug.cgi?id=39544
--- Comment #2 from Dmitry Timoshkov dmitry@baikal.ru --- Created attachment 52699 --> https://bugs.winehq.org/attachment.cgi?id=52699 patch
Does the attached patch help?
https://bugs.winehq.org/show_bug.cgi?id=39544
--- Comment #3 from Dmitry Timoshkov dmitry@baikal.ru --- I've found an old copy of Office 2007 Std and the patch fixes the regression.
https://bugs.winehq.org/show_bug.cgi?id=39544
--- Comment #4 from Dmitry Timoshkov dmitry@baikal.ru --- Just in case here is the problematic property that has caused the regression:
ARPENTRY_MODIFYPATH="""C:\Program Files\Common Files\Microsoft Shared\OFFICE12\Office Setup Controller\setup.exe"" /modify ENTERPRISE /dll OSETUP.DLL"
https://bugs.winehq.org/show_bug.cgi?id=39544
Dmitry Timoshkov dmitry@baikal.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |2d7f00c8d38777266dcf585c047 | |c05fa7a7e0fb7 Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #5 from Dmitry Timoshkov dmitry@baikal.ru --- Incorrect commit has been reverted.
https://bugs.winehq.org/show_bug.cgi?id=39544
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #6 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 1.7.55.