[Bug 33496] New: pylotro - LOTRO doesn't shows after successful login

http://bugs.winehq.org/show_bug.cgi?id=33496

Bug #: 33496
           Summary: pylotro - LOTRO doesn't shows after successful login
           Product: Wine
           Version: 1.5.29
          Platform: x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Created attachment 44342
  --> http://bugs.winehq.org/attachment.cgi?id=44342
pylotro log.  debug flags used: fixme-all,+x11settings,+ddraw,+process

After updating wine from 1.5.28 to 1.5.29, the game doesn't shows any more,
showing instead a similar screen image to the obtained if used Nouveau drivers
(opposed to the proprietary Nvidia drivers).

If is used a 1.5.28 source compiled wine, then the game starts as usual.

[Bug 33496] pylotro - LOTRO doesn't shows after successful login

http://bugs.winehq.org/show_bug.cgi?id=33496

--- Comment #1 from [e-mail] 2013-05-01 08:16:56 CDT ---
Created attachment 44343
  --> http://bugs.winehq.org/attachment.cgi?id=44343
pylotro log;wine 1.5.28 context;  debug flags used:
fixme-all,+x11settings,+ddraw,+process

log a successful launch, using a different wine context for wine 1.5.28

[Bug 33496] pylotro - LOTRO doesn't shows after successful login

http://bugs.winehq.org/show_bug.cgi?id=33496

John Lauder  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from John Lauder  2013-05-06 03:20:47 CDT ---
Same for me, 1.5.29 breaks lotro.  I can log in using pylotro, but the game
doesn't seem to start.

[Bug 33496] pylotro - LOTRO doesn't shows after successful login

http://bugs.winehq.org/show_bug.cgi?id=33496

--- Comment #3 from [e-mail] 2013-05-18 23:13:35 CDT ---
Same behaviour observed in 1.5.30. Stills working with 1.5.28

[Bug 33496] pylotro - LOTRO doesn't shows after successful login

http://bugs.winehq.org/show_bug.cgi?id=33496

joaopa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from joaopa  2013-05-19 10:32:57 CDT ---
Without a regression test, this bug has almost no chance to be fixed:

http://wiki.winehq.org/RegressionTesting

[Bug 33496] pylotro - LOTRO doesn't shows after successful login

http://bugs.winehq.org/show_bug.cgi?id=33496

--- Comment #5 from [e-mail] 2013-05-29 20:57:59 CDT ---
Regression test results:

jorge@LinuxPC:~/wine-git$ git bisect good
37169522f62f85048900cf3329fb54800cbb8f3e is the first bad commit
commit 37169522f62f85048900cf3329fb54800cbb8f3e
Author: Gurmail Bassi 
Date:   Sun Apr 14 22:25:03 2013 +0100

dinput: Update existing joystick values after setting the range property.

:040000 040000 506fcdd44322f1380920a7d31cce56caf3243c73
694b1dc5f898c636a0ac7c9e68e007f1fb7bda22 M    dlls

It was quite surprising but changing the wineprefix to the default in pylotro
(wine post 1.5.28) AND unplugging my usb game pad befor runnining pylotr, the
game started as expected

[Bug 33496] pylotro - LOTRO doesn't shows after successful login

http://bugs.winehq.org/show_bug.cgi?id=33496

--- Comment #6 from [e-mail] 2013-05-29 21:40:44 CDT ---
(In reply to comment #5)
> Regression test results:
>
> jorge@LinuxPC:~/wine-git$ git bisect good
> 37169522f62f85048900cf3329fb54800cbb8f3e is the first bad commit
> commit 37169522f62f85048900cf3329fb54800cbb8f3e
> Author: Gurmail Bassi 
> Date:   Sun Apr 14 22:25:03 2013 +0100
> dinput: Update existing joystick values after setting the range property.
>
> :040000 040000 506fcdd44322f1380920a7d31cce56caf3243c73
> 694b1dc5f898c636a0ac7c9e68e007f1fb7bda22 M    dlls
>
> It was quite surprising but changing the wineprefix to the default in pylotro
> (wine post 1.5.28) AND unplugging my usb game pad befor runnining pylotr, the
> game started as expected

To be clearer: the game runs as usual with the gamepad plugged in, while using
wine 1.5.28, but no with higher versions

[Bug 33496] pylotro - LOTRO doesn't shows after successful login

http://bugs.winehq.org/show_bug.cgi?id=33496

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
          Component|-unknown                    |directx-dinput
    Regression SHA1|                            |37169522f62f85048900cf3329f
                   |                            |b54800cbb8f3e

--- Comment #7 from Austin English  2013-05-29 21:45:28 CDT ---
Interesting, thanks.

[Bug 33496] pylotro - LOTRO doesn't shows after successful login

http://bugs.winehq.org/show_bug.cgi?id=33496

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from [e-mail] 2013-05-31 17:56:26 CDT ---
A new patch has been issued (96601) which removes the offending code generated
by the previous patch (95617) - hopefully this will be committed to the next
version of Wine, and the issue resolved

[Bug 33496] pylotro - LOTRO doesn't shows after successful login

http://bugs.winehq.org/show_bug.cgi?id=33496

Gurmail Bassi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from Gurmail Bassi  2013-06-04 15:55:40 CDT ---
In an update to the above - the original (bad) code from patch 95617 has not
been removed as yet, but a new working patch (96675) has just been submitted
which should hopefully be committed soon and resolve the issue for all users.

The cause of the error was that Wine was referencing a variable in (dinput:
joystick.c) SetProperty which doesn't get allocated until SetDataFormat is
called (and as LOTRO does this afterwards, the call would fail).

[Bug 33496] pylotro - LOTRO doesn't shows after successful login

http://bugs.winehq.org/show_bug.cgi?id=33496

--- Comment #10 from Bruno Jesus  2013-06-05 14:34:53 CDT ---
Patch commited:
http://source.winehq.org/git/wine.git/?a=commit;h=c34b7b13134e2479d3e25e8f89...

[Bug 33496] pylotro - LOTRO doesn't shows after successful login

http://bugs.winehq.org/show_bug.cgi?id=33496

--- Comment #11 from [e-mail] 2013-06-21 10:16:58 CDT ---
fixed in 1.6-rc2

[Bug 33496] pylotro - LOTRO doesn't shows after successful login

http://bugs.winehq.org/show_bug.cgi?id=33496

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |c34b7b13134e2479d3e25e8f899
                   |                            |5ff5a8abd2983
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #12 from Bruno Jesus  2013-06-21 10:18:57 CDT ---
(In reply to comment #11)
> fixed in 1.6-rc2

Thanks for testing.

[Bug 33496] pylotro - LOTRO doesn't shows after successful login

http://bugs.winehq.org/show_bug.cgi?id=33496

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #13 from Alexandre Julliard  2013-06-21 13:33:02 CDT ---
Closing bugs fixed in 1.6-rc3.